From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A89BC7EE30 for ; Tue, 1 Jul 2025 10:54:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3985C6B009A; Tue, 1 Jul 2025 06:54:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3488B6B009C; Tue, 1 Jul 2025 06:54:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 237C26B00A0; Tue, 1 Jul 2025 06:54:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0E4946B009A for ; Tue, 1 Jul 2025 06:54:52 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D7B791A0316 for ; Tue, 1 Jul 2025 10:54:51 +0000 (UTC) X-FDA: 83615387982.08.3840359 Received: from mailrelay-egress12.pub.mailoutpod2-cph3.one.com (mailrelay-egress12.pub.mailoutpod2-cph3.one.com [46.30.211.187]) by imf18.hostedemail.com (Postfix) with ESMTP id 8CAEA1C0011 for ; Tue, 1 Jul 2025 10:54:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=konsulko.se header.s=rsa1 header.b="Ahe/qpzT"; dkim=pass header.d=konsulko.se header.s=ed1 header.b=vtYwSA0N ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751367290; a=rsa-sha256; cv=none; b=qLDJxwsumwAxGvhA8fEVHN9sL1k6PTpDesYkPJ/NJOCrEBpplHeq8EStX4xAU51KCAO3co tIAGCvQTIbIsp8P9dpRHoo++D0ZOpUb3F+ZT5yq7VpPaTE4vwipC/bcgafGsD/32mxy1tJ 4pt+ojE/gHxFchiWH8eh5vbSZ7yJY8Y= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=konsulko.se header.s=rsa1 header.b="Ahe/qpzT"; dkim=pass header.d=konsulko.se header.s=ed1 header.b=vtYwSA0N; dmarc=none; spf=none (imf18.hostedemail.com: domain of vitaly.wool@konsulko.se has no SPF policy when checking 46.30.211.187) smtp.mailfrom=vitaly.wool@konsulko.se ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751367290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O6ogmbzCR79Zt1lKRcnTrEHJnz3sk69NVq+UdqhlbdM=; b=j2X99InEG+T6ORMf+uqKa+ckdFargf71vMMvJN5XExXJn0j7R1/0ETaWCUvPPALKlKTf65 4v7iSGqr/EXoQasgrgCJf7wK3nwibLtTHodDCvKZg97ZCo5XBYSjVGx59d8TTaz09XaXgE Ci6D0NA9Smb3reJV/UuTIl3LIYNHU40= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1751367287; x=1751972087; d=konsulko.se; s=rsa1; h=to:references:message-id:content-transfer-encoding:cc:date:in-reply-to:from: subject:mime-version:content-type:from; bh=O6ogmbzCR79Zt1lKRcnTrEHJnz3sk69NVq+UdqhlbdM=; b=Ahe/qpzTwR34N7lQ0cJ1V6/jHhr5ISQVHq12lCT0D70lWJ/YLhN2ekMlm7QoUf+VMcblfgQjI93lV ZFj/RPOqze51Ye4i8J3EBYGZYFfykd8gKdNHB33FRX3Mh0fPohRwbxDuSMYL5QAygYdHICj4kyw0LY kdnOu37aBv9jYQyWDSfl0MrtvN5Pit97Tm2ky+ZUCclIKqK1tqnUguvxG5PWsFzP0aVCaXoQ9ilyPr nXCCTh81X0FwTq9S0kBvifw/LvP42Rqafco1AfD56y0T1M4bDsSzm+8f/h+nMTKN0mOT3RY7S3wzcP vMIh4xFHodyrVZ9znWfGeqi//FUYUSA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1751367287; x=1751972087; d=konsulko.se; s=ed1; h=to:references:message-id:content-transfer-encoding:cc:date:in-reply-to:from: subject:mime-version:content-type:from; bh=O6ogmbzCR79Zt1lKRcnTrEHJnz3sk69NVq+UdqhlbdM=; b=vtYwSA0NUdeGf2LV+PMDWUmAsu8HGlxt/c+PLNa3ZOY7kolB1kBZPyC8Bgtkof85Pa8UTXnfhy76z ARFeAWyCQ== X-HalOne-ID: cd93c720-5669-11f0-aacd-85eb291bc831 Received: from smtpclient.apple (c188-150-224-8.bredband.tele2.se [188.150.224.8]) by mailrelay5.pub.mailoutpod2-cph3.one.com (Halon) with ESMTPSA id cd93c720-5669-11f0-aacd-85eb291bc831; Tue, 01 Jul 2025 10:54:47 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [PATCH v9 1/4] mm/vmalloc: allow to set node and align in vrealloc From: Vitaly Wool In-Reply-To: Date: Tue, 1 Jul 2025 12:54:36 +0200 Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <31E257E1-AB52-4115-A264-56F545AB84A9@konsulko.se> References: <20250630221511.3325123-1-vitaly.wool@konsulko.se> <20250630221615.3325221-1-vitaly.wool@konsulko.se> To: Uladzislau Rezki X-Mailer: Apple Mail (2.3826.200.121) X-Stat-Signature: g581xpjha3iqonnpfts3izofc89fcit7 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8CAEA1C0011 X-Rspam-User: X-HE-Tag: 1751367289-968648 X-HE-Meta: U2FsdGVkX18liDFVfL5Cfn+xvHXvP++GI7BjJMFC6Y3x3QO4tJbSmhvWkD7X6dPFzgCDWUpZopEnv3h0re/7fKvLdcqZ2k9ZYYNO0GVLpdSwix4OoAxqGUZHB27k0W+ixD9Groc+EvAzwozCIqD3QQXD72JwvlLgiL4D3AHWnTFsX5m96GlD2oo1DltEJ3O8Z163ftLSKM6dANmqC0J5Aty/XTadjh6VN1mr8hn5AjGMabPQKEn/7AlIJhhxYHRxXBLY1TSOOKQerULyvcxkHNSumQ0HwgZT41xynTJS2cZX6JIpwODWQIFNy+kEf0bI6exf09/Q3Y7sQrhZCoyK8q6LfNR9LgPAmvMc8WJVxbcMxu34FOZmGL234+8cl2r+wTQr0JaoMbdlq9XmshwdAnZQnug15rLXXAQrafZ5zlooQOIb1tgTGFmzNcIYYOUxZ9Hz6wD5O9zJj0ci6XWMHClBcC2E87C18Tb0/DuAglJ7TdkSilihozDSx1iprBMq00YfZXvhDrPfgQtehMH6Rz/89GDXQM5hn9koNvRycZrceVDXgB7V7hlL4c170sjaOmfYLvEZ93iKRUORYMgjVXswjq5ZQBMOWgR6tEobGyVDX2DQI0GCztY5+UgEC7uIqrMix8XMsHbGFaPQFs7lwYkbfCvckocJts66y3YvqrkKiHg9iUavHZ8NkhZeCQ3y/Fxc9oED56B/O1ycEnwkzA7T39iPfvQIGi9Z+II4utYsuxvBtYI6Uo6NAqtwTcpAPr8Ll/F+ipq8MTyKyr19QpCG4OFiORo+vhh3z9CjpnrZZwtHiPNs/kfnmqQof2R1Us6q7EH4NVpC3aUEKd9PM2z0ie45bLYbLfv4NzmxcKhDIFjpE6ZM2lNO4HNfTUIPYMmjKyiBCSDcOnaaG6BwJL9SaTz1DC6ULeSFdawbxYsp/XKOdbYhskC9sSPpCkoyVR+1w/McFIwMCljgwnY QajcZAPY 97jJXSQ8H4BXTgBvzw7iMYg8mT1ndZj77Zj0mChv4eV0yGDNgEzbiPbaF9UsfSJLgjD+PnlDwJafChRL5X+hbGOV1S7DryJIK2AzdQpjt3MwfVv1SatYPNsYqze+Qz+yaLIQXjIbsoyoROxNu3bgQkpUhBQjbIJazWCubbr8nUm7a/cPuItpkHgBt9CYML9zVnugV1kq2Rckvsyo1hdYuvzC6ib85SSQ+O9sJsVrYoNMsz4w9hmJ+2VuC8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Jul 1, 2025, at 12:50=E2=80=AFPM, Uladzislau Rezki = wrote: >=20 > On Tue, Jul 01, 2025 at 12:16:15AM +0200, Vitaly Wool wrote: >> Reimplement vrealloc() to be able to set node and alignment should >> a user need to do so. Rename the function to vrealloc_node_align() >> to better match what it actually does now and introduce macros for >> vrealloc() and friends for backward compatibility. >>=20 >> With that change we also provide the ability for the Rust part of >> the kernel to set node and aligmnent in its allocations. >>=20 >> Signed-off-by: Vitaly Wool >> --- >> include/linux/vmalloc.h | 12 +++++++++--- >> mm/vmalloc.c | 19 +++++++++++++++---- >> 2 files changed, 24 insertions(+), 7 deletions(-) >>=20 >> diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h >> index fdc9aeb74a44..68791f7cb3ba 100644 >> --- a/include/linux/vmalloc.h >> +++ b/include/linux/vmalloc.h >> @@ -197,9 +197,15 @@ extern void *__vcalloc_noprof(size_t n, size_t = size, gfp_t flags) __alloc_size(1 >> extern void *vcalloc_noprof(size_t n, size_t size) __alloc_size(1, = 2); >> #define vcalloc(...) alloc_hooks(vcalloc_noprof(__VA_ARGS__)) >>=20 >> -void * __must_check vrealloc_noprof(const void *p, size_t size, = gfp_t flags) >> - __realloc_size(2); >> -#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) >> +void *__must_check vrealloc_node_align_noprof(const void *p, size_t = size, >> + unsigned long align, gfp_t flags, int nid) __realloc_size(2); >> +#define vrealloc_node_noprof(_p, _s, _f, _nid) \ >> + vrealloc_node_align_noprof(_p, _s, 1, _f, _nid) >> +#define vrealloc_noprof(_p, _s, _f) \ >> + vrealloc_node_align_noprof(_p, _s, 1, _f, NUMA_NO_NODE) >> +#define vrealloc_node_align(...) = alloc_hooks(vrealloc_node_align_noprof(__VA_ARGS__)) >> +#define vrealloc_node(...) = alloc_hooks(vrealloc_node_noprof(__VA_ARGS__)) >> +#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) >>=20 >> extern void vfree(const void *addr); >> extern void vfree_atomic(const void *addr); >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index 6dbcdceecae1..776c68f84ce2 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -4089,12 +4089,15 @@ void *vzalloc_node_noprof(unsigned long size, = int node) >> EXPORT_SYMBOL(vzalloc_node_noprof); >>=20 >> /** >> - * vrealloc - reallocate virtually contiguous memory; contents = remain unchanged >> + * vrealloc_node_align_noprof - reallocate virtually contiguous = memory; contents >> + * remain unchanged >> * @p: object to reallocate memory for >> * @size: the size to reallocate >> + * @align: requested alignment >> * @flags: the flags for the page level allocator >> + * @nid: node id >> * >> - * If @p is %NULL, vrealloc() behaves exactly like vmalloc(). If = @size is 0 and >> + * If @p is %NULL, vrealloc_XXX() behaves exactly like vmalloc(). If = @size is 0 and >> * @p is not a %NULL pointer, the object pointed to is freed. >> * >> * If __GFP_ZERO logic is requested, callers must ensure that, = starting with the >> @@ -4111,7 +4114,8 @@ EXPORT_SYMBOL(vzalloc_node_noprof); >> * Return: pointer to the allocated memory; %NULL if @size is zero or = in case of >> * failure >> */ >> -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) >> +void *vrealloc_node_align_noprof(const void *p, size_t size, = unsigned long align, >> + gfp_t flags, int nid) >> { >> struct vm_struct *vm =3D NULL; >> size_t alloced_size =3D 0; >> @@ -4135,6 +4139,11 @@ void *vrealloc_noprof(const void *p, size_t = size, gfp_t flags) >> if (WARN(alloced_size < old_size, >> "vrealloc() has mismatched area vs requested sizes (%p)\n", p)) >> return NULL; >> + if (WARN(!IS_ALIGNED((unsigned long)p, align), >> + "will not reallocate with a bigger alignment (0x%lx)\n", align)) >> + return NULL; >> + if (nid !=3D NUMA_NO_NODE && nid !=3D = page_to_nid(vmalloc_to_page(p))) >> + goto need_realloc; >>=20 > By this goto change, you bypass the two important checks below. For > example if you shrink the allocated size, you do not need to perform > any allocations. Instead the patch goes and allocates a new area. >=20 > You just need to remove: >=20 > - if (nid !=3D NUMA_NO_NODE && nid !=3D = page_to_nid(vmalloc_to_page(p))) > - goto need_realloc; >=20 > to make it working. >=20 I am not sure I=E2=80=99m following. If we get a request to reallocate = for a different node then we should either reject it or do the new = allocation for this new node and copy the data to the new place. = Shrinking the allocation on the old node doesn=E2=80=99t seem to be = right. Or am I missing something? ~Vitaly