From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20515C3DA4A for ; Wed, 14 May 2025 17:57:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A5526B0202; Wed, 14 May 2025 13:57:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 930FE6B0203; Wed, 14 May 2025 13:57:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75A2E6B0204; Wed, 14 May 2025 13:57:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 522DF6B0202 for ; Wed, 14 May 2025 13:57:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E1F1750FB3 for ; Wed, 14 May 2025 17:57:37 +0000 (UTC) X-FDA: 83442270954.04.DFFB279 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 50675C000C for ; Wed, 14 May 2025 17:57:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AEDv9zhg; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747245455; a=rsa-sha256; cv=none; b=lwqCO+1vXwiC7dp83k0FfGQBlMFJZDWBo+iBEtII22UyYQOKdKHVa64LbAbwmkjHboUQFr QyLWMEFRQEtvHE4bjE11zhucOvUSRLT3/bMJxy+wwWJkQICf1QDLOF+OWRQCCDVWMBE/6y DQJYqgMcyHDRsKRWXQQDylovPR0uQtU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AEDv9zhg; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747245455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0bWZ4WIW6USGmd3fCtPku9lyZiPCoKVx7jpPxXIn3KU=; b=d1mkR6q15Iph/STkAcxIV3LU5FMoULyZ6/b8aUTRco9V76ke717mzL8ribrpsmU4cwVm3x ekiiKEX5upCIYytSQyp7VcaInX31Nz+Y2Nbn7yibf7lFjHx6tIKYQVDWt7SdAhVefbeLwf cPJ1QaTfiNVTUBK/+7KjBfDG5Hg1zB4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747245454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0bWZ4WIW6USGmd3fCtPku9lyZiPCoKVx7jpPxXIn3KU=; b=AEDv9zhgtwq26Bv5BDb21y56Ziv/St4gZFTVXFKO9pCwlSwXX+aT6F+dH3O/kskpVnsaAN jX+GTCIEfQyGnIm9a2zJ+WlFJ++fMDNV9/K9mO/36m8EMVhbp2nyFDPloRO4eVrHhGxMeC 3/VL29DKkVVywYtXAenUKAV53/e7Zqg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-T0HRNsMXOKi_gCSxzhoZDg-1; Wed, 14 May 2025 13:57:33 -0400 X-MC-Unique: T0HRNsMXOKi_gCSxzhoZDg-1 X-Mimecast-MFC-AGG-ID: T0HRNsMXOKi_gCSxzhoZDg_1747245452 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a1f6c5f4f2so15036f8f.2 for ; Wed, 14 May 2025 10:57:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747245452; x=1747850252; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0bWZ4WIW6USGmd3fCtPku9lyZiPCoKVx7jpPxXIn3KU=; b=qcXwZ0kbyREZdQIH4OzJ7mF4fyVY50DMcTCEr/c65dSA0IWpiUODkXb4C73jZrt1Gf z01Km/dLfjgwLNG+l3uBmUCrjLG3iZxhRaBdhjuWAf1uWpqnAmiQGGhDObqU7gWJhDBV FAb5kdNH3fY3ZgdneoRp3lIULlCkiWU1u09l3rtLoUnxvy7QBWqoDYbFuZL5Qvop6nFe lkKIYbmqTl9OrpZkhaIvzaN4WMX0ShRiiP0bH4aRviHgGwYsO37LC1Sx2PVqpo0BDIC1 HJicZzquW0zdrDhVqoezwiVlqG+pp5rsxbhrUzQ9sc/ndInY2OIb3K5T0PXIyoujMpPw HXUQ== X-Forwarded-Encrypted: i=1; AJvYcCXBEIPPrImVsqLV6w5rifbp/NSrArWzdOv8IOc95lZEfyAflyJG6HE5ZF8DvlYKfvCjmuNuA7jbwA==@kvack.org X-Gm-Message-State: AOJu0Yz1XLU6RSqtS6Uuk8y4xOLrS3AnCLk8TZwz/rI6IRJ6sceQygla LCLuP+mXxXPltWhGqbYbh9C0BvL73OCxeIxR25ukAthbq32HpjPreuf4tECyhq96WPf8rOeCqd+ lxyXSOq6fSNZNqsgUMOolVfYSXA65Tw/6AuuK4jW+w29qQo6TLtrjaGK9LzM= X-Gm-Gg: ASbGncvikaGVl5zs60XEiwL9yaUGrRCVCLfeJci9TFJyKcFyurUq1S4TYMGPLzwo+8/ 1TzWPfljCQkP9H3xfLEiCrchGrk5vfsVH+axf6SApzohQkNbCbPkGRflm9j/Qjq7DkaZZImhl2Z vXnfguQn0GureeINNyMxdz607Q+k+SkejYaehnStAhIr2uwZZliHQJ4M6t+zaoLDchj70EVh5hb Qim1LT3mVzIsIWdUHva9cb8UyoLUquE4IIcDs6ySx4zO4J1NCPXLw7MXdLURqVUg0xhn+MoomAF wtEzLlhU9wND/2YtrLjFRRBsfzGnGv9LmCib8nejgRSyp7HQvEUN+WI38Wa4wgufkb+almPrW91 dzU0BdHO44rGEXxaqQzlLvL/J/7AhdRwa1tu6vHs= X-Received: by 2002:a05:6000:430d:b0:3a0:b5db:559a with SMTP id ffacd0b85a97d-3a349954e89mr3786735f8f.59.1747245452359; Wed, 14 May 2025 10:57:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFp4OKdBffaHI+7gilOZzshfSllV9gdjyqy9+7eDS0fOGPhf7CpV4/kX9mFGXIv7GQk11jdug== X-Received: by 2002:a05:6000:430d:b0:3a0:b5db:559a with SMTP id ffacd0b85a97d-3a349954e89mr3786725f8f.59.1747245451911; Wed, 14 May 2025 10:57:31 -0700 (PDT) Received: from ?IPV6:2003:d8:2f15:6200:d485:1bcd:d708:f5df? (p200300d82f156200d4851bcdd708f5df.dip0.t-ipconnect.de. [2003:d8:2f15:6200:d485:1bcd:d708:f5df]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58ecadfsm20235782f8f.22.2025.05.14.10.57.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 10:57:31 -0700 (PDT) Message-ID: <31998178-7f18-4c5c-9207-180998768cfe@redhat.com> Date: Wed, 14 May 2025 19:57:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/11] mm: introduce pfnmap_track() and pfnmap_untrack() and use them for memremap To: "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu , Ingo Molnar References: <20250512123424.637989-1-david@redhat.com> <20250512123424.637989-4-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mIQ6w7KR9EwY6bq7njusBSrj9sl4gUfIREhrRSgVC0c_1747245452 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 50675C000C X-Stat-Signature: 3uekgy74g845yauug6wgo47i7hqj7aei X-HE-Tag: 1747245455-343591 X-HE-Meta: U2FsdGVkX182RJWAz31d7pA+uJS38PsbQJcF+hlE+v6Q5LmHfv0NAoTc9ShK9ENq916ivDc24AB9T1MIa2GwtJp8iq3aCo38Cij1ijLrrNSgG+HjS73RK4voixrt9jVDRUeFqdisnH/lOyup1H/zZ6rHEb0jMZ8BXTrrGVYQVg8ztRKnf+30nS2HOgibHpxZJ/ZYUsKoFRuo22FusktB5CJ0fRNySxoc9fZ10Is+T12GABD7/ubkSKsx7p4W21KjbjdxDAhEROUgyEJhWUCxeqckE1uNIWnfEx7qe+PuB+vpvsgp/u2D/ywpvxDBwRRhPVdfR8xdXz7aKcJ5IzQIbuH4wwrBKUh7UAPnWng8AskvxRD52Jp+KKXJ1dwzrrXOojR2VWQGdNeHoxTBOpDAyAEDnUYYFgYkMxC2ug8/czsQqhYZTELwKzIM/vbIe9slJ0vNL2fr6j3zqrFX62EiFv28kTH+JHJj/fi4Db9k7QncfFoc17VXvOXhyN86xnMaIQ3DGAahJXxSGXnJZMjw0JVXWLxF522Y719KYUoTknZZ/63I0B4M7XlZX5Ef1N56tQfwGRsoArkKaGbn1bZh7Fw9io7vJEvTZYNxA7pSUAnjZhwgti1AA0lnY8auChwXo/8WZG+WzJIIVStB8VRTMFF4E7a4IrisV0tysBaGcWR7rBu8peH1P84w8KbNUlW61YmjMEjndx2ucKe38QlRdPFHu/0TAMq9ewxsZIZhyzHM0A1OmvklrXCooHEiOPd+xePY7pMuB6HwXruzD5du3FJLOpUn5k0FFvazXivn547ZYIXdVMwFmgLtvpnMDYwuekiy0WYGbww0KP5zfkD3iCq/RZSzbW+tf1QNVSFUlXFECwRzgSV3GQXhQP9Wukux6ZTlFMr9wsg6FOSVcgX1kEw9069BxmE5fvpcKDND7LT0b6TWk/F7m2zlp+DXzJypXa3nq/cH/lJRApgHMzg xFp6LG1w aFdqdR7lzTW2vBiBirVMsamc0ypqRJX6e4fiLyM22ORxpI18Ykw3V4pd/lwN+JkbdEQOq33AJiN5U68jxX1VBgwZlqmq/m2VfiOAowF8QGdTFRnJm1ct7lHIyW/vytS6yPmdcGh/XyluJqT+qNfZEeU5Xb/6yIGSONY2zSTghGSKdihqxFZmzBEd+cFavUwV7RXW2k/bAfZ/vzn5l5ZRk+Gx+mx8g2yfn8/dQbpLhmcXQvPuv0+hp6r4brlExztoKlqMIBUwLxr0tAzB2b3HItMkf2pPoNc91U7qu7ACyzXsV+DTa8e+hLGh9xwUWEMVn7bJ1AmEB3o4kgqw4xKQkBbm2ywzkyRvIgIzudY+ymSrU2RjAhOie4PMhb0ubyvfsxfrQSsb97558fzVYfSSTpYelPOepO6uuXke8e8DCuxWbdpbSAyH7yNBD2sQz7lj00dghS6jyZA4Nz105k+4dbJiRwWENGFhpHZaOdak3xWxGKeXPH2axSW+GgFdyST167IdIKYjZdZ8cTl8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.05.25 19:40, Liam R. Howlett wrote: > * David Hildenbrand [250512 08:34]: >> Let's provide variants of track_pfn_remap() and untrack_pfn() that won't >> mess with VMAs, and replace the usage in mm/memremap.c. >> >> Add some documentation. >> >> Reviewed-by: Lorenzo Stoakes >> Acked-by: Ingo Molnar # x86 bits >> Signed-off-by: David Hildenbrand > > Small nit with this one, but either way: > > Reviewed-by: Liam R. Howlett Thanks! [...] > > The other user is pfnmap_track_ctx_alloc() in mm/memory.c which is > called from remap_pfn_range(), which also has addr. > > Couldn't we just use the address directly? > > I think the same holds for untrack as well. Hm, conceptually, I want the "pfntrack" interface to consume ... PFNs :) Actually, I was thinking about converting the "size" parameter to nr_pages as well, but decided to leave that for another day. ... because I really should be working on (... checking todo list ...) anything else but PAT at this point. So unless there are strong feelings, I'll leave it that way (the way the old interface also used it), and add it to my todo list (either make it an address or make size -> nr_pages). Thanks for all the review Liam! -- Cheers, David / dhildenb