From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FC9C3DA64 for ; Thu, 1 Aug 2024 08:06:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 029B16B0098; Thu, 1 Aug 2024 04:06:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1B216B0099; Thu, 1 Aug 2024 04:06:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D46B46B009A; Thu, 1 Aug 2024 04:06:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B9AB96B0098 for ; Thu, 1 Aug 2024 04:06:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6A813160937 for ; Thu, 1 Aug 2024 08:06:42 +0000 (UTC) X-FDA: 82402945044.10.E2857AC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 158B8C0021 for ; Thu, 1 Aug 2024 08:06:39 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IvV3a+1h; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mOmx0YdH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IvV3a+1h; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mOmx0YdH; dmarc=none; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722499554; a=rsa-sha256; cv=none; b=eFULINdAKqqMnpUtapA2exG+dRb+8Sb8HtC5Mtj+fcCMdKUiQTUxYSOqvJ6dgXnEElIdhR oD9wp37l5tE0PiYkzTdnHmdYbvS5yniVTDxq7G8V5OEZH4L+tRYtwhe1TwaFcXdtbecMAD W+/puRrLQYZJUpxljz4lH0caks6x8SQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IvV3a+1h; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mOmx0YdH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IvV3a+1h; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mOmx0YdH; dmarc=none; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722499554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ceRe+g78mgzXvP7Pn16SKcrYPRGfu9OFsDe8NwfsDx0=; b=z7anJCfiuQLkAuMwpTgxS0NjfDOe6H2CH4NeXQUGSHekSr5DM35H0CKLkImmcpcPLoxUbO 9AFZd3NYN2Au8pR4o3J96attWzSfDBkXQeDBvMQC6bxSkh9mW19DbRhA6p1hEg7YFNdisd vXJ4Dt2dMemqHgdLS/iZ0JQ/vnZZgv4= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 440F11FB3D; Thu, 1 Aug 2024 08:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722499598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ceRe+g78mgzXvP7Pn16SKcrYPRGfu9OFsDe8NwfsDx0=; b=IvV3a+1h5kVX300Mc2JiZDFOHSryVZvWX7iQpF9AdxA7uH22t7BuVHVMEimQ5/stJKlkvu SSE6M1g0UPSqi6iFEUpTXtjlCbyEQU+Ss1XPQqHBJqaWODoL4U0GeCu2P0nmGiNXOwGfrk Xv9DNdNFY2dhN6vve5dMn+knlMunvJY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722499598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ceRe+g78mgzXvP7Pn16SKcrYPRGfu9OFsDe8NwfsDx0=; b=mOmx0YdH6ki0agTW3TUbHfvcXCIewn1wEaVaE/ad8WmIt47Wiuj4bXGiQ/XkaoioVUbbp0 3MHfVDjqGfyD0nCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722499598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ceRe+g78mgzXvP7Pn16SKcrYPRGfu9OFsDe8NwfsDx0=; b=IvV3a+1h5kVX300Mc2JiZDFOHSryVZvWX7iQpF9AdxA7uH22t7BuVHVMEimQ5/stJKlkvu SSE6M1g0UPSqi6iFEUpTXtjlCbyEQU+Ss1XPQqHBJqaWODoL4U0GeCu2P0nmGiNXOwGfrk Xv9DNdNFY2dhN6vve5dMn+knlMunvJY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722499598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ceRe+g78mgzXvP7Pn16SKcrYPRGfu9OFsDe8NwfsDx0=; b=mOmx0YdH6ki0agTW3TUbHfvcXCIewn1wEaVaE/ad8WmIt47Wiuj4bXGiQ/XkaoioVUbbp0 3MHfVDjqGfyD0nCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 226DA13946; Thu, 1 Aug 2024 08:06:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZtgRCA5Cq2anDAAAD6G6ig (envelope-from ); Thu, 01 Aug 2024 08:06:38 +0000 Message-ID: <319812ce-a15f-4004-a166-d281b8525616@suse.cz> Date: Thu, 1 Aug 2024 10:06:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: list_lru: fix UAF for memory cgroup Content-Language: en-US To: Muchun Song , akpm@linux-foundation.org Cc: hannes@cmpxchg.org, muchun.song@linux.dev, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shakeel Butt , stable@vger.kernel.org References: <20240801024603.1865-1-songmuchun@bytedance.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240801024603.1865-1-songmuchun@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 158B8C0021 X-Stat-Signature: ckseqmr9oh19j1wu86pwjj4ftypjd4zc X-Rspam-User: X-HE-Tag: 1722499599-173208 X-HE-Meta: U2FsdGVkX190Qoc/qz3NUwwR9YLJT9tuAsmbHt8eVeNjtBnTVxxg7HxbjTw4IQIu+slR043tT/9vBRYbE0eKxjChOz2ZCuJTh6/dU76h2UQyasTS3o++FwRyotqVCT/vXGbP0IY3AE43683/nx5Zb9O0EfnYxC1a8BK8Yw1nkpIeEQusDetYB8ewm3oxb1uohg6VzZ0LrBV/yLNtqAJE8UvrL7UdcFclll3rhTI8xJQtysgdrbC735uGGnOeC3QXrjYtliazCr21Pjx3MuD3yPlXMIa8ytMjIblhz4+uN60Ke8Gu5f6ST5ga4xlrQOMd9yZ4Wxu0rM4XHSafLgAYU3ZYAVwSY6MeyVA2jzwg7uP5SUCKM0EG12+ZT4LjOSIjQgcABEHzhgsYKa4FjwYKZ49oa0txGX51Cm0Yr3yUSBiFo4exZP8CQIgs/03RCiN3+sPAZDR4lXLXNQ1ZMKhT76uq4MUHgK0H138ILSP15MlZnof2XYP9fveszZ8SPmEL3DEL0/lhexUXxJbVZDeGH4fIo9hobyjngbXOAmwomof5ZUuK4ygyifsrLqGhwaEavOvFp0+9RBdiamN3he0l9m/Hcqaul39rTOQiIrjAAailNufzrG3eLZUjpSzYHj5Vtxy7Fy6Ik0XIeSP3bdRoX7J+/cppKr4ok6KXJCEZPMI3IucRy76zPpgdmFJfVSIe8lVwY2U76fg5fj5DSMTxDfeO0i0TgTdtX4/k4m2r+V2rLy40mOURem47ZBMnY6y7uVDkGAiyJoyXN6Ne7zaG9R8U/du93PAcb9iEKl92oNSovAM+hrE0wpqw0OaeqwSn7ul+Z/y1dGOogIF+qDWzH69epnqbXn6LZXC9KMfqPnprRLRBPt191A3kY86BpVr8K4bNyHj8Mi8HFIOH3Sp6Lw8fzLsA2vmpB/J8GRc1pwyl2Bwuf/cSJvNJ1ty3br+StWzpQIMtQyZ62X6hwxN Wa+I4m34 WKwBFecdanJszOLBCK+YcprytwDBILp+CNet/eHATmIcf0lybae8zuaE4fRxrkhXGOTrdYaV2eyelovCkwgMbBIXJDkFTEVsBejpeJ0pEPvgxK+gGBOiNubbBr/7jAvIqgh5FqK/sgZgdoI/EjK0Rrlf8RoohVITyoDNFgEZbv/xUrwmLnYltACuGRB3GpmaXY+POlKLu9Ab+jNZAxTJSIoL+V55vzpih8b7njyU1Tc4RLCkXHnxqTZ8rJ9RteqJE2j0/Oqd0gj+ip7J3eDHbHv1R/1XSbYhZ1j1ripQd1OYkcSHIxnqvTWU53pf1K6nBunBph0pe2d3GarSRzoMljy3IciTF6ZTX4ktfrtoRdebAKrBZQil54rdwZ6la5TLOcvIqB8NIj0QNzSACmXaQzXZ/y687Z21inOOgH7MKO+lhFQg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/1/24 04:46, Muchun Song wrote: > The mem_cgroup_from_slab_obj() is supposed to be called under rcu > lock or cgroup_mutex or others which could prevent returned memcg > from being freed. Fix it by adding missing rcu read lock. > > Fixes: 0a97c01cd20b ("list_lru: allow explicit memcg and NUMA node selection") > Signed-off-by: Muchun Song > Acked-by: Shakeel Butt > Cc: Acked-by: Vlastimil Babka > --- > v2: > Only grab rcu lock when necessary (Vlastimil Babka) > > mm/list_lru.c | 28 ++++++++++++++++++++++------ > 1 file changed, 22 insertions(+), 6 deletions(-) > > diff --git a/mm/list_lru.c b/mm/list_lru.c > index a29d96929d7c7..9b7ff06e9d326 100644 > --- a/mm/list_lru.c > +++ b/mm/list_lru.c > @@ -85,6 +85,7 @@ list_lru_from_memcg_idx(struct list_lru *lru, int nid, int idx) > } > #endif /* CONFIG_MEMCG */ > > +/* The caller must ensure the memcg lifetime. */ > bool list_lru_add(struct list_lru *lru, struct list_head *item, int nid, > struct mem_cgroup *memcg) > { > @@ -109,14 +110,22 @@ EXPORT_SYMBOL_GPL(list_lru_add); > > bool list_lru_add_obj(struct list_lru *lru, struct list_head *item) > { > + bool ret; > int nid = page_to_nid(virt_to_page(item)); > - struct mem_cgroup *memcg = list_lru_memcg_aware(lru) ? > - mem_cgroup_from_slab_obj(item) : NULL; > > - return list_lru_add(lru, item, nid, memcg); > + if (list_lru_memcg_aware(lru)) { > + rcu_read_lock(); > + ret = list_lru_add(lru, item, nid, mem_cgroup_from_slab_obj(item)); > + rcu_read_unlock(); > + } else { > + ret = list_lru_add(lru, item, nid, NULL); > + } > + > + return ret; > } > EXPORT_SYMBOL_GPL(list_lru_add_obj); > > +/* The caller must ensure the memcg lifetime. */ > bool list_lru_del(struct list_lru *lru, struct list_head *item, int nid, > struct mem_cgroup *memcg) > { > @@ -139,11 +148,18 @@ EXPORT_SYMBOL_GPL(list_lru_del); > > bool list_lru_del_obj(struct list_lru *lru, struct list_head *item) > { > + bool ret; > int nid = page_to_nid(virt_to_page(item)); > - struct mem_cgroup *memcg = list_lru_memcg_aware(lru) ? > - mem_cgroup_from_slab_obj(item) : NULL; > > - return list_lru_del(lru, item, nid, memcg); > + if (list_lru_memcg_aware(lru)) { > + rcu_read_lock(); > + ret = list_lru_del(lru, item, nid, mem_cgroup_from_slab_obj(item)); > + rcu_read_unlock(); > + } else { > + ret = list_lru_del(lru, item, nid, NULL); > + } > + > + return ret; > } > EXPORT_SYMBOL_GPL(list_lru_del_obj); >