From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E58C54EE9 for ; Tue, 20 Sep 2022 12:10:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3C9494000B; Tue, 20 Sep 2022 08:10:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEC98940009; Tue, 20 Sep 2022 08:10:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8D1A94000B; Tue, 20 Sep 2022 08:10:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A8B67940009 for ; Tue, 20 Sep 2022 08:10:40 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7D094A013F for ; Tue, 20 Sep 2022 12:10:40 +0000 (UTC) X-FDA: 79932347040.26.EA068EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 0E6FA1A000E for ; Tue, 20 Sep 2022 12:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663675839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tomIFmT2auPWgU52HW7Ixu9aQt/lJ7bkSj0XCxjEol8=; b=CLF9MVURwc3Td5fvG49UH0+Ggi57t43qyXaGPAkp1MY5/wCLrneEC+t1J0/beJo6I1RDSo 44sOzxgW3C13koMHC9+YjFY9VZJ3+TCSXBQ+9qpoXDmySykSfrN6szax2NdbPlICozph0u poqBr/Ijzn7Fm1HnQNS/+ec5rVebG5w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-509--SsL2cWBPvWnNxRxxhKaSg-1; Tue, 20 Sep 2022 08:10:38 -0400 X-MC-Unique: -SsL2cWBPvWnNxRxxhKaSg-1 Received: by mail-wm1-f69.google.com with SMTP id f25-20020a7bc8d9000000b003b4768dcd9cso579485wml.9 for ; Tue, 20 Sep 2022 05:10:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=tomIFmT2auPWgU52HW7Ixu9aQt/lJ7bkSj0XCxjEol8=; b=kSyyVC8AlywMa+dZd30PFjO8eEBDAqpFt2X5hPQkl5cROFPlVWhn1zZvAsuWvt/Uy2 nn8gltgADYCzblKc2Hq70l8ADtebV3FPP9uJKEUndkwybtt/HQ2MoZ+DBEBE/iX4xfP5 7jcPCQWyzatR/8eGgnYgHif3ZBJb7d1p/7SAPK9v8YWDdLtN7Q/h9boc7ya0Z5MN+0UM cbqK7ecb2lhelzn6hWp1Z/0lcttY7fSNwFIbfDr2Nn5a3PzmmJD5OX+TuAVWPBf5HWOk sRHXpSqG9tRWkUazGs57PcZ/ACOOYV2nuONXVk5QeHWSl/DGj+RQP+9RdzwC5/SE8EQ6 zIUQ== X-Gm-Message-State: ACrzQf1gf3f+bvYSu4z/GbBHOAg6VN1V28f7k4FNhKH2eVJ0Swzlda+i s1JxBc11v8T9H9bnK6JDhIvj0tOme+moz6Ur1rEKfApVe6aYhKsqAN97tz/tviirn3FTjzkF1vV YKbjbG70ABxA= X-Received: by 2002:a05:6000:815:b0:22a:418e:f354 with SMTP id bt21-20020a056000081500b0022a418ef354mr13956797wrb.97.1663675837139; Tue, 20 Sep 2022 05:10:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7WQqz1rESE7cF5L6XLg90fFIoyXCvRsKbGaq9PEEF6VFsm7YhkfEjvOeeeX5sDsAdwlyWJKw== X-Received: by 2002:a05:6000:815:b0:22a:418e:f354 with SMTP id bt21-20020a056000081500b0022a418ef354mr13956784wrb.97.1663675836799; Tue, 20 Sep 2022 05:10:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c712:2300:e82d:5a58:4fd8:c1e6? (p200300cbc7122300e82d5a584fd8c1e6.dip0.t-ipconnect.de. [2003:cb:c712:2300:e82d:5a58:4fd8:c1e6]) by smtp.gmail.com with ESMTPSA id t9-20020a05600c198900b003b47b80cec3sm19087785wmq.42.2022.09.20.05.10.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 05:10:36 -0700 (PDT) Message-ID: <3196b824-bcee-0c44-bfd3-f6cd8a1e6719@redhat.com> Date: Tue, 20 Sep 2022 14:10:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] mm/secretmem: remove reduntant return value To: Xiu Jianfeng , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220920012205.246217-1-xiujianfeng@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220920012205.246217-1-xiujianfeng@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663675840; a=rsa-sha256; cv=none; b=V56NtT6I4fkhR8I4J9tQA4SQwGfAZJukDRiAtxsoIp1L3gxwXBMRM7fYlGBvyxpmSURHNk jvm50/WVyySjCKt8BS2sueo/gy6vK1PR/6x8V4VcXKogB27UejeoPWzSn0PaydNX1kZ7LA 9LCp7oBn9lsNLRRDAic1XUWBaQt/W50= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CLF9MVUR; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663675840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tomIFmT2auPWgU52HW7Ixu9aQt/lJ7bkSj0XCxjEol8=; b=OM0uYP49UpjMitgDix2blueiKIXE2X9cx/dgKlvoF5g9zT1qUATYSIbcofTVdnopoClfBF ntvy0/aZ03UIyXqkhlO6FKXcD2HsEMJ+qhF1XVV0t73vjeRtxlAOHz7Pzvgy9hMFe9H/Fn K5Ccd2NYf7GYki5bQSrgAU59DOJFwTg= X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: 1ump7yg7fpgrusz69pygj17fhxj1bywr X-Rspamd-Queue-Id: 0E6FA1A000E Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CLF9MVUR; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1663675839-131967 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.09.22 03:22, Xiu Jianfeng wrote: > The return value @ret is always 0, so remove it and return 0 directly. > > Signed-off-by: Xiu Jianfeng > --- > mm/secretmem.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 6a44efb673b2..04c3ac9448a1 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -278,10 +278,8 @@ static struct file_system_type secretmem_fs = { > > static int __init secretmem_init(void) > { > - int ret = 0; > - > if (!secretmem_enable) > - return ret; > + return 0; > > secretmem_mnt = kern_mount(&secretmem_fs); > if (IS_ERR(secretmem_mnt)) On top of which tree is that? 6.0-rc6 has here: if (IS_ERR(secretmem_mnt)) ret = PTR_ERR(secretmem_mnt); -- Thanks, David / dhildenb