From: David Hildenbrand <david@redhat.com>
To: Xiu Jianfeng <xiujianfeng@huawei.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/secretmem: remove reduntant return value
Date: Tue, 20 Sep 2022 14:10:35 +0200 [thread overview]
Message-ID: <3196b824-bcee-0c44-bfd3-f6cd8a1e6719@redhat.com> (raw)
In-Reply-To: <20220920012205.246217-1-xiujianfeng@huawei.com>
On 20.09.22 03:22, Xiu Jianfeng wrote:
> The return value @ret is always 0, so remove it and return 0 directly.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> mm/secretmem.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index 6a44efb673b2..04c3ac9448a1 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -278,10 +278,8 @@ static struct file_system_type secretmem_fs = {
>
> static int __init secretmem_init(void)
> {
> - int ret = 0;
> -
> if (!secretmem_enable)
> - return ret;
> + return 0;
>
> secretmem_mnt = kern_mount(&secretmem_fs);
> if (IS_ERR(secretmem_mnt))
On top of which tree is that?
6.0-rc6 has here:
if (IS_ERR(secretmem_mnt))
ret = PTR_ERR(secretmem_mnt);
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-20 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 1:22 Xiu Jianfeng
2022-09-20 12:10 ` David Hildenbrand [this message]
2022-09-20 12:35 ` xiujianfeng
2022-09-20 13:22 ` David Hildenbrand
2022-09-20 13:28 ` xiujianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3196b824-bcee-0c44-bfd3-f6cd8a1e6719@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox