From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA7C7C54E49 for ; Mon, 26 Feb 2024 13:04:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E4AE44015B; Mon, 26 Feb 2024 08:04:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4945B440147; Mon, 26 Feb 2024 08:04:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35C7844015B; Mon, 26 Feb 2024 08:04:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 277BA440147 for ; Mon, 26 Feb 2024 08:04:21 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 844FEA0C16 for ; Mon, 26 Feb 2024 13:04:19 +0000 (UTC) X-FDA: 81833973438.16.38AED91 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id E8352A0018 for ; Mon, 26 Feb 2024 13:04:16 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708952657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yjazdN8RBWFvqhPGMDx7Y36Oy/jbIeEjbI482XY1prE=; b=YKszz6bTXGIgL7jElksL2MiSo9fiirv3lJunT78VeYrNTFzMJY5alXYoc4O+CV/MMF9Z/K xYqrbjNBgUV1/01RL+JgVK79qdmih2DENgNQiAFoPYJ2AToqkJ1/+68h2apvQ5VJqMHyed T/FybfQdRPyEqXZhe/2iqP0j1JC8B8I= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708952657; a=rsa-sha256; cv=none; b=uYPJeeGvk6Wk70R6lAMA4WvYBL0JO+gBzfaseEQTgntsFfwOvxwgLXIE4OdR53EfSZKXsE R+8d0ez1OvS8BOwn3Vo4xMhZ4vldupgDmG0ke1Gg6hz2mQOA1rPEF80HtNWz4tQWLPyX5J nsO06YTXeNRadbWZa4MK2v+huyuHYIA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 70626DA7; Mon, 26 Feb 2024 05:04:54 -0800 (PST) Received: from [10.57.67.4] (unknown [10.57.67.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 291613F762; Mon, 26 Feb 2024 05:04:13 -0800 (PST) Message-ID: <318be511-06de-423e-8216-af869f27f849@arm.com> Date: Mon, 26 Feb 2024 13:04:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free Content-Language: en-GB To: Lance Yang , David Hildenbrand Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, zokeefe@google.com, fengwei.yin@intel.com References: <20240226083714.26187-1-ioworker0@gmail.com> <9bcf5141-7376-441e-bbe3-779956ef28b9@redhat.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E8352A0018 X-Rspam-User: X-Stat-Signature: p1ozoirysakcirpbabjfs1nmyk4zy5k4 X-Rspamd-Server: rspam01 X-HE-Tag: 1708952656-743686 X-HE-Meta: U2FsdGVkX1+rN6zCSdXrGUbJukKmVAC4VOqrGW0FLKZLcFwKs6ahFurL2RstoNHgzamDZx8DNT6swlRi3M+CO5ea+EHUFgqnyxsZ/LkKN7VbNsE0Ns+2xzMVFFizy0VErr6papmDq2f4Bg61j8UX6cJOf8k4klTunsNF/wKigGbW/nh2XJMySlWretdF/DxtB7YONVFQwqSuOsydZDyNMv+gJDxtxBEnswDsXKauxhyoqZKDMYaMqn4c3GnVNFRNU6a/160txqaIExS5i29On4EpRAGkPEy70htI/iC45puY5E/N7893TmcWiCjJi5UULs214ZJ9a3uFjwlHlTlrmih2V6rohYBrpHpt4tmqpj9h5JZDcShcNwUuCvkfHSNbVzH0PkEvDAS01aEPyjw6uShPO2OhW+kjL9joxRgXgNyud4DgRZptOP9VxurNfxpWqm287UCoTRHxSPdQVzg/m2wWRN6z6Hbc10kNXjO1ojad8Xql67QT4/hitx5m2/c2BuQk9p6c+guT2SpXHPpa7GWuqojMQT9RP1Fy5ldoEQqH9L3aifcSf49IA1kxRgZb45StSe05iU7+xhYYNh8yaqqNxba9XEbWLB0/+EkazufUOnPLnGMnpYii/MbMtjt8EeBeCxrzt30B3dif6IQHuPVgGZhW0W8xE4H/Y7if6JsnfEGc/AGP/L+OyE7nNNN+/+g6ByULOJiLjKGMHEMGhZUMK4jpjvLLz+QOG14VJrEB9U1uca6w0Q3q251MjVHGpqXEh16vHANoxBu/qakxOHX6I2vgis/4RleuMT3keKpTOKLtVH2QUJxM3lWgq5GedXyF4AsqKl5Q4pYyShWtNbSsEWbiEks6Sguok6Th4YJE7XMo4+XrfQytnjbEujrFTTtarD6FOlMz/t024X83NLtFz6D/sAqNQVY9OlrqL9//OwXTZicw5VBBIA35WO2ecKnYPy1YZ5YAHsYmCYv rvrEwCmD QBBayG1rMsiqFS4tUQUQ0ImKEtQaihqMIDJOnEpV7o1FKO3lT7HXQl3/hdTqPgDNi9P1NLbB69vBLL0pQMO8vs1zugSIGV7BapS8kCPVAKqyvDnbhGIVc2CPgR2DSlxIitpeKHc53iSbI9h4tHFLx2BG+SwCPFOoD1bWD/32+qJH9L/XLf3/7pyYKY8OYw4bDtjMCbe0RJRbfEh21h0XS8ZLAXhRW2j3FrLlraAjBsylNH4576Ssxplm/8/5ABOebeT1Rhdib/PPoLUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/02/2024 08:55, Lance Yang wrote: > Hey David, > > Thanks for your suggestion! > > On Mon, Feb 26, 2024 at 4:41 PM David Hildenbrand wrote: >> > [...] >>> On Mon, Feb 26, 2024 at 12:00 PM Barry Song <21cnbao@gmail.com> wrote: >>> [...] >>>> On Mon, Feb 26, 2024 at 1:33 AM Lance Yang wrote: >>> [...] > [...] >>> +static inline bool pte_range_cont_mapped(pte_t *pte, unsigned long nr) >>> +{ >>> + pte_t pte_val; >>> + unsigned long pfn = pte_pfn(pte); >>> + for (int i = 0; i < nr; i++) { >>> + pte_val = ptep_get(pte + i); >>> + if (pte_none(pte_val) || pte_pfn(pte_val) != (pfn + i)) >>> + return false; >>> + } >>> + return true; >>> +} >> >> I dislike the "cont mapped" terminology. >> >> Maybe folio_pte_batch() does what you want? > > folio_pte_batch() is a good choice. Appreciate it! Agreed, folio_pte_batch() is likely to be widely useful for this change and others, so suggest exporting it from memory.c and reusing as is if possible. > > Best, > Lance > >> >> -- >> Cheers, >> >> David / dhildenb >>