From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7483C77B7E for ; Sat, 27 May 2023 21:52:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 432AF900004; Sat, 27 May 2023 17:52:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BA86900002; Sat, 27 May 2023 17:52:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 233BC900004; Sat, 27 May 2023 17:52:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0DD76900002 for ; Sat, 27 May 2023 17:52:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BB05F1202EC for ; Sat, 27 May 2023 21:52:27 +0000 (UTC) X-FDA: 80837384334.15.9E6B57A Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf15.hostedemail.com (Postfix) with ESMTP id D5DEEA000F for ; Sat, 27 May 2023 21:52:24 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=B9FJSy8N; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685224344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0wbENCN109xaNwDwV62gwizaYqgOfR9JxKv+tkV449k=; b=0T2SFEmfUGzdOEPu0/94HdxjgmMj/GIWujCykEG0qnXu7WCUJ+OI2wBCsy38lEtM6/rCrJ uffk2UdUi8M/hXctLyXIzDiXqEztvRJyfdu03Gmf2fzXwukgsnzeZIOpDGwGsv+JhXaxwr 5nWJDLCFN15OwNLyalyad/7rzJgH4AE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=B9FJSy8N; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685224344; a=rsa-sha256; cv=none; b=MvLK2lc4sc9fuYil8R9dymZu6OLb+hCAAmepLyDb8UAyRgnRRuZ/oeU5sUmSdApO8FRxxJ UOuDH8PXWwjuZlVSgqxTvnsErBrwH/mJ9TXB7eNlLM0H0xdjWCeLjcqbb67vLRx4WAZlew mtGRicHwHhwBz18UPbFqmHR6YCEbDgs= Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-309382efe13so1207592f8f.2 for ; Sat, 27 May 2023 14:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685224343; x=1687816343; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0wbENCN109xaNwDwV62gwizaYqgOfR9JxKv+tkV449k=; b=B9FJSy8NBudUL66TrAEA7DyenIT5ceWL2TszrRWPPl2kEdqH6ULcvuOIjk0uVAvzPC b4xFX5K0DMhs6Hbcv4gx8522Jl/VzYoog/jbZdhRNEsibreTS0NCg398mQmueN7IvnnY aSMta0zLQWY1qlOGRFWNr75f09qdtkI2AmwhDE+qgVDvXkzhNPlpQ7owQZqkxm6S7rkE Lm1O2n6vRStQjV62xQVboeYTeZfZzRyLuBVp1RfnBVqeSJ+AeKp1M8dmF7r07lM0hvMz AJF1+i8/u23aUA7lWmdVZHJeQbRwVaOKxAV5Y8a7ZAxMTX+MVNfHwCsH1vrnJUfau3X/ /pcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685224343; x=1687816343; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0wbENCN109xaNwDwV62gwizaYqgOfR9JxKv+tkV449k=; b=ECJ7wk+bOltG6dfJBNzC4565Hzi2EuE8ZTuw7oH28UJkPF1Ek1b5MI4DqHuSKueCvH LKer+OIFKdQvT4+dbCWmiSHVp5Bd5WXjD7IY6TEzmdx/JkmYzs8O7nh8T6BVsRDF6SIB Eun5QUEbivRYjDxUWDmmZrj8B9o5pDc3S7wOdcrVij1UYK6TTwh1R8Bg1uGRIHiXRkKA mte4Xc8+q8J+BYvBxeVmz/qOJptBsPpSE1P2ClPix+JZjJoI6nWuwAdpsCBua252p5dy 72kMEooX4q/ETpZu3MmIEv33Cq1S8RwP7endqZSdYwhBFmJDs35WiT7PlB6G5G3d+ZUj wAyA== X-Gm-Message-State: AC+VfDyo2Zc98QIs3yfsFEkjbA7tagcImW5Eh7F3gJTxL5h9n4Z1WtFf Rs214vgOIUokKoMF4Ae0UZ0= X-Google-Smtp-Source: ACHHUZ5R0Jz2wkoBnGgX7fzOUpEa2kj1uRx4gBScq5/ngkWFoUQ1wy1LuMD1Eq0uARjHbxlinY9joQ== X-Received: by 2002:adf:f412:0:b0:306:2d3d:a108 with SMTP id g18-20020adff412000000b003062d3da108mr4187028wro.11.1685224343156; Sat, 27 May 2023 14:52:23 -0700 (PDT) Received: from localhost (host81-154-179-160.range81-154.btcentralplus.com. [81.154.179.160]) by smtp.gmail.com with ESMTPSA id o8-20020adfcf08000000b00306c5900c10sm9219050wrj.9.2023.05.27.14.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 May 2023 14:52:22 -0700 (PDT) Date: Sat, 27 May 2023 22:52:21 +0100 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 3/9] mm: vmalloc: Move vmap_init_free_space() down in vmalloc.c Message-ID: <31872430-964b-4884-a649-55398d751459@lucifer.local> References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-4-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522110849.2921-4-urezki@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D5DEEA000F X-Stat-Signature: 91ttd5e4z3y5bm3oynofyea6bpqce781 X-HE-Tag: 1685224344-513361 X-HE-Meta: U2FsdGVkX1/rcfu7LiZRNHOP6bhhYu891qB8jgFiZynMsMvbz7jG40SzynCA1d2gpuk4R3ChTRKPee9D9yt+jOABugTQwXrzz/yO36p1b+yL9slZgK7pwDGyPe1DyhM45cpgLjYZltXbCFxE+rECSGif8w5xMSZDQJ1WKvMnh7DelXMgp9wms+8SBHAdAz4dM9dQWkY/MbYGAHOz++dvGIikZB70xYm0DeC2b27vy2gWAdxoJLiFqbfINENrJPmWboQ5pZfinLokwcy15qj1hSMNYLg7jEK1CeiiPGdZ7Or16+LFtd573NZ6zg7sNAD27bfop9Zs2pnV6X0j013SMLIa9osORUB0iSCZthtnICZLnDeUxn+yDvisD7axwzO4ycsxwSKmXSoJnZvc6uqpGa4ShgiEWdLHef6kj3FrMqqhwWlB6WpHNnB3uJxh4hjPKSEj9YviHTJKSSxwI/gryZD3pt8dzQ21Hzc242EWRGdk+YcrQ8robWoOczTxvNZiQ9pSnrp8gOa6fpAgc6LYd5qOIMVsHWxxAI/SeaLq6vFlP54oqoJI23q0s7FFKgPXNx4Fvv3RfJCns0w9XJgSaWcUS6mMZrlkRv4RzRLTmvgfqsTnBbbcvoukFjTGy9kGXwLQJC6v0hi7P90u5XmOaRNNNAsGFzgewWhMq9iZ8N8OfYrw4D3aQABPNF63jJ40TQt6L71nOLRyo4yhl4J7qK0nQkuX8SjXqYq2EEQO7DKlzhr71VcJEUJADrgb6vWqQ74bYTlzT28KWlugMw3o3dO6JTxnITZ4NvR+1ISFcBFT+G79VgJoKp7s7IUMMSmWSO5rH5Jkz5k4QLAUUr3LuMFWL9oeNA9+q9q6pryyt0udn3k8yORuYqug05kLslNTFTSLsBTZFtibCx/2YIelH8nSK8qksyom7cUKmku2razSSWLtC72jppz3Z9RHWa0EYOUQausK3tyNXc3Zlmp raxKZ6f+ EY9XYNYmpXJs0FZnB0lvIg/Gs0euDZDbiw3H6SCAIGL/h1gsZB08WznEl+w/favPD6/j0+3nzOkmJ2rnvsGIv5/5V0YVKSJVwFUrdx15DRai2JNtWwsnT7gQ52hQbUMrfM1KxjsEHkqT9uKLuhtQashOocOyQzL57JoD4bTMeM10avghwF0Ud5vsq+3NMF1x5c0L5SH4pcs2BfKn5iANsXxlGZq9RZbaXqY0ectwCaBRy3tchV13MS/T2lBf1fzsq8HO6h8L95pb5px5Wt/w49un3EwnVBO2Hr5c6lruhd+wf0+H8qEEPwWFlTV+knhYd6TrYDLdSKbUBpk9Cam8lgtiioxWONVXCS7EtAZPI3Ca4vzmLo1lu+GI2IxiJ/GN/iPPG0YGZcgCbns1yoFzam1ONj+3BD8gRgMyHOzYLGqCGE6XGtlq9pwXGQTu+Uihfv+6fqTi/bc0Ad/77u+JL+8odmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 01:08:43PM +0200, Uladzislau Rezki (Sony) wrote: > A vmap_init_free_space() is a function that setups a vmap space > and is considered as part of initialization phase. Since a main > entry which is vmalloc_init(), has been moved down in vmalloc.c > it makes sense to follow the pattern. > > There is no a functional change as a result of this patch. > > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 82 ++++++++++++++++++++++++++-------------------------- > 1 file changed, 41 insertions(+), 41 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 5f900efec6a9..19dcffb0d563 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2416,47 +2416,6 @@ void __init vm_area_register_early(struct vm_struct *vm, size_t align) > kasan_populate_early_vm_area_shadow(vm->addr, vm->size); > } > > -static void vmap_init_free_space(void) > -{ > - unsigned long vmap_start = 1; > - const unsigned long vmap_end = ULONG_MAX; > - struct vmap_area *busy, *free; > - > - /* > - * B F B B B F > - * -|-----|.....|-----|-----|-----|.....|- > - * | The KVA space | > - * |<--------------------------------->| > - */ > - list_for_each_entry(busy, &vmap_area_list, list) { > - if (busy->va_start - vmap_start > 0) { > - free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > - if (!WARN_ON_ONCE(!free)) { > - free->va_start = vmap_start; > - free->va_end = busy->va_start; > - > - insert_vmap_area_augment(free, NULL, > - &free_vmap_area_root, > - &free_vmap_area_list); > - } > - } > - > - vmap_start = busy->va_end; > - } > - > - if (vmap_end - vmap_start > 0) { > - free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > - if (!WARN_ON_ONCE(!free)) { > - free->va_start = vmap_start; > - free->va_end = vmap_end; > - > - insert_vmap_area_augment(free, NULL, > - &free_vmap_area_root, > - &free_vmap_area_list); > - } > - } > -} > - > static inline void setup_vmalloc_vm_locked(struct vm_struct *vm, > struct vmap_area *va, unsigned long flags, const void *caller) > { > @@ -4271,6 +4230,47 @@ module_init(proc_vmalloc_init); > > #endif > > +static void vmap_init_free_space(void) > +{ > + unsigned long vmap_start = 1; > + const unsigned long vmap_end = ULONG_MAX; > + struct vmap_area *busy, *free; > + > + /* > + * B F B B B F > + * -|-----|.....|-----|-----|-----|.....|- > + * | The KVA space | > + * |<--------------------------------->| > + */ > + list_for_each_entry(busy, &vmap_area_list, list) { > + if (busy->va_start - vmap_start > 0) { > + free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > + if (!WARN_ON_ONCE(!free)) { > + free->va_start = vmap_start; > + free->va_end = busy->va_start; > + > + insert_vmap_area_augment(free, NULL, > + &free_vmap_area_root, > + &free_vmap_area_list); > + } > + } > + > + vmap_start = busy->va_end; > + } > + > + if (vmap_end - vmap_start > 0) { > + free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > + if (!WARN_ON_ONCE(!free)) { > + free->va_start = vmap_start; > + free->va_end = vmap_end; > + > + insert_vmap_area_augment(free, NULL, > + &free_vmap_area_root, > + &free_vmap_area_list); > + } > + } > +} > + > void __init vmalloc_init(void) > { > struct vmap_area *va; > -- > 2.30.2 > LGTM, Reviewed-by: Lorenzo Stoakes