From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Muchun Song <muchun.song@linux.dev>, Peter Xu <peterx@redhat.com>,
Gavin Guo <gavinguo@igalia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/5] mm,hugetlb: rename anon_rmap to new_anon_folio and make it boolean
Date: Fri, 4 Jul 2025 12:46:51 +0200 [thread overview]
Message-ID: <3184cd54-416b-4456-aeff-0d8165beffac@redhat.com> (raw)
In-Reply-To: <20250630144212.156938-4-osalvador@suse.de>
On 30.06.25 16:42, Oscar Salvador wrote:
> anon_rmap is used to determine whether the new allocated folio is
> anonymous. Rename it to something more meaningul like new_anon_folio and
> make it boolean, as we use it like that.
>
> While we are at it, drop 'new_pagecache_folio' as 'new_anon_folio' is
> enough to check whether we need to restore the consumed reservation.
>
> Link: https://lkml.kernel.org/r/20250627102904.107202-4-osalvador@suse.de
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Gavin Guo <gavinguo@igalia.com>
> Cc: Muchun Song <muchun.song@linux.dev>
> Cc: Peter Xu <peterx@redhat.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
BTW, these SOB are wrong :)
> ---
Nothing jumped at me, but it's all very complicated stuff
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-07-04 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 14:42 [PATCH v4 0/5] Misc rework on hugetlb faulting path Oscar Salvador
2025-06-30 14:42 ` [PATCH v4 1/5] mm,hugetlb: change mechanism to detect a COW on private mapping Oscar Salvador
2025-06-30 14:42 ` [PATCH v4 2/5] mm,hugetlb: sort out folio locking in the faulting path Oscar Salvador
2025-07-04 10:45 ` David Hildenbrand
2025-06-30 14:42 ` [PATCH v4 3/5] mm,hugetlb: rename anon_rmap to new_anon_folio and make it boolean Oscar Salvador
2025-07-04 10:46 ` David Hildenbrand [this message]
2025-06-30 14:42 ` [PATCH v4 4/5] mm,hugetlb: drop obsolete comment about non-present pte and second faults Oscar Salvador
2025-07-04 10:47 ` David Hildenbrand
2025-06-30 14:42 ` [PATCH v4 5/5] mm,hugetlb: drop unlikelys from hugetlb_fault Oscar Salvador
2025-07-04 10:47 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3184cd54-416b-4456-aeff-0d8165beffac@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gavinguo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox