From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB0FC61DA4 for ; Wed, 15 Feb 2023 01:04:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D27D6B0072; Tue, 14 Feb 2023 20:04:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 883206B0073; Tue, 14 Feb 2023 20:04:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7718F6B0074; Tue, 14 Feb 2023 20:04:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 695686B0072 for ; Tue, 14 Feb 2023 20:04:12 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3D744120840 for ; Wed, 15 Feb 2023 01:04:12 +0000 (UTC) X-FDA: 80467729944.29.83DDB24 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf19.hostedemail.com (Postfix) with ESMTP id 5D2BA1A0013 for ; Wed, 15 Feb 2023 01:04:08 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676423050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h8i8dll94h99L4Sav1hxrYIcimuVo9KK5Xd5dBsaBXU=; b=gSiplgRiRKfe45yla1azC21BHJ+15B0s25cyw+vLesLU970nHVTmjKe24YgUKJhd1fcTcD rzDYduQ5ddpFIFvqIlDc15hZvu4XmfreZxLWgkl4/qJHNcc7qiO0HBjw6eabBKT1UQ+nVG VXQMFdHyRJmsSuzv4A3gl84URRJlJZM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676423050; a=rsa-sha256; cv=none; b=iTMD4VBckDgakAOFPj2LjuG4CQmyiOi2+H9nEGvbIK/3k47jlFHiLx64kC9i5Nb3evtZhW ySFwDkY7BQk+JpEX6VtsmKGVNTIPGcUXVaYfObqfKCOn2FuVcy1DjMjvN686H3vlnIGr4T JXE3ACevsfkfGTCFoiujWKEqMQf07fo= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R241e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0VbhhtKI_1676423044; Received: from 30.97.48.50(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VbhhtKI_1676423044) by smtp.aliyun-inc.com; Wed, 15 Feb 2023 09:04:05 +0800 Message-ID: <3180bded-7beb-c994-7f13-2d75eeb82516@linux.alibaba.com> Date: Wed, 15 Feb 2023 09:04:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 2/4] mm: change to return bool for isolate_lru_page() To: SeongJae Park Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, willy@infradead.org, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230214193204.72057-1-sj@kernel.org> From: Baolin Wang In-Reply-To: <20230214193204.72057-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5D2BA1A0013 X-Stat-Signature: kyj74qgi4d867zspyxaddt6ntec34478 X-HE-Tag: 1676423048-407250 X-HE-Meta: U2FsdGVkX18m/7k9VjL48uVKpjiga5734jo7jRb+yaezdWLCPEjIPN6+YrmxZTaLIKkVgSfNDIThhGo3iWCmtkD7K3eqUVGV2zJB/GLgul5UD8pjXACJwwaZ367TqKXi+mI1VoeXwPrQz42uLM3efcHVTzFaEAt8WT3WxzW9JeKONTn+dG/6ZJeKGcV7vOWWI37wL7w9A1ywZHc89NPK0K6I5TnZ6SwYa4AAmsBsk87XSxEXh5h+n5dxVL1ltAUdComud2HIduSPZFXxamqRbZV8DaAaVctmAGm+hiNkYGBmgllZU3kaGYDIk7q176ZiLxDceyVcIe3i89tXT+xFzqXqeMZrRVUCihxrFjJhTsaTXn4XihSzm8q/8fulYV6dwdjBCalJUlINDBAkbvbNWw5Ix7FatwVtsDiQ8vdtBbzTJBQ6/Bc88BIq2mD2pa+FrIc39DyHWzCiR8Ag+njbuvf7Gb7+G1RCqVWL2z0QjSUzeIcpglJ1pON5MQsG/tXMFpXWlP6nS1s7ZpnH7B9rSqumLAsyLWUfwtpzgcLShYWI7KrJ7nb/IpmfLyRhHHuBpXzhX+nzAkW4lUANrictdNS9+gNx325QNx2W+vVEUu5UWTvy+xw6u4FdKsK0dCKDACxnLZyT10BSqFYFKiGXwPMGIpsVes1afY2i6ahGSgGC+93U9irlTP3Fexur2dLkxA/mOsQVNYLyACJn5mDQn7EvZ2qDXu5/hUPZSBtSADb6z6Y3mO/URXil4yJUr4LG4uH5Tlb8kmaf9awRtazKyv16sWyBcT2wWgS3ZiNhB4IS/FN+MstZRcWMR1V7mwzliMAGpOShP+Wx5xEMix4l269/PjPtaDp7rxTRdDjfhqeRZ+v08bnWdEizgIw9PoKs/Ltw7fWEgfCdHQcb94kwsvDE9wIinG+uBOBDq1jlyXYTz7PsI7SzQgs0PqH4jyZLXVcDfX9hzQKHEZYE41W FIaRnNsS WafgAWM1pA5MtgIHYCAE+Ksdz6Khvh9ZtUJZjEWn292PelG+onUlXGprB6eTZJJkWF/X043dNOiN7tADbuY9sAhNIAjJzotulnKmMNDI4n06RBHNFRVngNBd0rR1293CLxbeNB6E55JZrSpCF1XqVojmZqM7YGnSfMdDQFI/FIeNP7kjtLLSK2X0v8VMxmJkSHC7J7KIM9ayaa0yTVcGG+4salEdJjWcZjFg8BHPNRv4oxfKlYvVPkJX24XFo89uSc74zvujGzdpqWkw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/15/2023 3:32 AM, SeongJae Park wrote: > On Tue, 14 Feb 2023 21:59:30 +0800 Baolin Wang wrote: > >> The isolate_lru_page() can only return 0 or -EBUSY, and most users did >> not care about the negative error of isolate_lru_page(), except one user >> in add_page_for_migration(). So we can convert the isolate_lru_page() to >> return a boolean value, which can help to make the code more clear when >> checking the return value of isolate_lru_page(). >> >> Also convert all users' logic of checking the isolation state. >> >> No functional changes intended. >> >> Signed-off-by: Baolin Wang >> --- >> mm/folio-compat.c | 12 +++--------- >> mm/internal.h | 2 +- >> mm/khugepaged.c | 2 +- >> mm/memcontrol.c | 4 ++-- >> mm/memory-failure.c | 4 ++-- >> mm/memory_hotplug.c | 2 +- >> mm/migrate.c | 9 ++++++--- >> mm/migrate_device.c | 2 +- >> 8 files changed, 17 insertions(+), 20 deletions(-) >> > [...] >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index a1e8c3e9ab08..17ed80707518 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1668,7 +1668,7 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >> * LRU and non-lru movable pages. >> */ >> if (PageLRU(page)) >> - ret = isolate_lru_page(page); >> + ret = !isolate_lru_page(page); > > This may change return value of this function. That is, this function will > return 1 instead of -EBUSY after this change. It's not a real issue as no > caller of this function takes care of the return value, though. Yes, I've also thought about this. OK, I can keep the original logic here by adding a new variable. Thanks. isolated = isolate_lru_page(page); ret = isolated ? 0 : -EBUSY;