From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F5DC001B0 for ; Tue, 15 Aug 2023 12:27:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70036940009; Tue, 15 Aug 2023 08:27:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A998D0001; Tue, 15 Aug 2023 08:27:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 550B3940009; Tue, 15 Aug 2023 08:27:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3FB168D0001 for ; Tue, 15 Aug 2023 08:27:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 110991A01F3 for ; Tue, 15 Aug 2023 12:27:49 +0000 (UTC) X-FDA: 81126265458.12.18DDCB1 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf07.hostedemail.com (Postfix) with ESMTP id 1D2B240016 for ; Tue, 15 Aug 2023 12:27:46 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=EEZlIEkk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692102467; a=rsa-sha256; cv=none; b=LzDcrOhQ0l8tnk6m1+RnJeL9Fqy52L4KgSJKrhwQH1RE7sYqlkF8oq1uyBSpeuyaSbdkeK geGnJD3iAKN4h2VXZ+oqkFdEdODkR+rNK5qEIUO7GAddeP+YloWYiU/4hO0+FCPZKBzvam rYh9VbCuaYEpm0f2imoM1pWhyIpR04k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=EEZlIEkk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692102467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hVDDJlWhUCzNd5EzhLvuiUskyN3c3RfjOPmwxNMLBoQ=; b=LEA2/Nqde1rZh/79LHk6ww1ljpIMfsp5xLNj8d4DxYvmH4X05EiQ3+uIw8a3v0YplxeHuS SI+4sQyzizaWarbHRinJL+8fXrqSe8jpDgsbFZFU/9X2p1L62w0EE+OwJfP9aCINT3Wj0z E9JR7GGHptV0hF1N0Pb11lJaA1TE7Go= Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-4fe28f92d8eso8406318e87.1 for ; Tue, 15 Aug 2023 05:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692102465; x=1692707265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hVDDJlWhUCzNd5EzhLvuiUskyN3c3RfjOPmwxNMLBoQ=; b=EEZlIEkkHTSZjflV063Ba+ihFccGT6E0fQZnAkTbH4cnvs7XalS74aKS7J5Fc8+jy3 Oy/MfMANIuQMzgazpi58Y3jE8tq0X09EBdzUWMyUOwohCs5EGMEs6U1ED+1r0JNblfWa 0aYGsV2mQrrlUzWecnayklYKdyV8f92jZZqaI68H210pfWqivG71RoqDhm/igoXmWFUv 5/SsEB//8i94HjEdft7lAhrKAoMbRNyyZ4Ik8YtZP3FO52wWv4WXMX19imxwSfwwGCos KmuZDIwsXS8uyet7Ix9BsO+uu0OuwaVgfO0uWOCgGpWsJ/XFdAx1WvxnP/ncpnAembpb bLYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692102465; x=1692707265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hVDDJlWhUCzNd5EzhLvuiUskyN3c3RfjOPmwxNMLBoQ=; b=Q4A9pC3cL2xgSJUcNFaAjH+vEP2yAvw6fD6VOP8ICJ2LKnOGAJg0S+zIP/vlyXDonv WDodztqdFzKN4xgSGm+UD6IF2D0r0y/0rNzAgC3tSo01FgrF0/3daeS2588qItzv1P66 nod70cstVZZOUBGOLbu9zbepUTXYaKYUpjEl3PbjeG42rKeZEx4icluA5v919rLBgLlm vypQR4raXJnJO0WBxb7/Mgfi+D6NFcllT1grYRYURW1YeeXEkN4Tj/duWMzrd8HX+Cag Lahf0KyxSw0SYCFnrMuyVZ7VKx1DFm9FhKGXnyvFu1sq1VLKSQ9+nVRGG0ii4W+W4RL7 b6+A== X-Gm-Message-State: AOJu0YzthQGYyiuZOcnR8DnVbSAzcz6+rCOiXBwMFO6Vul8k4ZQaaRiv GRkJscKQSTImwSgjE/gunHo= X-Google-Smtp-Source: AGHT+IG+cwmqQnGcgtQ0KiswsiQhrqD1uMPt1W4S48i/yx2yACHzwUMti+3UczLKtLgnuthlvtm6SA== X-Received: by 2002:a05:6512:acf:b0:4fe:5860:7abf with SMTP id n15-20020a0565120acf00b004fe58607abfmr9520807lfu.13.1692102464921; Tue, 15 Aug 2023 05:27:44 -0700 (PDT) Received: from suse.localnet (host-87-6-98-229.retail.telecomitalia.it. [87.6.98.229]) by smtp.gmail.com with ESMTPSA id g13-20020a5d698d000000b003180027d67asm17774055wru.19.2023.08.15.05.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 05:27:44 -0700 (PDT) From: "Fabio M. De Francesco" To: Linus Walleij Cc: Jonathan Corbet , Jonathan Cameron , Mike Rapoport , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Ira Weiny , Matthew Wilcox , Randy Dunlap Subject: Re: [PATCH v2] Documentation/page_tables: Add info about MMU/TLB and Page Faults Date: Tue, 15 Aug 2023 14:27:42 +0200 Message-ID: <3179607.5fSG56mABF@suse> In-Reply-To: References: <20230813182552.31792-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1D2B240016 X-Stat-Signature: ck8kj6z1kzojgb9qnyohew8y41nd8wgw X-HE-Tag: 1692102466-564455 X-HE-Meta: U2FsdGVkX18fLQ3mf59T9WDb3/k1SIxBKwb2CuKB5Vlqdy43mELglp98bGFiVOEnZoiDK1UBGlt6CORAusbEiRdZUiDMuoOD4k5kGlTS4tPT6+vQmcIp58DhhLKbCxLij5Uritob/tIR2bXtmDFKzvzZKc9+5PoTuo9toRXC55EJ0wjaMMHq/0NkRxBEpX+she5hrX9wnXg2GEso6VODow8gk+IWwuhE6StkqwXuPyh8Z8/6rANmWp3umoovqh5iytK6tYCEdCAwFssf179i8EQDiRD31RSjlauhOsjJh40WBc26FZARmQZokjGqxC6QmBn36/g2rLy6qX08vwAus3gSgA3qOKMwW3IUqxlxbew4CayLo1FHh80ICX3upd0P6xAs2r3b7vhnRaRwQWICDQbUnQEz9xJMDIT0PeEBqnlhdvaAhN8h2tn6p7u3+JRdHU1DolGGyehK3lFTup6A+i8KsO3CNzB5vI4zXCgyf7NEfT41RGVyXPAAT/hDwgLCWes0GNU41uM1Go1yfu0qCRQ/WX6ovMzBm0OOBS9Tq+IhtVjeFtz96Tu9NZvtN5V85AySnvAPDGXULHjVfYMAym13tt/d6FzpD52TqNhnL0TQlBcOLMsAKOu+BLDfk+vscufkIUmOKDDJTC0UmnPtCfw7fYYNq2O2F9A6Fjasd1KEi6FWV+vcNGH5wH1aNn5vHKamlFJo02xT4qy3JPw0fQhmvPTAv8IEcbxawWSZp76gF7hiaW6vXs2f4wGCd9UEAn69uoEVb47ipN2BfWWLQ4GI9BsVbZi8m5mi4S2181LmKh4m6vf5B5IKpKiDwoc6tBe9/PJvv7VcSBwvWlccAwhwpZZXDFh7kenAWUc98CHUrO92MyW9+faB3CflFzcYhmt/UO7m2lmCiecNeun575d7WZSRymQPF9sm9dbI6Qlgo0sJ4l3iHFsmETnJ9cPFj/OKpB+clQVxJ+a7pKH W1iMbdgS 8bF4lSU2CAj09K7jvYIimJ7MHmvNCDPyMbgk2ux2OvUw8irGsmTfOerhrbsVfvOHLf0jXTIGKpYWKl4WOlIXCHUi5vo0rIq77o1E0Xq1Qxt9jmaSBOq3iYg15zxHlJ0mg4hryxW9DRCM+1GykKov1OL2P5WcQza/Mbrc30giGLvKsp33v/K7oe8qjoe5xoy+RW8Y80SR3QBhXKUmhml+87fLp6I604uY8gVz2ES5smLFmqL/y6xAemko4VkPiaxJYlCYMG1/WbOI74uQmF7uhjLbc2k+EtV7Jehu6nMJZXxAUITnddqI2j39ZlJsOC4N99SUGn0JIxiNYY6ThVFvQdG/+/oOMW+2doP39N74MmwfE0MNBZ4l31phAqNN/wZ7yCdqPQfsRFRygPrJvpl61aAHoBUH3MejRJvBRfl5vdrJ7Mv4kD+8L6MVZzhw6f0pyvtde+4y9UhpAxzMG4TjHHPhjY1hKxYkmax27dOJPDFd004VR2da2wNX8n6A9RKVkLWz/RcyU5hRuIFlUH7d85a9coA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On marted=EC 15 agosto 2023 10:51:24 CEST Linus Walleij wrote: > Hi Fabio, >=20 > overall this v2 looks good! Hi Linus, Thanks for your review. I appreciated it. I'm counting at least ten mistakes. Well my poor English should still impro= ve=20 in order to work on documentation. I agree with you on all changes you are proposing, so I won't agree line by= =20 line. Instead I'll send a v3 and forward your tag.=20 I have only a doubt and a questions.=20 I'll jump directly to the relevant parts. >=20 > The below are my grammar and spelling nitpicks. > > [snip]=20 >=20 > > +If the above-mentioned conditions happen in user-space, the kernel sen= ds=20 a > > +`Segmentation Fault` (SIGSEGV) signal to the current thread. That sign= al > > usually +causes the termination of the thread and of the process it=20 belongs > > to. + > > +Instead, there are also common and expected other causes of page fault= s. > > These > The word you are looking for is "Additionally" right? >=20 > "Additionally, there are..." I was only able to use "Instead" to express that, contrary to the former=20 conditions that is unexpected and uncommon, there are other expected and=20 common causes of page faults. I thought that "Instead" stresses that the=20 latter causes carry with them opposite and wanted consequences. I think of "additionally" as a means to introduce less important and less=20 frequently occurring conditions. Nevertheless, I'll change it to "Additionally" as you are asking for. Everything that follows from here onward should surely be changed as you ar= e=20 suggesting. =20 [snip] > > +Swapping can't work for memory mapped by kernel logical addresses. The= se > > are a > "kernel logical addresses" -> "kernel-internal logical addresses" My only question is about why you prefer "kernel-internal" to a straight=20 "kernel". Can you please say more about this? [snip] =20 > With > or without the above suggestions: I'll do the v3 _with_ the above suggestions. > Reviewed-by: Linus Walleij >=20 > Yours, > Linus Walleij Again thanks, =46abio