From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6ECC25B76 for ; Wed, 5 Jun 2024 19:07:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5232C6B007B; Wed, 5 Jun 2024 15:07:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D32B6B0082; Wed, 5 Jun 2024 15:07:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39A6D6B0083; Wed, 5 Jun 2024 15:07:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1BD0A6B007B for ; Wed, 5 Jun 2024 15:07:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 986D41C1E45 for ; Wed, 5 Jun 2024 19:07:39 +0000 (UTC) X-FDA: 82197769038.14.BCEB4E9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id A8F58A0029 for ; Wed, 5 Jun 2024 19:07:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F90hb6rs; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of "SRS0=PUG/=NH=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=PUG/=NH=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717614457; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q6ktBRSiqw5XpBmyz965oHScuvKmkeen3Wstrg+hHy8=; b=UOeNkJa2QshpHoVCoFQxBFxRZ3ca9K06PK51je0d+8ufPxLC73gT4wDFq4y4yaVFfKpALo UfVruYKQlSSqHhhcpHRFE8Ae/gf1DZ5ujV1ziJQGPu042Ks0922nE0GWrhIAeo8Vj1GVxF dd+cxHJgJaxFb6I5cYP7838PL560gHU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F90hb6rs; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of "SRS0=PUG/=NH=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=PUG/=NH=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717614457; a=rsa-sha256; cv=none; b=xHV6RndxtoIySccvMLeOA7HA33Wozs7mQrCIMYJpQmPexyRU3e3fJXhSs/xhWeLeGcIDvK w/fgwmxDjEdAJl5Z+Tw0UlmqJTHlBkV4vFyrm7npGVUPPgvcpArRgGayUb9ZONJDdBhK6p kHFwI+CSxRX5xKMbt0Uq3hu4qhglBLM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9C1B561826; Wed, 5 Jun 2024 19:07:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D1AEC2BD11; Wed, 5 Jun 2024 19:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717614456; bh=gCo6Eol2ctS05tCdqJWNTMs2vsC5Ydi8gXHw/eab5mA=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=F90hb6rsLvHfMl50YI96RcTTLZ80o5uiqOYZadcf4fxJZBJqmKTAPRMHIDn9s8I77 P0eg+ovQGCChXpNa7Jqp+Q5P+pIXv2rpOshQIJf8EaM/8Yqth2DUaAk6Zd0RkLLd9J oD2Dg1liJvxHodYYCGmhra//Tu8KxhTAsvgIcAekLlB7F+/1qlgFLB6YYVetqA2/Ql jYVmrZwRAlO//NLmClf5+SyUl6F/sD+7tUORrNzkaYZz06eW9nXn6jGO3eYAzmR8Q7 ppHE4FMy/rbB2kyRwZ0CWB4F9xWg7ev70NsHcVCSwa/g6daUzGH56FA5GXWUzx76VO 0x0twe2Asyq1Q== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id E5BC2CE0A73; Wed, 5 Jun 2024 12:07:35 -0700 (PDT) Date: Wed, 5 Jun 2024 12:07:35 -0700 From: "Paul E. McKenney" To: Naresh Kamboju Cc: open list , linux-mm , lkft-triage@lists.linaro.org, Andrew Morton , Mike Rapoport , jbeulich@suse.com, Dan Carpenter , Arnd Bergmann Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead Message-ID: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop> Reply-To: paulmck@kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A8F58A0029 X-Stat-Signature: 8sjgdj9znpebqxopaownacx9o3arbpup X-HE-Tag: 1717614457-520750 X-HE-Meta: U2FsdGVkX18eKhREjeC/lP8wzeAdMmyG200JdekJ6urhHE+7cDpmtiQbmGoO9uBii+e/E/UwEHXw81+VLQ9bhcddxd4lkpjJDrHKRaQc0GrDtV3AfK/YYtdCWfju4zZaFuEIlf8EoAuw1R7VGGauaiy4VLyLHN12Q6tWzKKJbn+t3S6T1dAPW1er9RUQ/xl2bCTSnPOuwDpljeCWfyqgSl5hyA9KV22y5f3jkGH8gKSl6Pu/N7TR+8iMywBYtZCTehnsUAnatfCp7Wy8F+cXIkAPzpSyzvvYzZnqx0Gy9PNlMw6dd4EcHo6MALwYCV3/Mhwj7pSaZkbhAJ/9JwOR7Bsn3O3lld/iEIbTmafPUSZo7Yo1YER9Gk2YxQKiULe6/jsIATR15cOrS0DBOdZPwqw+dJ0uZGF/bLoINZ5SggbM7fZFrEF3+qQcWIeuRvTg95up8WBDXuyIepZ3F809fH9TUz32L/VI2wsnFp5EEoRx7787/wR2g/MwEjF9mlnb29cH5d9pfnNLQa1snqvdTS9hKIeTtPspaBn3pZka2LtgVQ4esuMRYYNpGKa/hJA5KKZgY0E1XEd/dV58q91Hqi1Zqnbf9Vqd8kqLAaxOjd3BXz8przqGySfyDHoTxPfBv2Up4CZWSlqxVfnye7UAmx1yPMqqmd3pcWnPH/KT67678079xkc78vqt5eiy9K6ZDAH7Eab9k7qE8rFEl1c2FSVRfllZUh/B7IDeUhZpPl684UeS/pcjM2Y29CzSm2UMlnhU5y/v/VESrbo2mhTB/mhoxI3X3MeVu/Sy6biK0YzFWKDszsR7bpL5YZymozuChIT8kBswmpYVA0IA07BFmoyVvQFb0ChbzhrixpHSdQvPEWaVKPvbjk/GeJAhKagtraVu+m95ALY/KO5UF+BmC+WPAyS7CEIm9Ow7IDufw3Bd4mFgGLJwexVO9TDpAG57hZKgC52HNNWA4+wzOcY 7NvVTQOT fDqtA6jCYOQJhQEF1UatkzYd46DSTfPsv5VYjW+L/wmne9pyQ5dZRlDPYIiRq9NPOj2nsVpQTi5UVxQJNEd3D7/feUpgExZSUIy7qUK3JN8Lvrr0CyRHxmNThWYUkwVn3RGQpfoH2iz6JvzQJq8VNIvdLUUv3J8xTal1Gv+IW80A/8tc/kghuwBV9o5zxT3HBkbCcjEgxc3C67HlVgqr1+8WeFt+pQ/jLgBZ29pDaFiL1M6CGwcl+8HDrmK9sob+5DIAcc5bontiOfBIL4/ZKmRy5wxLSEmtdX1+o05cb7tuOu3G8hJwBCkiqJ8t3XZ5Fvo6MVNBci32EpVzlC8hJ6u5G3odu2CeDjY99Bcg0apOQbrnq0u0quqNJIjYnaw9T7ML/xNdZGn+CIexiVNxg1GpwKGJ0SHQ5TTP0dEQHfUS9+ZF1teVxGZWePVXrreN6oC3GxV0LEgvXp1I8IN+I9ngL/w67r9E2nglynAu/p9alRGVCnWKt/EvaVBzwUWk0y06fNsAFiE7wGCOi+vFUIVJGR6aIY64qbCX64n/l4irlS1Ql36nePu2H+cGtmefiTyxwrmDOWPbeG45LMTdJ/8jEw44XI0MKCWe5h0BpjtfARIzpGx3OFYs4GdXM6SRt0bD243mHDv/D+wBJ4kGFik9TySF1/k4yGWENrW0vp8iRf2A+NxKbGc8InoFO6qmOBkPyLXVkACIIc/ImzxRUeoPiQ/BUMBiUAYFd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote: > The following kernel warnings are noticed on x86 devices while booting > the Linux next-20240603 tag and looks like it is expected to warn users to > use NUMA_NO_NODE instead. > > Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead > > The following config is enabled > CONFIG_NUMA=y I am seeing this as well. Is the following commit premature? e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES") Maybe old ACPI tables and device trees need to catch up? Left to myself, I would simply remove the WARN_ON_ONCE() from the above commit, but I would guess that there is a better way. Thanx, Paul > Boot log: > -------- > [ 0.008547] ------------[ cut here ]------------ > [ 0.008547] Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead > [ 0.008553] WARNING: CPU: 0 PID: 0 at mm/memblock.c:1339 > memblock_set_node+0xed/0x100 > [ 0.008559] Modules linked in: > [ 0.008561] CPU: 0 PID: 0 Comm: swapper Not tainted > 6.10.0-rc1-next-20240603 #1 > [ 0.008563] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS > 2.7 12/07/2021 > [ 0.008564] RIP: 0010:memblock_set_node+0xed/0x100 > [ 0.008567] Code: ea ea ff 00 74 0b 41 bc ff ff ff ff e9 6c ff ff > ff 48 89 75 d0 c6 05 5e ea ea ff 01 90 48 c7 c7 c8 e1 c7 a0 e8 d4 36 > df fd 90 <0f> 0b 90 90 48 8b 75 d0 eb d2 e8 74 bb f3 fe 0f 1f 40 00 90 > 90 90 > [ 0.008568] RSP: 0000:ffffffffa1003de0 EFLAGS: 00010086 ORIG_RAX: > 0000000000000000 > [ 0.008570] RAX: 0000000000000000 RBX: ffffffffa149b510 RCX: 0000000000000000 > [ 0.008572] RDX: 0000000000000000 RSI: 00000000ffffdfff RDI: 00000000ffffdfff > [ 0.008572] RBP: ffffffffa1003e10 R08: 00000000ffffdfff R09: ffffffffa1003b90 > [ 0.008573] R10: 0000000000000001 R11: ffffffffa1079440 R12: 0000000000000040 > [ 0.008574] R13: 0000000000000000 R14: 000000008ad25c18 R15: 0000000000014770 > [ 0.008575] FS: 0000000000000000(0000) GS:ffffffffa135e000(0000) > knlGS:0000000000000000 > [ 0.008577] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 0.008578] CR2: ffff9ac23fe01000 CR3: 00000003ff246000 CR4: 00000000000200f0 > [ 0.008579] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 0.008579] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 0.008580] Call Trace: > [ 0.008581] > [ 0.008582] ? show_regs+0x68/0x80 > [ 0.008586] ? __warn+0x91/0x140 > [ 0.008589] ? memblock_set_node+0xed/0x100 > [ 0.008591] ? report_bug+0x175/0x1a0 > [ 0.008594] ? fixup_exception+0x2b/0x2f0 > [ 0.008597] ? early_fixup_exception+0xb3/0xd0 > [ 0.008600] ? do_early_exception+0x1f/0x60 > [ 0.008603] ? early_idt_handler_common+0x2f/0x40 > [ 0.008606] ? memblock_set_node+0xed/0x100 > [ 0.008609] ? __pfx_x86_acpi_numa_init+0x10/0x10 > [ 0.008612] numa_init+0x8b/0x610 > [ 0.008615] ? topo_register_apic+0x3a/0x130 > [ 0.008617] x86_numa_init+0x23/0x70 > [ 0.008620] initmem_init+0x12/0x20 > [ 0.008622] setup_arch+0x8a3/0xd60 > [ 0.008624] ? _printk+0x64/0x80 > [ 0.008628] start_kernel+0x76/0x810 > [ 0.008630] x86_64_start_reservations+0x1c/0x30 > [ 0.008632] x86_64_start_kernel+0xca/0xe0 > [ 0.008634] common_startup_64+0x12c/0x138 > [ 0.008637] > [ 0.008638] ---[ end trace 0000000000000000 ]--- > > metadata: > git_ref: master > git_describe: next-20240603 > git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next > > Links: > - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20240603/testrun/24170391/suite/log-parser-boot/tests/ > - https://tuxapi.tuxsuite.com/v1/groups/linaro/projects/lkft/tests/2hM1TaqYoxFAhzHCIRxz84OeUaj > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2hM1QI6QEe9bjg1sQrFs41ZSYmk > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2hM1QI6QEe9bjg1sQrFs41ZSYmk/config > > -- > Linaro LKFT > https://lkft.linaro.org