From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0CECFC288 for ; Tue, 15 Oct 2024 10:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A0BE6B0089; Tue, 15 Oct 2024 06:55:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 729E26B008A; Tue, 15 Oct 2024 06:55:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CA336B008C; Tue, 15 Oct 2024 06:55:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3B94F6B0089 for ; Tue, 15 Oct 2024 06:55:35 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D245C120EBC for ; Tue, 15 Oct 2024 10:55:26 +0000 (UTC) X-FDA: 82675530336.19.395EDDE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id A260E40020 for ; Tue, 15 Oct 2024 10:55:22 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728989627; a=rsa-sha256; cv=none; b=TYJccRl2hZxX9iohNMTNbOkVdfIsI0wPX8yCC8YmCsWw3JjGpkWnUTQD1ibuHUvuJTqBZq o2rFaLxA16yrIWft2hSYo4WMzzHQ4Ah2Dmdm3Q1BMwSu47gdqiac7vKAXCvVwpUCzJZSTM weICgoYpLWbeBFM82q9m6IlU+D01JMA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728989627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nwcOcLZwb7WFzyCEWIauRx9iuG6IhrcNwT+iRaz3qA4=; b=iXgKz/MHVGG7s/TseBLpcn0g609I3IzbhwQoaIQB3Tt8KFnOk3xVJZ9oVX0Q8ySDkEOzI9 n0HJsFRQkkmfG1hhiX5ByxHRpFkw7O9IJYRsiO/M1sIGxtBCI7BLpqTHaIgOsPoX+J2RK9 WmfJcf58pkd0c6R++lW3Cz0+vYtNER4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E91261007; Tue, 15 Oct 2024 03:56:01 -0700 (PDT) Received: from [10.57.86.207] (unknown [10.57.86.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D9CC3F51B; Tue, 15 Oct 2024 03:55:28 -0700 (PDT) Message-ID: <315d4258-ea96-4008-8781-9205f41cec6c@arm.com> Date: Tue, 15 Oct 2024 11:55:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 03/57] mm/memcontrol: Fix seq_buf size to save memory when PAGE_SIZE is large Content-Language: en-GB To: Shakeel Butt Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Johannes Weiner , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Michal Hocko , Miroslav Benes , Roman Gushchin , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-3-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A260E40020 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6gbta9bogfnt3hab9yjmm6gnqxc6x11s X-HE-Tag: 1728989722-880070 X-HE-Meta: U2FsdGVkX1+Xw0GgfQfDWQo29QzCtw2UWlR/Dg86U5k67aLtddx67vHPmk25Pl3YwzUdJ8IeQXCziYhScaPKflCFzJHWkQ0+dZp+22wDEWAeyKmQgD/TD/toeiB4PWIkWzczcsEQSnrts3YmKccVX7S1s30lSi6huL7NmVBBmHE5dUuPFmJSc0mpLl0k748SwmH/aarSr/42zTVhm3Q5cxBAGfIKIaRmw/wGB4BjWIZq17jIrBI3uoQqSEm0ZLq04YL012k0FRvUav8tNh9sI/qkftBVwTjMpIJZATE4stVHnNcXqto6LudJhtcINFeimVq4ZI/JXCUxETL/RqHE6UajdTyaGUDJLD6ITNWAvtfmoCDDLa1mLMBGsXGkbPWJgmNfR5/+CZC8X+XJZsVO93z/2HHodaaUPvGBOMdr9eBVL++ad24HWvpWIjI87Q3t5Fnv5iy/rGOhGMELDRbM59shKGMMRCOo5QJvhE5u4ZzIUWx0saJCu8WqPbLxc+dLbE5TqERIMhdxM8HZ58WT/vjA0eBea/zqnUKGocmQCQJhu6sbjbC3K11TLH6EdFcjRE6CKfA2yxqwo1tJoCnlYXBSJHJPOg5Qoq0U/PB7Cv6d/j+pwnmuZOUWG67ckcTruYJa8AhDAuN9Z8vxZLtM/rkbhxQ2p6AkwtRB6UUwdHK0IM3eJmmv2yGcOqMgGFQ3qm2n8wPmQy9BsCcwGvicnS8+s58HvJqA7WmEaJHCKt15lnZ3bz9xysWJwNCDg+GVAG4+mYJZd3lhF0IUq1nM4to/zGOTm4w47xrQkJrENULcfcGm+YQsbNIsLEYsAUYmiiWXAl9JOpaz6gH8t/r8jpHF5cs+TZDWA2uhSb8Xuqrx91Hoy3hM1Npb8gRrYFqx3k3Jw+xCvolmURWbIx8k7di+dC7OumGc3WiwyL4O8VbsFrz4Cp85jdMt342K8dQHoxhs+COeNN4DX30CZKj Hix0/SIZ JFzEImG9I/CjDKnDsEMbRT6H0yXGU86SKixsN0PqKiIaj8O7Da9KGFTqhNkgTih0cqBddmG/Xka3fTWR8zEERS9Wu8HEphxI9egVcQLhXnrYcImtB9HbbkdKDpxnZpRWGOjpETXuFknctOZW2zpjwVvdnu/uPGA5oe6Hxs5wNS0+oLgXNCZ+2HEFBaW/ro/9KLlqyQN/39L9FkMorGVb+mjLtTyWaDfwGm9mxivrDJljzwCpupbMVChI8KA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14/10/2024 20:59, Shakeel Butt wrote: > On Mon, Oct 14, 2024 at 11:58:10AM GMT, Ryan Roberts wrote: >> Previously the seq_buf used for accumulating the memory.stat output was >> sized at PAGE_SIZE. But the amount of output is invariant to PAGE_SIZE; >> If 4K is enough on a 4K page system, then it should also be enough on a >> 64K page system, so we can save 60K om the static buffer used in >> mem_cgroup_print_oom_meminfo(). Let's make it so. >> >> This also has the beneficial side effect of removing a place in the code >> that assumed PAGE_SIZE is a compile-time constant. So this helps our >> quest towards supporting boot-time page size selection. >> >> Signed-off-by: Ryan Roberts > > Acked-by: Shakeel Butt Thanks Shakeel and Johannes, for the acks. Given this patch is totally independent, I'll plan to resubmit it on its own and hopefully we can get it in independently of the rest of the series. Thanks, Ryan