From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4DFCC433EF for ; Mon, 4 Apr 2022 10:26:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D5106B0072; Mon, 4 Apr 2022 06:26:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25E4F6B0073; Mon, 4 Apr 2022 06:26:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D6DC6B0074; Mon, 4 Apr 2022 06:26:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id EB5436B0072 for ; Mon, 4 Apr 2022 06:26:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id ACB7780C1C for ; Mon, 4 Apr 2022 10:26:08 +0000 (UTC) X-FDA: 79318816416.12.109F10E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 1E48A2000D for ; Mon, 4 Apr 2022 10:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649067967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ev9r8nw0gvvhZdLigMKa0VV1CoeFkIP8Q2gOXiOQYyE=; b=BeKxsroo4wAFe2StRWZEEVhj6m44BBvVWl0WZYQGjDR4RGvbeqxeRHtad0uKsgWSaU2cYa ditbit+BqfpBv8QJuXIbMgskPQfSaKTUJJWoI7er2/MWK0oxCN6cf/o2r4hdWBt1wFpMhg lna/Bj/VkpfgETgMPqamHyZ5RiaxRkA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-329-uCwq_r1lOf2EuqQZLuhTMA-1; Mon, 04 Apr 2022 06:26:06 -0400 X-MC-Unique: uCwq_r1lOf2EuqQZLuhTMA-1 Received: by mail-wr1-f70.google.com with SMTP id s13-20020adfa28d000000b00205e049cff2so1578964wra.17 for ; Mon, 04 Apr 2022 03:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=ev9r8nw0gvvhZdLigMKa0VV1CoeFkIP8Q2gOXiOQYyE=; b=aUVqqCXfqHPybbMUo2AVHT6s8PX6z8Y5fEizCAzWIy5fFG6U4ttLOqu2+rXQ91wp9R X97YSUX4fTwNOq7H57IcRsyMiAgRBPPCYtO+OsU+7tbN5HZKz0RAkSdSW++zyAfFY1Se eWHlXLoqrTiimadXRhlFYnMLI4s9Ey3QntlTzCR12Wu91nwMR8pVHOD4Dn7iRPkg1pIL sSm3kYsudwBzZHBJEdL7foJd5CIEoF+h6Mr8rP4nhCViOyiCeEMLSuzx7dtmES1roCAL T2YDHqO2V/6K9R1UHJfVZ1sksyBpnI7iQR6FtA7WfHVdrO24G/aHr0ao1AWfFPApcyFz uUZA== X-Gm-Message-State: AOAM530JbtAhvS/6elNtrpCSm07aG9PhW2LNyxMKXarCQp8SYRIZVKK1 G45iSPxRqQ4UxaB17EJRp7igPogTgN55B8gpVDH8lrB7D+wQevITU10k2s1q2X/AHyXhIzZPr6E dD5gjtoGHYyo= X-Received: by 2002:a5d:588c:0:b0:205:7f17:3901 with SMTP id n12-20020a5d588c000000b002057f173901mr16415379wrf.359.1649067960097; Mon, 04 Apr 2022 03:26:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDhOTNsjVxzvF6M18iw9IgWqrnWcRXuK4JSl6J/cMFyPw8GGHQFk4MgsKtAwVwBQYbv68K8A== X-Received: by 2002:a5d:588c:0:b0:205:7f17:3901 with SMTP id n12-20020a5d588c000000b002057f173901mr16415358wrf.359.1649067959818; Mon, 04 Apr 2022 03:25:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:4100:c220:ede7:17d4:6ff4? (p200300cbc7044100c220ede717d46ff4.dip0.t-ipconnect.de. [2003:cb:c704:4100:c220:ede7:17d4:6ff4]) by smtp.gmail.com with ESMTPSA id c24-20020a7bc018000000b0038a18068cf5sm16523093wmb.15.2022.04.04.03.25.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 03:25:59 -0700 (PDT) Message-ID: <314bea6d-a6ce-0c83-0b39-c9cda90a7281@redhat.com> Date: Mon, 4 Apr 2022 12:25:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 2/2] hugetlb: Fix return value of __setup handlers To: "liupeng (DM)" , mike.kravetz@oracle.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220401101232.2790280-1-liupeng256@huawei.com> <20220401101232.2790280-3-liupeng256@huawei.com> <533f85f9-82e2-bfa7-3788-4b2a668daedf@redhat.com> <03d68ba4-0d8f-824b-8c4e-92c9cade6fef@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <03d68ba4-0d8f-824b-8c4e-92c9cade6fef@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: bjkaof4wec7wbuwdju6dsyxei6gknnjp Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BeKxsroo; spf=none (imf03.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1E48A2000D X-HE-Tag: 1649067967-610022 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.04.22 03:33, liupeng (DM) wrote: > > On 2022/4/1 18:46, David Hildenbrand wrote: >> On 01.04.22 12:12, Peng Liu wrote: >>> When __setup() return '0', using invalid option values causes the >>> entire kernel boot option string to be reported as Unknown. Hugetlb >>> calls __setup() and will return '0' when set invalid parameter >>> string. >>> >>> The following phenomenon is observed: >>> cmdline: >>> hugepagesz=1Y hugepages=1 >>> dmesg: >>> HugeTLB: unsupported hugepagesz=1Y >>> HugeTLB: hugepages=1 does not follow a valid hugepagesz, ignoring >>> Unknown kernel command line parameters "hugepagesz=1Y hugepages=1" >>> >>> Since hugetlb will print warn or error information before return for >>> invalid parameter string, just use return '1' to avoid print again. >>> >>> Signed-off-by: Peng Liu >>> --- >>> mm/hugetlb.c | 18 ++++++++---------- >>> 1 file changed, 8 insertions(+), 10 deletions(-) >>> >>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >>> index 9cd746432ca9..6dde34c115c9 100644 >>> --- a/mm/hugetlb.c >>> +++ b/mm/hugetlb.c >>> @@ -4131,12 +4131,11 @@ static int __init hugepages_setup(char *s) >>> int count; >>> unsigned long tmp; >>> char *p = s; >>> - int ret = 1; >> Adding this in #1 to remove it in #2 is a bit sub-optimal IMHO. >> > For #2, which is not necessary for stable, #1 may be needed for stable, > this is why we split #2 into a single patch. > Again, I don't think #1 is stable material, sorry. -- Thanks, David / dhildenb