From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D20C3DA4A for ; Fri, 9 Aug 2024 00:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1C486B008C; Thu, 8 Aug 2024 20:50:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCC3E6B0092; Thu, 8 Aug 2024 20:50:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6C866B0095; Thu, 8 Aug 2024 20:50:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 98BEF6B008C for ; Thu, 8 Aug 2024 20:50:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4D1668048B for ; Fri, 9 Aug 2024 00:50:39 +0000 (UTC) X-FDA: 82430876598.18.16CC456 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf30.hostedemail.com (Postfix) with ESMTP id 38A1180005 for ; Fri, 9 Aug 2024 00:50:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jLj0MqHd; dmarc=none; spf=pass (imf30.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723164628; a=rsa-sha256; cv=none; b=GkMfn5GhzoUjK5vA+3sksH2ZYxMslxCoPEXREwJ2TwdpmQxKhjv25yeOgitjrhYUmrRjLp EhTpjsEcDQ0sgzSOCDPZMQutsnNolBO+i39MVFtOtcGEDhzoUK5vUpvRertJ1/QfQrs7qP p8VWMQHvcEgn10vOyBJ75YhW5vzao9g= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jLj0MqHd; dmarc=none; spf=pass (imf30.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723164628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XRmm2092B9I+czSGQLTLNg6rXkyYZ0X8PsIRu9Zj0hk=; b=eH0jyGhom//2hksNKA1jEdtHh8xx5TzCgvpE0gx4nfD9I54E8Krr5uxOPfYNJ+sqvISgRX P83aXZrZhVH4mZS25KWaWCbXI2R7wTojPGFTT9e9QotvDBQQY7ZF2iFEBQ5MS5sqVpq7q1 Cyk9LcCJLVCMQvNb33Ai9SzkaFpIK2o= Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-7ab09739287so1098404a12.3 for ; Thu, 08 Aug 2024 17:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723164636; x=1723769436; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=XRmm2092B9I+czSGQLTLNg6rXkyYZ0X8PsIRu9Zj0hk=; b=jLj0MqHduQpyRw9cfD3aeZ/gVUB5pdIbSSVwWp3/iUiW1T+vGuwYdkAoqtEWCqRBCr z2tOIha+bEap5tbW9cdmyopgHQe8G4NjJlLXI//COSJBNKNho+8mGsRryCAc9YmarwYT CFNhDr8Cfzv6rtzk6yR+W1I4m6STaerwflBcPbGOU2l5XMXBMTxVS2JMEaecjuApxigg 6LX9j8ZLqsF3hcOO1evBls84YGCqJs8KYHJJ50EokORUP/AE+kuSFg6NawJVPrqYDw64 /m8srQrn6I6sz19XNz6MvLTT75+V8gvWSJ0PG2foNaLKk9B8stqH8AfxhmiL7pp+N7pB EC8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723164636; x=1723769436; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XRmm2092B9I+czSGQLTLNg6rXkyYZ0X8PsIRu9Zj0hk=; b=EqufZu8d/Hr/0Qfic/7Sll62O6kHsO+GA8cIDxB4gpnU+aL8uxH49qVizSp6KGMpUT BEY8MDya+7bnZ0LyZ0ow6gYllM6p/nrPGRkKEawQLsesdePQopKhdSvogwRTE029vyBi KeIg3bjLk38TfA6QD5sc59JtunM2dQnR3Fi9+iCTBBrDsKnQVIkAYIvzIWqVSIjh++7Y Isd3A8cIUUeOZe241OS3QNa4qIe3uZTmMRf5fHkYJvHWlRfUbPedenHPoILfj+mNriBi 1LnjkIBEccGHNsdTCFQMWTYL4D1sl0HRGSdFhVqsC5B50a79OwiNBlDMSFoSKhUtCdJQ 1Phw== X-Forwarded-Encrypted: i=1; AJvYcCVgKgUDjO9kdOMvK7G3SKbs2+QG0nsdXzFEPTlkcP8TUuy/cI1BLf0i5jywl3V2lIEHouIKu6uAHHJAYkyCcSM3wlc= X-Gm-Message-State: AOJu0YxemjPMM0cV3EAGoa4Sknakl0FYNugxxvU+SojzQASZ4hxL/R7k F+grhlhhMUXIwPMl5EQMPStam2ldYSycI49/4jABXheBzJy0Imi6 X-Google-Smtp-Source: AGHT+IEWSyKVWUAv3lBEOIVOVeGZXhieT11SQEcNJhGufwvPMX8HuPyit9dqb1eDxDVkJMuTlkUOMA== X-Received: by 2002:a17:90b:390c:b0:2ca:8684:401a with SMTP id 98e67ed59e1d1-2d1c3461395mr4140870a91.32.1723164635674; Thu, 08 Aug 2024 17:50:35 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d1c9c7ad06sm1775981a91.14.2024.08.08.17.50.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 17:50:34 -0700 (PDT) Message-ID: <314821a5-43e1-4c96-ad8d-188bca8ae0a1@roeck-us.net> Date: Thu, 8 Aug 2024 17:50:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review To: John David Anglin , Linus Torvalds , Thomas Gleixner Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, Linux-MM , Helge Deller , linux-parisc@vger.kernel.org, Richard Henderson References: <20240731095022.970699670@linuxfoundation.org> <718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net> <53b2e1f2-4291-48e5-a668-7cf57d900ecd@suse.cz> <87le194kuq.ffs@tglx> <90e02d99-37a2-437e-ad42-44b80c4e94f6@suse.cz> <87frrh44mf.ffs@tglx> <76c643ee-17d6-463b-8ee1-4e30b0133671@roeck-us.net> <87plqjz6aa.ffs@tglx> <87a5hnyox6.ffs@tglx> <8734nezz0g.ffs@tglx> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 38A1180005 X-Rspamd-Server: rspam01 X-Stat-Signature: mi561m9dojd9durf5igcqsh3bk3uif1z X-HE-Tag: 1723164637-658564 X-HE-Meta: U2FsdGVkX1+l3pC6jgk6m6S1LkuNp2f6Q+3z5fFUzysQIWHIVJKg85kN5P/InO9SQPXmjwc6tUlzfBLcug1H3W3QTn5ado7R/QlmKvmhefxze6EwYFVfrlQiNXL9B3rjHyLlfRrdTTed9QMmAPr8FVjg56+KhhM9k6cnjxNrat3t8DVD46KR2fNhR72jHplW1eWTGGBXxmdUckwZ0VIAtAIJgQAYOPyE+2cQMKU4iSO1onlIj687PC+QV7kh+iYFzlmCiZI/18G22tlGxsavRwTrEA9ufYkFvtzPTqK7XlDsu4BKMtsdVDR2yzY7S5m0eCd8EoZZkFJc+2D9DSdgSNiz2LBc8voN3vC5bF24UK/KlbXzHrB5F96qtf+2dS3bn+0i5Px2cWmGFR1B+tFGSy9gHLqrYbF4gRF7u6kG5PnYCyKMcnsgzw6q1Wfr2bxiFOt1snp0jKklOORH/B/L9C+zKSuyGuTTqpokHpzw3MyOPsMhzW1CjKFhx5ysW6ZYYvTSJFV3XjsGVJe0fOsFZ4TTuhj3pl8NSl6jmvJtpevjfjp9qRfDCsFfEmvGuGYMftzJoowIG6mmeNdb5+iHuhrevJWFL0Em2dYfETIyErY+j2wcVzenT9zc4icxiVrOQPTJjj27E+q0+DgdxIqWGMD5w+/Yk4nDlblMydeH4YAgfYUr8vkpXLXlXPDSlY5vZlwTX17BL8iA2whFVhhq0Rg/LY0mSgyHv2z148qipOddj2ox/LwVzMvPLdw/kMP35E0Bsfr9W6mUehNvxw9S96mMAW6OYSeUovZVh9AZHn9HkRuECNmX0PaKpJAAlEVPdXZU+iIhqwYrJGhRBU6tydykruBRKj/Ehu+vfcF4fWKInbh325LsNSlQr3X/PPLHC4Vvm43gti25ngtn+stL0wbG6Q/l0ZXmg3M/Os3naJ+Rh8MdDRVinMxx8yGUzszKR8ltaIc66fNsR228Ij8 meM+4NQm cG433Rx3s34OEb6uUM0n5eqULoK5W7QbjUdbuLJFvaXfZNPU/sKiDy/7UKorJjH6GOkZMxffRKZoH2eP++uCi8ITviTIpFuddrkuY3G2fMzU5tAhP0KfCrw9rJczoub6RjmfBNJDqQ6jFdCQkwurz0YVl0Dqdm0dJdmkwaKYLsjEb9+ph6cpxwnXfePgcq5mGDCMrdtoI6Yq6c/nAlfWJUq+X6dVyrwW8o6LvcU1kLh+goVKBdzfLP47jJWVO2YSNCcRDmsC+0DSNiHyrnx8LiaV5YkwgP354fy85btY67yDbzYgGYdz4e/AlOAjZdkfFHwruXmI+fQ2BWjFEhPi0mbxiSRFMlF8iDIofna4E2fw0cxB9kCHJswWQHeBlh+BTDn2tshr9CQC8Kn1tgZ4CJm8ZWPiDMxCXRUjX5DD4jFdPbB1pxX2MG4OhO/v+gg1is2YpdUzPvS9oTN1uUQigBMaG3Nwc9OAzgM8h0L0F/yrc/FoedeisdsJ5KguuHHJDOpAq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/8/24 14:50, John David Anglin wrote: > On 2024-08-08 4:52 p.m., Guenter Roeck wrote: >> On 8/8/24 11:19, Linus Torvalds wrote: >>> On Thu, 8 Aug 2024 at 10:48, Thomas Gleixner wrote: >>>> >>>> Here is the disassembly from my latest crashing debug kernel which >>>> shifts it up a couple of pages. Add 0x10 or sub 0x20 to make it work. >>> >>> Looks like I was off by an instruction, it's the 28th divide-step (not >>> 29) that does the page crosser: >>> >>>>      4121dffc:   0b 21 04 41     ds r1,r25,r1 >>>>      4121e000:   0b bd 07 1d     add,c ret1,ret1,ret1 > I think this macro might clobber the C/B bits on a ITLB missing: > >         /* This is for ILP32 PA2.0 only.  The TLB insertion needs >          * to extend into I/O space if the address is 0xfXXXXXXX >          * so we extend the f's into the top word of the pte in >          * this case */ >         .macro          f_extend        pte,tmp >         extrd,s         \pte,42,4,\tmp >         addi,<>         1,\tmp,%r0 >         extrd,s         \pte,63,25,\pte >         .endm > > The addi instruction affects the C/B bits.  However, it is only used for 32-bit PA 2.0 kernels. > A second tmp register would be needed to change the addi to an add logical. > > The mode likely problem is the shladd instruction in the following macro in entry.S: > >         .macro          L2_ptep pmd,pte,index,va,fault > #if CONFIG_PGTABLE_LEVELS == 3 >         extru_safe      \va,31-ASM_PMD_SHIFT,ASM_BITS_PER_PMD,\index > #else >         extru_safe \va,31-ASM_PGDIR_SHIFT,ASM_BITS_PER_PGD,\index > #endif >         dep             %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ > #if CONFIG_PGTABLE_LEVELS < 3 >         copy            %r0,\pte > #endif >         ldw,s           \index(\pmd),\pmd >         bb,>=,n         \pmd,_PxD_PRESENT_BIT,\fault >         dep             %r0,31,PxD_FLAG_SHIFT,\pmd /* clear flags */ >         SHLREG          \pmd,PxD_VALUE_SHIFT,\pmd >         extru_safe      \va,31-PAGE_SHIFT,ASM_BITS_PER_PTE,\index >         dep             %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ >         shladd          \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */ >         .endm > > I believe the shladd instruction should be changed to shladd,l (shift left and add logical). > That doesn't help, at least not in qemu. Guenter