From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9505DEDEC69 for ; Wed, 13 Sep 2023 14:34:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAFD26B019C; Wed, 13 Sep 2023 10:34:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5F666B019D; Wed, 13 Sep 2023 10:34:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 926E96B019E; Wed, 13 Sep 2023 10:34:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 848426B019C for ; Wed, 13 Sep 2023 10:34:14 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 38FED1CA4BD for ; Wed, 13 Sep 2023 14:34:14 +0000 (UTC) X-FDA: 81231819228.18.77691DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 9DF542002A for ; Wed, 13 Sep 2023 14:34:11 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=evvUQIwX; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694615652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EmuGLD5luQvJ6ql8baS4uOR3VUqVjxIpyPp1zFnXnLU=; b=XUgtfCt2Dg3nSIYrQ2g992nw1GA/96Q7LCWWvCB7dWJ8xtCnptSGVTVp+fJv9m9TRw7fyP b1PHMDun9mQ7R0Mns1eo+JhHGo7nDlBW5/QMwnDu4aYEynQ0o+niT3XZZZFKcahs3dPGEe Kho2DE/P68HF5vPZt9qDi8UdQIjSbDQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=evvUQIwX; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694615652; a=rsa-sha256; cv=none; b=u11oyUf51/A0zKkRNKTMB33u8g4iteF8eaUSS8IKg0S9vwbRjA4AXqifpNssoSGk9wKQ+T iXBc4mG0EDTsWuIJOKsZx68rXBcPa48UNGje2hGFoceoN2H+FWX4A2TpADgF1kahgqwutk J53Y4GkV9/2Lz2TxbWvtmu86wNVDgZ8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694615650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EmuGLD5luQvJ6ql8baS4uOR3VUqVjxIpyPp1zFnXnLU=; b=evvUQIwXpimBaDXAGOadkoD1V5ReZQHbuD1P/KfMiov59v8AtemcM0ZwEhT3hLnqxPwqoO 7YE+3uCikHXbqB5NWQj1pOnSNKqItIinxJL/gbiipOdQQG1rSXuhKk8vldet0CHl8jKjmZ kFXvs4r21hmDGtBYpX+PXz/fTc1XJAQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-brhNSh67MHGXzSWva1pcvQ-1; Wed, 13 Sep 2023 10:34:09 -0400 X-MC-Unique: brhNSh67MHGXzSWva1pcvQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31f9186eb8dso2813947f8f.1 for ; Wed, 13 Sep 2023 07:34:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694615648; x=1695220448; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EmuGLD5luQvJ6ql8baS4uOR3VUqVjxIpyPp1zFnXnLU=; b=OMC1kfpcvLi/9UGFEosR5IQZi6ILOk42tPCXZuxrsZCq5T/M0osp8ROPXCrZkGWwxk x6QHhXTGLPmULUglMOUOodL+YYQWl5JVdp9CIsLXW18847VYc+sTtlbI4J+1RQWb/kKt +D4WqOTWNXPFtiiB29SbnLJ6EPgRMmgiLH6pj3mIfgKdRodd6iL/ccF8yeQBJbDdEynu xrP2xxuDAnd7nzTI2qGaf4tBX9Np9ZxVGAOVhrjzjdOopMz/PcYoP4Zj4ruPQ1tTxyGC VGWXUpXiWm7BJL1pRTEQZdiskeXNE4oubENHEJQlMA//DZT4nK9pD+ahZvnJJSX3AmHY 3uzA== X-Gm-Message-State: AOJu0Ywka8d5E8opmbNE+iH8ay9mYBReVrbspmDsZF08MTY0em3/QkYO VloWpyYTA9TbxiDBb3cA2vy0yNzigKvMCtiiaI1NkMYmyBpw5hIKCCS3n84NGm/oXcZr7CNT9Of l7zhVVOgESP0= X-Received: by 2002:adf:e350:0:b0:31a:d7ce:927a with SMTP id n16-20020adfe350000000b0031ad7ce927amr2155940wrj.3.1694615648307; Wed, 13 Sep 2023 07:34:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxXsLR5zjRy/DLOO1GBaPn0ZcQQNCwDb5j2gSJukItrCH3FTJ6g1iQgv/XHrp9fSH7duWpvw== X-Received: by 2002:adf:e350:0:b0:31a:d7ce:927a with SMTP id n16-20020adfe350000000b0031ad7ce927amr2155922wrj.3.1694615647937; Wed, 13 Sep 2023 07:34:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:ff00:f8af:dffd:bbb7:6c76? (p200300cbc70bff00f8afdffdbbb76c76.dip0.t-ipconnect.de. [2003:cb:c70b:ff00:f8af:dffd:bbb7:6c76]) by smtp.gmail.com with ESMTPSA id d16-20020adff2d0000000b0031981c500aasm15563508wrp.25.2023.09.13.07.34.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Sep 2023 07:34:07 -0700 (PDT) Message-ID: <3142b596-43d9-7c6d-cdcc-59137d0f2ca1@redhat.com> Date: Wed, 13 Sep 2023 16:34:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 2/6] mm/rmap: move SetPageAnonExclusive out of __page_set_anon_rmap() To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song References: <20230913125113.313322-1-david@redhat.com> <20230913125113.313322-3-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9DF542002A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kh4x1griybkzp1jdcuhkdzzcuf8qkiqc X-HE-Tag: 1694615651-100884 X-HE-Meta: U2FsdGVkX18iWXE9VkaCDVJAdLE86xeEmE0ul/g65z8GWQlIjoqy4LYmyCPr6SzxtGOtoorRJPMi/m9VojrOIuSYyqPB8bW1YkNyMpCHIGtA7xpBc+QQT18OvfbdaI6VgIybr84u4j8WtLf8Qo9rpCTvt+vatmRCvP0caR3zCksUqySNNlucUcDoTeZoiTEiOWpXNGJ+xMIgrwMHD4jxEQGmdfOY/K0SpITwvQPoO9hQKjJHtySV3b2jlmcLaue6kAiDGHRXZzVpfcMiPdFIvb3tlLkHvZQBIAvD43QApgP4Y+v+6YXbWo3kJPlDZGVx6kQvLPWVo+dpumNREUD9c4nZjO7HCusHP+KZD3yMa8OxVJT7LW7pn/LslCqQWb/ZmkzpgxSfUGLEgLGM3xHVPTsmOe/qsrEbb1ivXTkHcomF6Qn+OqMZALGir0kpeZ65ZMI8xTvytwaGB8IIZoN7lEHYq7smf65R1WjiDqOFoTS+wNRdTSYzg0+cbK1XKDdxzz3u6qmla2BXk0AHtvtWLfewUBVu3vctRuHmGEC1VehRMaa/M5KVIOHJV6d8Lum49/wM4m1nf58kQIQvzju6RhkCDSJtPpcM+KuPog+cGjQN9GHwVQIAPk+mRrZPUW2RxrEOL4Ry/TP/eddBypt/sag/EUBSjBraaydrj381FwN9AgyJI5RPqKklJeK7qnzAoHaUBqms967eIjH5gsIUc7ZXmJfJwkAO02gg/vSqmRZMMwM+kUTS4d8mdNKdX4wZSEjQ2//LRAGUpDfGOZJOaVFRS66KeP3obNkh3sINoEWr6I0WyjDdndfjl2wXNzlKcsQfumiR0bnNhsgM3iVd+ekjlx2JlhMgdbrNq+gKvuTRub5Sup4GFSHnVbSJMUaGOvJJuAZqrjFLs/bkQkPZetEOsmLdfG6RiEl8CwTNpeyjqvuNnXoeJKtZAn29CGpBUxNtKwh3zVeEvr0OxS4 XpUOKZaf jpFpDZT3EIPI7/c9DEsZfQ6M5Lk9B5shZDtQRL6qIA0qJAD0aLrW+99QC54nvyZnMiqo8oPm51oiXMfkc/vi6Df7fWj5SQPmq+vdu+R37e4LvsZ7Tj7uV3wc+uuloBJpMspBRx773cBN0qVLMU3P7TQAMBQFrwmq3u+6bsguEnZhpYq2AiNyIVpbF3q7NipFqU44xkfi//YmmIX9W3YL2HkjrLDhQpsma0OrKD9REFncoQnEGMvbswRBnB2LDQM08skcL2X58hqBzR8WU5m5sirSGnxpoZZHH6yhAAL+JOl1dGSRQ/C8l499hHagZQ7UVx5FHmMqhjkWADwuEXemAG46tHsyO7+iFqwv9XMOIRfijT+fsiehLTISNaQpndM05lkDDasf6lLOMhrL0R6pWNPCKV7oH/c8Fxm+X6ND4XBST5ss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.09.23 16:32, Matthew Wilcox wrote: > On Wed, Sep 13, 2023 at 02:51:09PM +0200, David Hildenbrand wrote: >> @@ -1246,11 +1241,13 @@ void page_add_anon_rmap(struct page *page, struct vm_area_struct *vma, >> >> if (likely(!folio_test_ksm(folio))) { >> if (first) >> - __page_set_anon_rmap(folio, page, vma, address, >> - !!(flags & RMAP_EXCLUSIVE)); >> + __folio_set_anon(folio, vma, address, >> + !!(flags & RMAP_EXCLUSIVE)); >> else >> __page_check_anon_rmap(folio, page, vma, address); >> } >> + if (flags & RMAP_EXCLUSIVE) >> + SetPageAnonExclusive(page); > > Won't we end up setting AnonExclusive on ksm pages, or do we make sure > to never pass RMAP_EXCLUSIVE for ksm pages? Not if there is a bug and someone passes RMAP_EXCLUSIVE for these. :) Fortunately, we do have VM_BUG_ON_PGFLAGS(!PageAnon(page) || PageKsm(page), page); in SetPageAnonExclusive() to catch such bugs. > > Maybe better to move these last two lines inside the previous test, > just to avoid the question. That could end up hiding another BUG, so I'd rather let SetPageAnonExclusive() catch it. -- Cheers, David / dhildenb