From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC126C5AD49 for ; Thu, 29 May 2025 12:17:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 031AB6B015B; Thu, 29 May 2025 08:17:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F23F06B015C; Thu, 29 May 2025 08:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E13B26B015D; Thu, 29 May 2025 08:17:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C18F56B015B for ; Thu, 29 May 2025 08:17:04 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6AF5D1202A8 for ; Thu, 29 May 2025 12:17:04 +0000 (UTC) X-FDA: 83495844768.07.9DA6F12 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 87795A0010 for ; Thu, 29 May 2025 12:17:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JXUzHNaH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=puK20j0N; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JXUzHNaH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=puK20j0N; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748521022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EpyOGu51sM3w0txWZkYdWnLmLNbxO0cQeTqdjYPrGMs=; b=CVPTqLtI1Cat4gnqDODH5I1INs42au6jcnD2hb52ZlXRrgPIXSOO78Wtvuc93zXhi7W51O btq2Y0Qdt9IMtUI9UblnzA20aFPpW1fDHzT9QMiqcsfUY0Vv5zazUYHrrvln6FZLitT/Fi 3u1ga2BJJfpszdFM1+mDFTcAIVsE73g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JXUzHNaH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=puK20j0N; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JXUzHNaH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=puK20j0N; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748521022; a=rsa-sha256; cv=none; b=t3OEFRMKAQYble6v1DX63EigvNv3tsQJ+/nMddm8evezCbOvTptKaA4pvoWGg/SNIHhmC2 bpyC5QMYY/QMCarelPNZuISqEM/YgyhDTeqQnf+aQ9fioj46Nrw3f1p2iNMagzLENvwIf+ 9sWdZx+/gS6hi5+ZdAWUD2GEzEQgxlM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BBE8E1F38A; Thu, 29 May 2025 12:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748521018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EpyOGu51sM3w0txWZkYdWnLmLNbxO0cQeTqdjYPrGMs=; b=JXUzHNaHxeXKFLqBAMrnC1pl5xarJjJvd0ROSn+9sOP1T/VMbee8aH81Dk2l8R/k78KOqo V014KjeN+4QaBsW0r90jIE/MVcCxRU7vbPyYBau10jJUuf/NN0u+RBM3rCexzSkiaXodXf 478M8e/fo5i978i39ph0q1MZyLcKEtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748521018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EpyOGu51sM3w0txWZkYdWnLmLNbxO0cQeTqdjYPrGMs=; b=puK20j0NUQJ5r6UIynWtzgsWNeBDPcA8zMtFj1obYlrdeejykPJpoFNW0DMpHE20OiaP6H UGn+I22C1Z4tp6DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748521018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EpyOGu51sM3w0txWZkYdWnLmLNbxO0cQeTqdjYPrGMs=; b=JXUzHNaHxeXKFLqBAMrnC1pl5xarJjJvd0ROSn+9sOP1T/VMbee8aH81Dk2l8R/k78KOqo V014KjeN+4QaBsW0r90jIE/MVcCxRU7vbPyYBau10jJUuf/NN0u+RBM3rCexzSkiaXodXf 478M8e/fo5i978i39ph0q1MZyLcKEtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748521018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EpyOGu51sM3w0txWZkYdWnLmLNbxO0cQeTqdjYPrGMs=; b=puK20j0NUQJ5r6UIynWtzgsWNeBDPcA8zMtFj1obYlrdeejykPJpoFNW0DMpHE20OiaP6H UGn+I22C1Z4tp6DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 97AB413325; Thu, 29 May 2025 12:16:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ru+3JDpQOGjNIgAAD6G6ig (envelope-from ); Thu, 29 May 2025 12:16:58 +0000 Message-ID: <31419fad-89ba-4d97-aeea-ecb6fa5136cf@suse.cz> Date: Thu, 29 May 2025 14:16:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Strictly check vmstat_text array size Content-Language: en-US To: "Kirill A. Shutemov" , Andrew Morton , David Hildenbrand Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Konstantin Khlebnikov References: <20250529110541.2960330-1-kirill.shutemov@linux.intel.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250529110541.2960330-1-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 87795A0010 X-Stat-Signature: jceasgsj6fo77szsf8f9yxd8p83yjf4m X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748521020-892375 X-HE-Meta: U2FsdGVkX1+eRTYAfCofMQHNLpsIqFrkqYi8WUxYkmUE4Nea1nlwSYnQljtT+TaiaQXarIawS/WDvB5zdw4lAOCAcWhZk7ouD+s58MyNofLXS6hODlzIxj2dpr23/elUzHUFt8mTJgyrd/kQN949wYAz4CdS7hR8fuuQqZVzVfnJXzGM0u48edaT1SacokHnlnmXbDMjxHnffK/2NK/fL3riXpq+LDAKFtbmMVlXYSXGRMCNVE+CNM9tKz6FCe5jElvpdYi3yiSrrXjlwgX2NHsMI2rdV4xmq4B107puuo9nm4MNc+DeL/E0Fc2XAqZrBj4StO67u1Rzy2iI1GlAErpaYCKuOj1UcRe2uW7KhZhpcl/QeinLEEBgo/VmbrTVMVDY0YXhQT7hwUUYhRFotMfGHaOpo6TqGkyMHeaVTI66ocQZZoOo/nGCgEP7IrH7dvK/MMaXjiZBL0AL+q4t9YWHHI7/t6ESklWXNVsmVVhiDkhJwQ367Mb6ctq9lUBrlJzL08ysz1wyQscM/GxR6IrdHTby09LlpgTxZFGw4Eb917k2SleVJye7PjrIvUAQzxjVOKD9pzcKQKo4qZT2vihrgiSeYSUzFFBKxF3mj+gBtaj08eNuxY0JpcgbralSjluqGKqJ3NiqJ0krMxb5Plm9wM7QT18Qor8L7A9VTb0ALMCtv3+iv21NqKsIhf7B1OGZ50S8sziHfPwpkZcO1Ctm6xyW+3gYYNryzUwh007AYG9qysQUu5FdI20TPbX6R+5HmG1KaVN8mjanwb2AwRH+JP1yheydvW2sVujXq0Rt2ZH00NcERY1ficMKFNSnpd6MTziLoDjRXig8fR954Zqo7T4tQTe2dz8BwOINsCJOWrHBpEmxW+dTJWg/6cnwaB6HP5BqJ7rF7ZF6d8F9b4GMI3zVvPGHZfruUbQecnOs50ImptvOgfsvyh59uEEetZIEC4qCTFcEtAkisOi 5rfPZqJe crzUTUJnFragdeuPq5KBsQyiP17mbhkFRdy+F4SKyTuaYoAIE3ggnn5hOpgjsc2XghjSSZoM7mJyhWHem9CY1XKOj/FFb/ZDtbSZHDUHiTmSAQaqEbbX8uMgHNyERusH0RP/Alz8dWSB6DF/I1/OlUr7wkfkOTgZc4ueCAsO1IxSEOqX8mDFlXHPPVncQgILHYUiHzbHE+Zwtb05ytkbNTwP0X1sEwln2fSVAWjZYFiwFt9Ygfs5KERcF+A7LJxhexIeia6JTzk6ltxS75SBUOV25IVW4iUoYoPN6aOl3mHyCInVBpNvRMUzmiLdYfE24D0IQyTbAFIu0jmz8E6uF2AIVRJ9Us3P/sFLV417jGPbOGioj7sF9dD0bJ2ZkVRR2rXtX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/29/25 13:05, Kirill A. Shutemov wrote: > The /proc/vmstat displays counters from various sources. It is easy to > forget to add or remove a label when a new counter is added or removed. > > There is a BUILD_BUG_ON() function that catches missing labels. However, > for some reason, it ignores extra labels. > > Let's make the check strict. This would help to catch issues when > a counter is removed. > > Signed-off-by: Kirill A. Shutemov > Cc: Konstantin Khlebnikov Yeah I don't see why it would be necessary to check only for missing labels. Reviewed-by: Vlastimil Babka > --- > mm/vmstat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index ae9882063d89..0903adace423 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1867,7 +1867,7 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos) > if (*pos >= NR_VMSTAT_ITEMS) > return NULL; > > - BUILD_BUG_ON(ARRAY_SIZE(vmstat_text) < NR_VMSTAT_ITEMS); > + BUILD_BUG_ON(ARRAY_SIZE(vmstat_text) != NR_VMSTAT_ITEMS); > fold_vm_numa_events(); > v = kmalloc_array(NR_VMSTAT_ITEMS, sizeof(unsigned long), GFP_KERNEL); > m->private = v;