Re: [akpm-mm:mm-new 279/310] memory-failure.c:275:49: warning: format specifies type 'unsigned long' but the argument has type '__fsword_t' (aka 'int')

[Miaohe Lin <linmiaohe@huawei.com>]

On 2026/1/23 1:32, Andrew Morton wrote:
> On Thu, 22 Jan 2026 12:00:08 +0100 kernel test robot <lkp@intel.com> wrote:
> 
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
>> head:   dc4fe40a11269aead253fa0beb098b00417b8694
>> commit: ce9b369feafe8c65aa134b0c8791bf7f19e463e2 [279/310] selftests/mm: add memory failure clean pagecache test
>> config: i386-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20260122/202601221142.mDWA1ucw-lkp@intel.com/config)
>> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260122/202601221142.mDWA1ucw-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202601221142.mDWA1ucw-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> memory-failure.c:275:49: warning: format specifies type 'unsigned long' but the argument has type '__fsword_t' (aka 'int') [-Wformat]
>>      275 |                 SKIP(return, "unsupported filesystem :%lx\n", fs_type);
>>          |                                                       ~~~     ^~~~~~~
>>          |                                                       %x
> 
> Thanks.
> 
> I don't think we can rely upon libc's __fsword_t being `int' in all
> situations for all time?
> 
> We could add the typecast but perhaps it's better to change
> get_fs_type() to return int?

Yes, changing get_fs_type() to return int looks good to me. Will do it in v3.

Thanks.
.