From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C80C4828D for ; Wed, 7 Feb 2024 17:04:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FD236B0071; Wed, 7 Feb 2024 12:04:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 983AE6B0072; Wed, 7 Feb 2024 12:04:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FD6C6B0074; Wed, 7 Feb 2024 12:04:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6AA9F6B0071 for ; Wed, 7 Feb 2024 12:04:25 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 329A71A0E43 for ; Wed, 7 Feb 2024 17:04:25 +0000 (UTC) X-FDA: 81765631290.28.F7DB73E Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf01.hostedemail.com (Postfix) with ESMTP id E6A854000E for ; Wed, 7 Feb 2024 17:04:22 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jeQCbYCD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=eddyz87@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707325463; a=rsa-sha256; cv=none; b=bC+wNgTPBP4iPsAw0tgYyaEkm6Y1ChR0PGEAsXOXtGJqWteJEe+s+mR7ichiehhuHyE3Bn IBYwm0awPky9J4FBDCCO/Japnoq7KRZs+BVHw+cdsmAfWHDsoGjD7317jatXhwIkQ9k/zW Zn/a8QydiqIsTf4RENvU4UanE4WFJaY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jeQCbYCD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=eddyz87@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707325463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bhaoqcWYBq6WE1pA0sdZJ3AMjQVihLX4TaDPsGVB7dw=; b=NlV33HLjCkkqXCNFLRCyV6ST4fMfRpnJK2l8KfSsi3js8C8UyfkNOD7LdgQ71h0TKgttoB ZOCXFa5qN+N6YLqTjFw82swQe/zrNig3fnBbMbsFeX5xNCc+eiHbQhtn8xCuvZE8f2xqSF /xe9NMeZBWa/B+3SkF2XuGjl2uXt0Pc= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-557dcb0f870so1044600a12.2 for ; Wed, 07 Feb 2024 09:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707325461; x=1707930261; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=bhaoqcWYBq6WE1pA0sdZJ3AMjQVihLX4TaDPsGVB7dw=; b=jeQCbYCDoG3hegq0m6symeYNpEwxdWaZGnzbzMerRAxga4vgEBTsD5z7E3PZvUQrjl fPkUK+HoZlrlI17pIuXZtkLxNHvlp5Da74LaFkK42H7SiWv0fwefi7onRqHQOzUegBt8 VcuUNip2dtV8LG6dKwSC7/bbhU/Ruhs/BLQzC0sS2Q4Mx+4pTsELJo1ZyZf1LE1I9D8g lYKBZ++P94xvWdPPFRQJVt8Vu6bdzKezQfJ8/iLpmY9ou2iKITDQr/5/hb/EdBhHwo9z fLQZ9KjQPiM+mtcJWG+1CXtU2UgJwRUT9cPaWGTyYoqdNchlU0Qv6yWLYWWCGFguDnBs XiWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707325461; x=1707930261; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bhaoqcWYBq6WE1pA0sdZJ3AMjQVihLX4TaDPsGVB7dw=; b=AcsokD2Nt+o103zVlWC5IwJAJU+pRUslVzmQZ5QiXsxI3R3gipN6HGp+PqHYU86jlW aa+MHl1C6oVKHxp7ndWevnjRSJ8aqPaD+civG2E+apaOVdZEZ+H3HAsaGu2K8KmK1gWL L7hh4WYm8GFnzfrAFNXVCcxbqjDADsvF/5Pj4288U78DosjSFKVtNijWYmqemXYySqH5 KJfUu6mVMlY/Ln0KendT0kE7faTQPhFwATe8sIja6qjQ271hzZ+k0T1LeudWGtabRmbG PzprsoiFxcsUvzDtXnVYc65lzQdYqwQVK1qaskyaKCpWNhH0rF5y5JMvNq7SwvlG7Y8C 5NUg== X-Gm-Message-State: AOJu0Yze8HMR0D3oEHStRi3mUNNdPl2yyGS68mpOjnr1x61jj8t56Fb1 aUXya7dCmUtYoxMDyzKqx13dSTomkHxxOUPJgEFvNKiAMQX9EaBh X-Google-Smtp-Source: AGHT+IHRBR/2WhSaKGewrC/+rxAOjYH7OTUOOESPli/UxrVCHaT3KTPyozDJlnFukYWBeRvsEEXjKA== X-Received: by 2002:aa7:d406:0:b0:560:cb10:65dc with SMTP id z6-20020aa7d406000000b00560cb1065dcmr2154569edq.33.1707325460990; Wed, 07 Feb 2024 09:04:20 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUY73TH9L4J8hRBF1bV0F4Y7a6D4uU3XvisIbJLhHabuUvYn6ku3Lbg/qkPCbPoHY3PSGY3+kGsbPyKyLKvSv8mxP9QRPr5h9EHAfCoToL/M0liUltVWBJ6/mI4QJFMjIEpdIa3bpBy50LktCeKQe8xA3GgT3uVWmANkSeYPMSJbd2pq7xghx0txNtKuQ68nai3mgHxykOS+hPU4mYWXw4qCiROdQEum/jbagQJ3BOCzsJUrmNqRuEfgFatyj17VTKNU300bcRcpa5R3rgzWQMZBpwK09cANf2NIZo= Received: from [192.168.1.94] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id j17-20020aa7c0d1000000b0055f50417843sm838582edp.22.2024.02.07.09.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 09:04:20 -0800 (PST) Message-ID: <3115274419b6bf0a27facdc0b41094842fc61c84.camel@gmail.com> Subject: Re: [PATCH bpf-next 15/16] selftests/bpf: Add bpf_arena_list test. From: Eduard Zingerman To: Alexei Starovoitov , bpf@vger.kernel.org Cc: daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org, memxor@gmail.com, tj@kernel.org, brho@google.com, hannes@cmpxchg.org, linux-mm@kvack.org, kernel-team@fb.com Date: Wed, 07 Feb 2024 19:04:19 +0200 In-Reply-To: <20240206220441.38311-16-alexei.starovoitov@gmail.com> References: <20240206220441.38311-1-alexei.starovoitov@gmail.com> <20240206220441.38311-16-alexei.starovoitov@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWW A+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3 IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E6A854000E X-Stat-Signature: ya61u7e3w1osuwdhnw3ggtokr1sbyh7w X-HE-Tag: 1707325462-737958 X-HE-Meta: U2FsdGVkX1+JhmDNRoNyRAeUyrEDC8DT3cDyoGqn/oc6cp8IuipFpEcM67BbYt8d3jrCeVC8eKrjqExZprGRqvyLmNhASoZPhyBMu6lVJjztTd5dHzbMRxG1YWdsC+xWJV5qvXGBfMmcBIxiSMUlC9pfqwd05GnHH+iQaucUV5Vn2NhRG6UEjg0zh4WNnBhZAuCvpULYwjBTmWy2OC9d7Nge1SMMI/s9/qm4ijXKUKSOmaP/aNvblb2clG86TvJRcdKRsrRkabumoHffv1iC5Kzm95ucY977xEVMYJxJK5b62tY5MH5c4Jb3SDoc/IjYgaLqIhgPvE+0QSeR8WwVq8hQFRxlDb0Bu3tla4tE7nWJsIlvD1LMLN6UIMkcP26urKbUfvvoFW5AkiZUEaN9t/YqxqyQqiFztSq9bmt+120ulWyefpnk5RuUE1dbx3StOXpTJ/XiyEQszqj06OJSkalnccgXMd+fnG/Xd0Xu/YgLFSdMZYqjA94rs9OLGluC36sV5KARf5jTyuBblkxCh6at2XImQ5wlrIZMM7UVdBXd3MGdk9TOufh/MAjptGbRX2ZwwJ1+70Se3qzms+VnvgMRARNMT/Q4W/w0DkmkQQeu6lf63Lgyz2RVhXwcfoH2firZNd+tUrB10rk3ECFoMA4Gk7O/4yjcBvKdSf3Cwabbz+N7uIeBm1tjhW9jjXV8qFo4k5c8R4CXlUjgixwn9ObrdZ94C8wa+SDTSgUBodKwRQUJGM3hHhLXpgJb8raYqobfSUWctOrapZ0H6bX63sL9m1dZ+tVazBCiDYMroKNy07CYHhsYlQdnkON2vebmCTk7gL2WC6+QM6T1TnG+TIhmisJYALlV2XHCvwL2dZLfOGWGXsSHAMLwogw7xAXy20F52GwkWyzkEDOHZ9RRZpyA6SfA9Is/RjTHG8KALDXQA3hZCw7V2UbOzM/+NqoGPUNQZg3EGd3FxxPhnez ZSBDRSdZ 5uXzLBQR4yd8yrRMgruZMVKCEMSN75i786OcHVfNZt4XAv3rgAVr9BdRz6Hv2XJhUZa5pzWVsWD0zCJmXAWO1t/2l1cxpxiKtcBxgN+dhlxDm/z8kHmLWHr4chAEfOFiGRiZ5H9w8JNmc2PLW7+9EX/opIwh2nIRPPQ3xeRXj08agEV5K59aZSZDDyQk/VkPq3OB7YFV7/KcqHBYo7OrKtPBx9zVOHrVMpUDEhmwjjvVebDi8+o2ajRCkOK4vgXPkjQ5A+MEOILoAiuggppHzrRRDD5qchKwXYsTuxsG1232kMky/s6lutRa6DMSfhrrMyx7KwlrUTQRwllk8yPxNAHMuLdcuDcvm0SAzlkOMNVlLbYnKyrqb3sxPO1x5LFnlYqE6OLw1SO9CxISm4B+27l2cUe8ibMlaJrBiFk/pHZhs4FxUk3/pzFGlGRgNpsJ3mId0jiqISVkVHZcjC9MOF3q7E1hR+BLhCxJTBkdnEnlr6ndGKC9SncaT2Jcu8w4NRzYg2mCo3JPtOsKMWOg2A8GNBMa3Kj7tCA0lJXkaUk2DBd8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2024-02-06 at 14:04 -0800, Alexei Starovoitov wrote: [...] > diff --git a/tools/testing/selftests/bpf/bpf_arena_list.h b/tools/testing= /selftests/bpf/bpf_arena_list.h > new file mode 100644 > index 000000000000..9f34142b0f65 > --- /dev/null > +++ b/tools/testing/selftests/bpf/bpf_arena_list.h [...] > +#ifndef __BPF__ > +static inline void *bpf_iter_num_new(struct bpf_iter_num *, int, int) { = return NULL; } > +static inline void bpf_iter_num_destroy(struct bpf_iter_num *) {} > +static inline bool bpf_iter_num_next(struct bpf_iter_num *) { return tru= e; } > +#endif Note: when compiling using current clang 'main' (make test_progs) this repo= rts the following errors: In file included from tools/testing/selftests/bpf/prog_tests/arena_list.c:9= : ./bpf_arena_list.h:28:59: error: omitting the parameter name in a function definition is a C23 extension [-Werror,-Wc= 23-extensions] 28 | static inline void *bpf_iter_num_new(struct bpf_iter_num *, int, in= t) { return NULL; } ... So I had to give parameter names for the above functions.