From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB3AE7717D for ; Mon, 9 Dec 2024 15:03:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 457E88D0076; Mon, 9 Dec 2024 10:03:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4071D8D0058; Mon, 9 Dec 2024 10:03:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 232688D0076; Mon, 9 Dec 2024 10:03:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 05A108D0058 for ; Mon, 9 Dec 2024 10:03:58 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 60D68C0354 for ; Mon, 9 Dec 2024 15:03:58 +0000 (UTC) X-FDA: 82875739926.24.57392B2 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf04.hostedemail.com (Postfix) with ESMTP id 17BB340028 for ; Mon, 9 Dec 2024 15:03:31 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fYV2jCOb; spf=pass (imf04.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733756619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F4B11m+j+SDYKHTWgiQ51I/BvybU5Pv0AqswYdCIzeM=; b=CnNm/R9CYnQFGXb8aUEvCPhe45LYi+OXqIy50DT8A+hm2Vz3YVFX8BvbTLYjXHZV2hfjjm 8F3HPi3ly8nYnxj243rJCCfFAQaDpeFOzCIYcm4AvNWJOsPUVkkgUdM7iJRkbU1qEy/zwk PgZ+DgM/BJVwrT156q3Zdfab4JxZTP8= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fYV2jCOb; spf=pass (imf04.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1733756619; a=rsa-sha256; cv=fail; b=xQUC6NjGCFVwdenbLfsaTksQVLsesPCM8l2FHE1+Ex4y0Wvunw0XWQOFH+cQMeb+v8ozhX mNOkJddP5md0ckAxO4j+AT6/wkBa0aZKE6PinMEeQQB0SMhs5hKVZpYKF7xqcmaSQi2L9j IECIjDZZDe4agM4deb4uzdcT7zZLCd0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733756634; x=1765292634; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ojKY8VGrB0NUTTNKW1dlZ7YLMt791JXzjtxlmEN2aZU=; b=fYV2jCObztZRGjJDB8bcegZi01QWFd4lE0OXDrZIZJ8jxSLnsQwoLNta eS4Bbniwi686OJXqCEOd+VesANbZ16CNiGQYKyxQt++3Ovry9blfPpeXI vNzg0Gt+CR4BFZEhlXXjAoWL3+kcsYiX5/akefohQ4LaaRON35kmV514X w2xRPn0V2IT9jfGMSrr7cyqWqwBUQOm9PBBauDX/12u5DjQ2/2JZTQyxv 8DuYG0eZy4cSK4Xm/LsGEaM1Q59dm5u6vo8cizigUHp5PwoUsJ1KY8lQe EtUx5nN/AF5WHmWmeUxjsDcW8BR2+4lVpmWktBhWe4ippLOPvoWFXFzmg Q==; X-CSE-ConnectionGUID: x18HOSYERTSiI23RfnFeMw== X-CSE-MsgGUID: 18CmQR5PQ76u24PSJ15SmQ== X-IronPort-AV: E=McAfee;i="6700,10204,11281"; a="37740435" X-IronPort-AV: E=Sophos;i="6.12,219,1728975600"; d="scan'208";a="37740435" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2024 07:03:45 -0800 X-CSE-ConnectionGUID: HvJiLP3vSLae+wV9LKUE0Q== X-CSE-MsgGUID: 4qvw0x78RcOcXc7SMhO5wA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,219,1728975600"; d="scan'208";a="95297421" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Dec 2024 07:03:44 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 07:03:43 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 9 Dec 2024 07:03:43 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 9 Dec 2024 07:03:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eEvqP/svuQHePq6kDJJha03hfHB1suI+0GkfdhwThGQ6lFfV58msKNuvw+o5ZTgpkLC6Z5/WQiSuaE9mMJ5JrF1Mk1RNY0Sujclvn8JEfeMlx4WpEqj0CqEe/qqBsgvG96TUQxMDVlSvS0/hRiwnSGEnBTlY8Q4crO0de30XvBmNpRgLAh/C/BcQzK4zxc5GjwNCP8DnWeVL6yZ5vs9hiPgIpIZFJcjza+zZGRZoDeFlREpnNUtBCvdvZ2D0+tlrh9rHIy9foG6CqaFR52O+iaUSws5a7Uk56X2ExeHRJ6bjswTCjGgOWxlt4F5ePn9c3wN15WrhEYtH2fgiJ9Djcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F4B11m+j+SDYKHTWgiQ51I/BvybU5Pv0AqswYdCIzeM=; b=yyGziDgGY3FQmopWALJEw4Iw8huHU9Iv6XqVZWe+cfsCqQwK3N1ZZwk+KXCOKa2VaX6vsGPqr0l+0lJhb5xq2i4UmuEMXXMsjMyB7druSe6IkQpjZNMwEQ5WG9w0jUSzyt6tG5dO8Ol3HwLsJAapsMmMlzkcBCMDViNeSRBwK3/c6W05/PsgrM22aEQT1T8XbDVJY2l1TwtpK1S2np9a+c1bJQQCnQvTvIdwMfkwpSXwWJ6SO4bklmimnteI6nwn1a6LWukzsJ3mkGth+SBMqfKkGIH41gP3v0dU7jYWjlmdod7kjepgCLHnEnvvKNKALvUT6m+hC/yo98t8nml8uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) by PH0PR11MB7633.namprd11.prod.outlook.com (2603:10b6:510:26c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Mon, 9 Dec 2024 15:03:39 +0000 Received: from MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::15b2:ee05:2ae7:cfd6]) by MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::15b2:ee05:2ae7:cfd6%4]) with mapi id 15.20.8230.010; Mon, 9 Dec 2024 15:03:39 +0000 Message-ID: <3113d4f4-4f8b-41d6-af89-f82cbc89da75@intel.com> Date: Mon, 9 Dec 2024 16:03:31 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/21] Converge on using secs_to_jiffies() To: Christophe Leroy , Easwar Hariharan CC: , , , , , , , , , , , , , , , , , , , , , References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <72c8eb66-eb67-4f8b-b0c0-13f1aa001698@intel.com> <95a461ca-3ed6-4380-ad1a-da12e1109675@csgroup.eu> From: Przemek Kitszel Content-Language: en-US In-Reply-To: <95a461ca-3ed6-4380-ad1a-da12e1109675@csgroup.eu> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: VI1PR10CA0100.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:28::29) To MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8102:EE_|PH0PR11MB7633:EE_ X-MS-Office365-Filtering-Correlation-Id: 19376c7c-35e3-4a5d-6282-08dd1862aa15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dERZaitoL0pnZEQ4aWhRMnd6b1BqY2lkQW54U3lxKzZ5RjExZXkrWEVMV1Jw?= =?utf-8?B?RTRrVkgwZjcvMGFFYXJkNjFtUXJmMm5LM0tWY3pTbE5uUytJc3VCdUhwT1Uy?= =?utf-8?B?Ym0wZ010TXNNY2UzbW8zVXBXL1MycE0wQTg2eHJuL2hKTWFUNmdaTVhBNHVR?= =?utf-8?B?Mk1BN2o5YXBYd3hudTZDN1RCOUMyN0ZSR1ZENlF4UFZOUG5ROHlJNE1GekRE?= =?utf-8?B?RTBjNlB3WUZuV256SHY0R1h4MlFHeTN1aFRMcTNucnZEaGYrRzFJMFRNZUNE?= =?utf-8?B?SFU1WTZ0SCtHR1gvc0RBdXJURzNkQzV0eG82eVJFNjNSM2FTZEs5S1FYNzJV?= =?utf-8?B?ZjVUU3hiZGN5VWRTNDQxaCtIQVR4ZjdkSjVDVndkOERyemJyWnlHNDZvQlFl?= =?utf-8?B?OFRxVytXUmFjelMvRTI4WE9jRk5abHRTcHZWRzRJWDRwSDhQNkJaVUw3am9L?= =?utf-8?B?eWZyWGlEbXBnUm5Zaytwbk92MjF0K09FUmlvY0FCcnRzSXhUNUo3djNyejBh?= =?utf-8?B?SmpuRjRLQVRCZWR0bXVtbGRJRmdxVzlKSURDb2ViMzN3SHNtVTZlc0ZsVGlp?= =?utf-8?B?S09LWVp0eXVCNE45aVBWOGs1QnM3NXltRldGdDJFSFk4RnVFaC9Zd3J0WVp6?= =?utf-8?B?RnRhcUE1OFV1TkxTU21DMTFIemc1THp6YkRsQmlmZjM2aitsaEhtN1JGY1dB?= =?utf-8?B?bVQ2cEtOS2NkQ3c5RHlDUWkycUg2bzZwT20xemFQMW9aam1OdU9GWXZ0SU9j?= =?utf-8?B?M29GWm5mRHdpR3p0ZGRreTlHc2ttSkpvQWdwOFpIUTRYcUpvUzh3NXFCTC9X?= =?utf-8?B?RUlKMWNCd0dFdmN2YlQ5WDZNR3BiVkVVdkpFbFRkS01pWkl5ZFFTeGxBMlkv?= =?utf-8?B?d2I3T1ZIS0c3UkQ1YnUvaWFtbTBqa0h2Rm9MdGUvSW5WMGVsNGFlVmtJems2?= =?utf-8?B?YkMrdnQ2OEN0SUNFTzRPM05CT3hpMkEvT0dRd29oUDAzZ09NakV0YzBrZmVN?= =?utf-8?B?c1VDdDJzdmFiRXdjODlmazhTNUZ2dER3Y1B1N1BEQ0FPWGFsTWVwN1BHUnVR?= =?utf-8?B?MzAvbnJSNG13dXZTYUdsdzJBSXZzTEMxOVhEYUl2SFBheStwZXROQXh1RnYw?= =?utf-8?B?aFZzanhNRVNDaGJCdTRXeENNbW80NklMOUwyR2hoOFBYKzZOWEpsY3RQc1NB?= =?utf-8?B?S0NXSmhvNzdSZXhGQjA0ZXZ1Tm1BN054Ukd4Y3pnRFM0Z1ZmRzBiWVU3SmF1?= =?utf-8?B?TmpDL1lROGVkOXFVK1hEWDBsQ0h3L21nalVvV2U0VVdzRlAyYmFCRjdqWUFF?= =?utf-8?B?M1c3WHkwd0t5NXZTanZ6YmF5djc0VzczdFhQL1JvVENwdW5adFgzcW9CVUhr?= =?utf-8?B?NVdzcjJNUm9IWE9xUWxCUnVzOFFpMTNhbWhHZHAvTnp4NmlTUTFiYXg1eWlz?= =?utf-8?B?TDF2SzkzbkNnZ2pQWlJrSkpzNUVaUWRFL2ZDdDAzcnhaUEpyUXJUU3NPSnlS?= =?utf-8?B?RjFMenpsN1RNL1R3blV5OVovaWM1WUNPanV5U1BOaWREKzBRWnY1RERPdVVu?= =?utf-8?B?L0N0bXhqd1FlbzZjZ0VPY1BKTDhtVFREWitvZHUzM0ptdnplTFVERW13Wlph?= =?utf-8?B?Q1dVdG5yWTJYSDZocGo1aHZ6ekV5YmlGZzV5Nk9Fd29WYVRjSFRjd01yTy9y?= =?utf-8?B?cWV0SHZxckNwZm9ha1ErNDVmakdnRzhwVmp5YXA0N1kzNWVMT3NBcUlNVksy?= =?utf-8?Q?wEL9oZQB6wix6G1QjQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8102.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTJoTjRHL0s2QmFqVDNvRGtIMFhRaVIzd21tTG9VTVJpSW1zdDl5QjRDUW02?= =?utf-8?B?d3FnMjJnSUtxS2FmcitLT1RuNzdaYThaZFJMWE93TnhmVW05dDRNdERva0gv?= =?utf-8?B?a0F1dEtSb0hSRUZKYmxSaGIzbzVIanVwNXRZSHFac1JTOUtLS3pxQWtoci9n?= =?utf-8?B?d3dGY1czWEdLL2tIanpwK1pQdGNKN1FVcWxpb0hmME45aTNnTTVHSTRZUjNN?= =?utf-8?B?UnV3OFFWcGd4ZTBBWENkRytDc3ZnVTZqWGJ0MXZXOVlySTJCRDI0R3RQVUNq?= =?utf-8?B?QUpYOVdwQXorRkJLSGNISDRpSjU0OUFoa1I3TklEeTJGY3FTbG9WUk9sUmcw?= =?utf-8?B?L3dyZmJQZ3YyL211RFZLZW1zdE1xN0xyai82cjdHZ25LUkc5Z3B0cnhOZnpG?= =?utf-8?B?RS9pbElJdHZZVDJKMitsSE0xRitKdXlhelRzNEZWcnp5YXRNSjlZcU1WZUV3?= =?utf-8?B?c0ZXUlRrTE80Q1NVcUszWStFbm91TmpvWlp0NVhndjRVajk4S0NuNzdVODRT?= =?utf-8?B?T2FZZmIrRE1oMDJQdWwvUHFqditUWDhyWEZidjJkdHBFTnRQNk0xVVRvT093?= =?utf-8?B?a3l2cmFieUtHL3pRRkxjN1NVR0RuWS9HN1FvanFXUzIyaTZqTkR5SzkxUWFn?= =?utf-8?B?VEJ6V1QrNXBZZHRhdkQzd005SXZwY2Z3bWNoc3NPcng0T3kwcDBkRGtEKzV1?= =?utf-8?B?RlJRdytOWmllTzg4ZkpCU2xISVpMdm5oUDZHYXB5UTRwVmYwTGRzWDcvYXRr?= =?utf-8?B?bUVMczZGeS9seWMzMnp4RFNYZnZ4b09Jby9URzE5WmRNeWF4REZFN3RBazRM?= =?utf-8?B?ckYxOGJxdXczWFNCYUliN01VclBuRkpua0VxbFRlLy9ydHRycUJRM2Z5ZW0w?= =?utf-8?B?V1ROd2VZSHJuSm1STVJhMXNKRTI1QlVhTVR1R1RvdEw0UEJXWitxK0ZzWFhU?= =?utf-8?B?Zi9vS0lGekIvMzlHMVNFN2V0OW5Ka2JrR0ZQOWRRVXlEcTVlYU5wdjJ1RTR5?= =?utf-8?B?aDl3YVF6Zi9IUFhjM2lDOW9WeldPL3lHdnpEdkpwdTFDU1FJSnUza1IzK0Zi?= =?utf-8?B?WGpRbFFMLzhFbTEzNmJPWFRvQXhQcUY1R1hFdnA4ZytXU1F0cXV3cUpIdStG?= =?utf-8?B?M1Zmd1AvTzNsWFZBWDJoMmxPOTdmQUExL005SmxhS2dXQ0h1SWU5QXlEbnFH?= =?utf-8?B?eGtMVERzckVIbTBtZ2F1MmVVcy9SL1o5ZHNGeS9NbHFEUzdIUVZZek9nMkc3?= =?utf-8?B?aFFUdndzMFBsTW5pNjN0cC8wRHhRaEhVcllYays1NndzblR6N2ZxbVB4RlRm?= =?utf-8?B?a3RtUUpZc0JuM0srZkc3djJZOUs4ZW5OVkYyT2VRTFljVkdWcFg5eXppMzQy?= =?utf-8?B?bVp5S1o3OGhFNk1VMXIyMFVjdGIveHNsaDdad0ZybGxXUlE2NVVpR2ZjaFE1?= =?utf-8?B?TDZDRnBEZGhSL2Rid0lWQThuZENNWENDQ3hvSFhFbFV2YjZlK0hNR0RhbkhS?= =?utf-8?B?TXkxdUdPV0NDOFJvMzdETi8wU3JCK1ZuSjh1R2xESWtOZk1rVUd3ZXZxN0hl?= =?utf-8?B?OHhKZGJkSW4vdVovTEF4WjZmd1luNFd5Q0NSZWI2SDZDMmVpSWtTYnZXaTdP?= =?utf-8?B?WERvWHJxUFFSRlg4OXUySkVJRlFWY1ZqbEExUXBVN00zQ212SVp5QmJ6YTBH?= =?utf-8?B?cHloUVdUMkN0UTlIVFJRbkUwMzh2S1RIckhyNll6Z3NXbVlGaG1FUEdZSFgx?= =?utf-8?B?ZnlucFlnN3FKemNQSTlRRUtXYWN0SC8yTmtrcjNURWQxTXk1SFRiWGN6MjNS?= =?utf-8?B?RytPR3pseHBSMzBqeWFmSHBmMkpnTXMzTmIzQlJhdmdtWjBNVWgzRGUyUFcv?= =?utf-8?B?N3RleTZQWjFhNWpnN0IzSUM5aVZtTzNFelR1b0Y5Nnc5MlI4UzlVNHNsSDRV?= =?utf-8?B?S2pLQUZzdzNTQ1lUNHdOekhRYnoyMmdwTEJZTGQwY0VEbDhVbEpmcjh3S1Zr?= =?utf-8?B?ODFyMDhpMXk4R2VLVjIySTBGRkJMbm5xYWMrTVRNMHllNGdHVEI5UTFNenBh?= =?utf-8?B?UW96ak9xdm1RdTcxY3BmY1NBRExKL1IvNkVIQ3oyejh1RXpraWwvUjllOWY0?= =?utf-8?B?TC9mMnlkYjF4ZmVrWFVKZVU2NzVVdlZpT0JMZVVJMjBZU0lUUm8xRGgzNWli?= =?utf-8?B?VHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 19376c7c-35e3-4a5d-6282-08dd1862aa15 X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 15:03:39.7381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aAwfYO53ax7O0HgtzbNHxDg4y4YIgk0CrCzgBW8cnkbVLdYnV/IAJaOB+cPgAGabZY4dGCuNoZovPhZ6+A3TkCFPUHvIA+3RncA26GujG54= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7633 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 17BB340028 X-Rspamd-Server: rspam12 X-Stat-Signature: igtfhujbxgsycyanjg74kiiwwnmmi1zi X-Rspam-User: X-HE-Tag: 1733756611-752587 X-HE-Meta: U2FsdGVkX1+FT8rwowTPd6/gE4wi4jQIzkBgLlMNs6RDI5a8Jf8C27MIIXk7FKouQXl02UjaOyeaeowGt63JvvdWpbw61QebbDD8GWBoTuh3exP4G990VYoFM5jC4uf4MTnQUW5BzthXSQ0QzXDmCGjij04OJeFFn5bDwS2+HlPoiVThHGsQ41gz7QtAT/JPfSAKlP/ZkP2Ad5LNB8L1VYgcA/WxO8BXkhz6ypF2dDR43HFp5qR7eDIUZJWYiYmzSWpYxSkq06bcFQFDnylIizLRD6r6tZ3Mtac8Jgurn/52lI03cmotXn4aki6hreCB7ZK+pDm9cCZiPYMPCbxfMiOaul+Lgk1/oOQ50w1PuzAar1fCiwLq2G2k4y2D2STINPO1rNxTltpb8Yz44JBnkkZ+qqFdBHyusK2L5bv5ngDTnP7g2FLKxJMD7/6uXEEkZEBsjvbiKTeQaG+t9eC9fJQ92wpUp3L1+p7SlbTWZR5Psjwo5LUpeFQoGnx0CkNctycnWzT+AmgPmbFpCTPPqiNoZD85m7HNOak3kWH5PuDvraBAepiEnFS1EFqgcn7lXOjc5eyqwLQWtl9vmK+wQF80kO5quIKBVEjetIXLRaJvTEbtvJjNk5d6+bvFAsUXWurMugf+R7Kye4VecC/Ci+MEtRShcwPSwMldwpWqtqMT1WKU44eIt+4vRi1p32FqBEU7gPIiTKoRGZnvw7T+7JB99zva4iGjo2mqlupgdEouv4+frx7RAmG4pLWJHS2isEKtneKYFFI7npzUh3l8HAj56GwouUK/jql3WOowffzRMeGLn531unp9ArYGx6WTfBsG/V2hFQDzBsuEZKNczNuZtUMqzvQsXpGNplZnHqAWiqBFRO+dGrMSYyZrQwjSzUc8QWF+spCYlO2d0+WRLEYWezHw9FYdoqWnlVElKgQv20yEI7xgpiU549MH4pkGmijG29sEandtjcTkMbV N7a4jPGV 0myWmK44amvKXUd5BfK2aAZRPDT4l5iGg3A2NwOphsUmwCTmH798DFqQyAH/mcvz1v8oCZMB3H+DjduJRFc9qH9PRy3NHt7i0GYBBc9xSHdMmCApd5pYZN8kOFWbwGBkFbLH4jSaLcVUtE7pqc33aH8qUyteXuBFj3OO+HBc/68g3mTX5t8cmLPZ9u3pup0CPJwRMEKUtaa1hIUO5z4q5GJE4h03r/zjp/L1jnusXtqhTOeYQLv7xdfPhc6yFjaZMiEZOz512hAK/7XZ2YsA6hbfCJpqAK3aKsWNtVU1MwXdj6cNxT98Op2NwK0PalCZDZpld7Vize/QwEX0jxWoYUpuPSqAi4D1/trygvNJkeeXuKN/jwNz6dvfqW8SFEUKhLUEUbG9HT+C90/uX600r/sA3bTDvPR1zIugh9mXjYGUJESqhlZS0/IgN0c9Lkwi1PipcW6D/PntdRwMmGR9SkYfg7rMReZZx+0va39gIXBdLNQyoQrFivNK6m7BxhaRObR6Om3QybytqiqWG2WIB1d5Ihg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000149, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/9/24 1:45 PM, Christophe Leroy wrote: > > > Le 09/12/2024 à 13:01, Przemek Kitszel a écrit : >> On 12/6/24 9:58 PM, Easwar Hariharan wrote: >>> On 11/29/2024 4:57 AM, Przemek Kitszel wrote: >>>> >>>> [removed most non-list recipients, it's just too much] >>>> >>>> On 11/15/24 10:26 PM, Easwar Hariharan wrote: >>> >> >>>> >>>> Regarding code - you could also convert msecs_to_jiffies(const * HZ), >>>> there are 10 that are greppable. Thanks to Christope, I re-examined those ~10 cases, and that should be refactored by just dropping msec_to_jiffies() part, not replacing by sec_to_jiffies(). >>>> >>> >>> Those seem to be mistakes. const*HZ is a seconds-denominated timeout, >>> being passed to msecs_to_jiffies() which will treat it as a >>> millisecond-denominated timeout resulting in an excessively long >>> timeout. I suppose that's better than a too-short timeout, and >>> apparently it's been working fine all along since hardware responds >>> before the too-long timeout expires. Half of them are in >>> drivers/scsi/arcmsr/arcmsr_hba.c and the pattern has apparently been >>> there since 2010. >> >> my point was that, the default value of HZ is 1000, and most of the code >> that is just `$value*HZ` was meant as "$value seconds, in ms unit". > > I can't follow you here. The default value of HZ is 250 as far as I can > see. as default I understand "the value that is effective for those that don't tweak", not necessarily "the fallback that will be used when not set by any other means". On my RedHat and Fedora boxes it's 1000. > > Regardless, HZ is the number of jiffies per second, nothing else. That is true. But the name is wrong. > >> >> Same for HZ/const, HZ/2 being 500ms. >> >> HZ is awful in that it is not 1s but 1/s, but it was easy to abuse the >> value in simple context. > > Why is that awful ? so, 1Hertz = 1/1s == once per second, something happening twice per second, with freq of 2Hz, repeats each HZ/2 jiffies https://en.wikipedia.org/wiki/Hertz the #define name should be really JHZ -> JIFFIES_PER_SECOND > > HZ is a nice macro that gives you the number of ticks per second, so > that you are able to easily calculate the number of ticks for a given > duration, regardless of the configured number of ticks per second. Again, technically true, but default being eq to number of msec in sec, causes it to bite.