From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF0BC6FA82 for ; Fri, 23 Sep 2022 10:55:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FD3B80008; Fri, 23 Sep 2022 06:55:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AD4A80007; Fri, 23 Sep 2022 06:55:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8F9980008; Fri, 23 Sep 2022 06:55:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D974380007 for ; Fri, 23 Sep 2022 06:55:36 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AA62EABBE2 for ; Fri, 23 Sep 2022 10:55:36 +0000 (UTC) X-FDA: 79943044272.24.82B6A99 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 5B55C140011 for ; Fri, 23 Sep 2022 10:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663930535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eef54XeIfI5ePPfdQCCa+xwkgeOXOv7/COauKA6kwwQ=; b=B3vXkYox2L9Wk0PYbB9qb2bBCWullQ+GV9J1IuJUYRdn5qA5RfNY8JQtv+zVwDN8jUAs/L HZZiKwP+2yPi3Feyz5b7108CNb2uSo++ZC3NcKmHPEgIgUeSFIb39F/uj9V/2lePjzjeck 1WD8qL3/4Pj0CULtsMO7/9UAlFiDkKA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-523-Ed5cxoo8N4GA9Ak2xpQzKw-1; Fri, 23 Sep 2022 06:55:32 -0400 X-MC-Unique: Ed5cxoo8N4GA9Ak2xpQzKw-1 Received: by mail-wm1-f71.google.com with SMTP id n7-20020a1c2707000000b003a638356355so5395665wmn.2 for ; Fri, 23 Sep 2022 03:55:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=eef54XeIfI5ePPfdQCCa+xwkgeOXOv7/COauKA6kwwQ=; b=rL5AlDK6xf+JKpXqPhLczv7irqFguRWt3695OepNXA2RlNSgEiw3tPYzHGhdQ41NWZ 1okiQIEVByD0bx4UeLfo1fIrEmYX6GwqwDdZlDJGoa7l/HZy21uEY5SqLjWkHRs+cvt5 qMbfcI0cQmOk8gyI+ZSRI5L59mFMYd0pCGWyAh6JJ4S/wjxdrTgPbsKxk+eEggISm8RL 43sPlESSXoSP2lmqg+UUmbhlBpR/9CrZ51H5jLIffN+leUI02cOItAwHs0zXW7+tFTu7 7zS/R9T4e8fy3DjqJkzP2xsERdYpyE8srESqHzYZopNYXNesNr/X1lIFV2tCZIHPV7g1 EUwQ== X-Gm-Message-State: ACrzQf03ZBFjflwF1vxT3SlUsELqc9O8D6ImaKoEw/5gAh9kBeXt5dXV 4JY3o9JY/0oQ1dK9nPfgWWQN2Di4Xgx6ZKda4M/o5U+R2/cbcScVlYpvn7xmWIJM4RyhxSEtm4i EY4SkrzkhubE= X-Received: by 2002:adf:de01:0:b0:228:62ae:78bc with SMTP id b1-20020adfde01000000b0022862ae78bcmr4702214wrm.41.1663930531715; Fri, 23 Sep 2022 03:55:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4kdGvtbB82mE3J4eOPvIcDO2feso4JPy2pwAaShDx+NaqgW7GNPKE3hF5xRI57FveqzL+0bQ== X-Received: by 2002:adf:de01:0:b0:228:62ae:78bc with SMTP id b1-20020adfde01000000b0022862ae78bcmr4702188wrm.41.1663930531409; Fri, 23 Sep 2022 03:55:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:cc00:4585:a83b:64f2:ad21? (p200300cbc704cc004585a83b64f2ad21.dip0.t-ipconnect.de. [2003:cb:c704:cc00:4585:a83b:64f2:ad21]) by smtp.gmail.com with ESMTPSA id d10-20020a056000114a00b002250c35826dsm7067750wrx.104.2022.09.23.03.55.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 03:55:30 -0700 (PDT) Message-ID: <3108be4e-319d-3444-308d-ca60729ea502@redhat.com> Date: Fri, 23 Sep 2022 12:55:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 1/3] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel") To: John Hubbard , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Linus Torvalds , Andrew Morton , Ingo Molnar , David Laight , Jonathan Corbet , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Baoquan He , Vivek Goyal , Dave Young , Jani Nikula , Michael Ellerman , Nicholas Piggin , Christophe Leroy References: <20220920122302.99195-1-david@redhat.com> <20220920122302.99195-2-david@redhat.com> <3dcbcc7b-9ca0-1465-5a73-075a1c151331@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <3dcbcc7b-9ca0-1465-5a73-075a1c151331@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663930536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eef54XeIfI5ePPfdQCCa+xwkgeOXOv7/COauKA6kwwQ=; b=8Y5D2RIIztJ3e+6IKjRwWhPVUBd/c3eoSJAUIfocC6SoPMAHE+Xhx11XU1wyg8u8oiQvSi Po1QKKAwN62EVjnqWuDisqwBW6HOogmcFUwv/N1XUaEHBcvkhovkkC+mKqUm99F7sNHKNf +s/A7KOwvk4MTR2SpLckXDCJW5Vtlk4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B3vXkYox; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663930536; a=rsa-sha256; cv=none; b=5n8aaGjq5psfk3XCP+HvuClRBlh4C2guwViiu2eRCMdAwzv7gW/PeOuaP85eX8dcZ5DRJA 0MCXLo9wWW+iCdaoIrAeev4dLp/HSpmhnNTmEyEG7d/SEAgTWXjrne0GMWxl3XrtfdecsF msm4uz0XN+I3SL6TCjIAs5r2voqeUX0= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B3vXkYox; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Stat-Signature: dftsqwaa7sdoaqej69dr3powsgxbjj6e X-Rspamd-Queue-Id: 5B55C140011 X-Rspamd-Server: rspam06 X-HE-Tag: 1663930536-297664 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.09.22 04:26, John Hubbard wrote: > On 9/20/22 05:23, David Hildenbrand wrote: >> [1] https://lkml.kernel.org/r/CAHk-=wiEAH+ojSpAgx_Ep=NKPWHU8AdO3V56BXcCsU97oYJ1EA@mail.gmail.com >> [2] https://lore.kernel.org/r/CAHk-=wg40EAZofO16Eviaj7mfqDhZ2gVEbvfsMf6gYzspRjYvw@mail.gmail.com >> [2] https://lkml.kernel.org/r/CAHk-=wit-DmhMfQErY29JSPjFgebx_Ld+pnerc4J2Ag990WwAA@mail.gmail.com > > s/2/3/ Thanks! > > ... >> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst >> index 03eb53fd029a..e05899cbfd49 100644 >> --- a/Documentation/process/coding-style.rst >> +++ b/Documentation/process/coding-style.rst >> @@ -1186,6 +1186,67 @@ expression used. For instance: >> #endif /* CONFIG_SOMETHING */ >> >> >> +22) Do not crash the kernel >> +--------------------------- >> + >> +In general, it is not the kernel developer's decision to crash the kernel. > > What do you think of this alternate wording: > > In general, the decision to crash the kernel belongs to the user, rather > than to the kernel developer. Ack [...] > I like the wording, it feels familiar somehow! :) :) > > Reviewed-by: John Hubbard Thanks! -- Thanks, David / dhildenb