From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15614C4320A for ; Mon, 23 Aug 2021 09:49:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9241861373 for ; Mon, 23 Aug 2021 09:49:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9241861373 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 147006B006C; Mon, 23 Aug 2021 05:49:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CE596B0072; Mon, 23 Aug 2021 05:49:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED7A68D0001; Mon, 23 Aug 2021 05:49:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id D0A756B006C for ; Mon, 23 Aug 2021 05:49:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 422C226823 for ; Mon, 23 Aug 2021 09:49:30 +0000 (UTC) X-FDA: 78505872900.13.A040FDC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id B6A441906 for ; Mon, 23 Aug 2021 09:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629712169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rhYJCRMkZEsXkLqbrYbAaQrmVIoehH5NK13qs7XLf9g=; b=Jm3cejr2jt0HC4U+ZwCR67a0IxkmUDuDsh82ZCgvbvEG5IepWrTvVLyDOFhcrfqAP5/JAk uDnglL1WE3OsU5tw0LQwmzz0nNiweMdlXu8C4i+3YLr3iBEcAzh7m6XqN5E8VmKvBpBzRq m4HSQymXbpKs5c+jczeqkIn7KJxNT78= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-rQP3oUusNGGMy2dTWa72tQ-1; Mon, 23 Aug 2021 05:49:26 -0400 X-MC-Unique: rQP3oUusNGGMy2dTWa72tQ-1 Received: by mail-wr1-f70.google.com with SMTP id r17-20020adfda510000b02901526f76d738so4949161wrl.0 for ; Mon, 23 Aug 2021 02:49:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rhYJCRMkZEsXkLqbrYbAaQrmVIoehH5NK13qs7XLf9g=; b=GvRRxwVow+lAZIX68mOtPVvcOasi3v5xg2B7xbqwXJNihjBWZOaLpcnfqXH695KWEr SGcctc/Php98s6PucX6plAmxOUHUwVUFI4GIL8YV7GT2JOGwfLDkyta2HwjvL+i52CUB x//c4SN869EIrxq79pfiqQ7Cbg2jC+0iVuYum9w8GoLAJHAPIiYrYb3w7la4wBw4kt5m 9CzCy1pGNgX+ZBA3Ld0pFkYljA9i9t5BDfFTmUvX9gFLRjeFaaYBTLQ8ClVnF86S7+fl cwSUIzpUF433sjseB4TIMM9AIV/LvT39/X7bFYciVChWhXY+Mx5g84QP4BU+TzAoh7/r 3Iig== X-Gm-Message-State: AOAM533MT0FepVJVCUSDPLxZOI4xS0MPKp4CUNVSWPVUqnw2sIQ89UMY K9ZQzIhoUKwMoX+4LO3A3gzmDCcFS6OVj5J6tSrUtFzIyUw9+5s0ActJbUzBlEUq8jowFidFK/E bQHGHmCaIaqg= X-Received: by 2002:a05:600c:2056:: with SMTP id p22mr5321594wmg.8.1629712164808; Mon, 23 Aug 2021 02:49:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhTR9x1F22AYEzpTQ9mUUJdLOKPaSvVO8Y/ebHKvclnWojMyDhYLL/VNAUhuTXxMd/9VZ8YQ== X-Received: by 2002:a05:600c:2056:: with SMTP id p22mr5321565wmg.8.1629712164531; Mon, 23 Aug 2021 02:49:24 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id l15sm3693327wrv.84.2021.08.23.02.49.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Aug 2021 02:49:23 -0700 (PDT) Subject: Re: [PATCH v2 11/61] mm: Remove rb tree. To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse References: <20210817154651.1570984-1-Liam.Howlett@oracle.com> <20210817154651.1570984-12-Liam.Howlett@oracle.com> From: David Hildenbrand Organization: Red Hat Message-ID: <3104a9d0-b8b3-46ed-4f10-1c1f0e5eff92@redhat.com> Date: Mon, 23 Aug 2021 11:49:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210817154651.1570984-12-Liam.Howlett@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jm3cejr2; spf=none (imf22.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B6A441906 X-Stat-Signature: mpbr56bryu9g4z1yhf6as8mh9ahrtwd9 X-HE-Tag: 1629712169-510424 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.08.21 17:47, Liam Howlett wrote: > From: "Liam R. Howlett" > > Remove the RB tree and start using the maple tree for vm_area_struct > tracking. > > Drop validate_mm() calls in expand_upwards() and expand_downwards() as > the lock is not held. > > Signed-off-by: Liam R. Howlett [...] Why are we reshuffling the code below? This either needs a good justification or should just be dropped as it introduces noise. Maybe I am missing something important. > /* > @@ -427,6 +414,11 @@ struct vm_area_struct { > pgprot_t vm_page_prot; > unsigned long vm_flags; /* Flags, see mm.h. */ > > + /* Information about our backing store: */ > + unsigned long vm_pgoff; /* Offset (within vm_file) in PAGE_SIZE > + * units > + */ > + struct file *vm_file; /* File we map to (can be NULL). */ > /* > * For areas with an address space and backing store, > * linkage into the address_space->i_mmap interval tree. > @@ -449,12 +441,9 @@ struct vm_area_struct { > /* Function pointers to deal with this struct. */ > const struct vm_operations_struct *vm_ops; > > - /* Information about our backing store: */ > - unsigned long vm_pgoff; /* Offset (within vm_file) in PAGE_SIZE > - units */ > - struct file * vm_file; /* File we map to (can be NULL). */ > void * vm_private_data; /* was vm_pte (shared mem) */ > > + Another unrelated change (there seem to some more in this patch) -- Thanks, David / dhildenb