From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC8FC7EE22 for ; Wed, 10 May 2023 01:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6225F6B0072; Tue, 9 May 2023 21:50:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D2DF6B0074; Tue, 9 May 2023 21:50:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E9566B0075; Tue, 9 May 2023 21:50:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3DFB26B0072 for ; Tue, 9 May 2023 21:50:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0DFCB1404D0 for ; Wed, 10 May 2023 01:50:18 +0000 (UTC) X-FDA: 80772665316.01.10D06FA Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf23.hostedemail.com (Postfix) with ESMTP id EEEF3140011 for ; Wed, 10 May 2023 01:50:15 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683683416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jxfemDDyQNEsCokgpuuXuus9rxaNLMAQe3Cs1+Pe5AQ=; b=xiI7XVwpYKdGJJSxgNcj+l7EhfX2y8ndQsmqrCJAI0RR1t3EetYLRO/1FQt74xdIZ8uOgU bJAWN0PljIb17ek3GaK+iGWlIDDrrSDYbg4D9RgmtSWQegWTP47OBg+xwP7N6W0jtW5zZA VJ6GK4J3Pd75PajtlgEI+F9LtiAVbg8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683683416; a=rsa-sha256; cv=none; b=Bv7HzYFtb+7A+Pb6M3aXkx37fpa3pqjJlgeRyyhNGF2bb0HLPOM7UECpQhhKeaLMCqoz8P XujdplL77lPZobNobm13qI9Ao+GdlQVo3gNnP/sqn4PWQg9t6lEK2Zf+PTkIOM+QJox+rG PJoc098J/+6/mMtlMV+jOeEQGozote8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0ViDQE-W_1683683410; Received: from 30.240.106.49(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0ViDQE-W_1683683410) by smtp.aliyun-inc.com; Wed, 10 May 2023 09:50:11 +0800 Message-ID: <3104080d-549b-8aa8-0265-371d4d33cfe6@linux.alibaba.com> Date: Wed, 10 May 2023 09:50:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/2] migrate_pages_batch: code cleanup: remove is_large To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador , Alistair Popple References: <20230509022014.380493-1-ying.huang@intel.com> <20230509022014.380493-2-ying.huang@intel.com> From: haoxin In-Reply-To: <20230509022014.380493-2-ying.huang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: esahz8z5wtr8ppzt47kunyrg1k967nwn X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: EEEF3140011 X-HE-Tag: 1683683415-298777 X-HE-Meta: U2FsdGVkX1+8deJ2C0TugfYglgmFfNas7AIFQIsS1TtBIYtlNAdgSvZGe9JraVTW4viVDx5BDTVwMYu/v7k24A1rUjpSiF5Xl6p+O/3ziGNHZsBxXB7cOnaH/mv76xqcTBu0KhuPVPHcVn8QDDO0ePu+j7JK5vqktASGblCr/bjPqg0SZmG8Ogj68k7mEtl+OuRbypQb4KxUKIBVKELjo3QMTOMbiWDWGwNM5cih64Wc8YKZRIe+liuLcna7MVEMcGKMxCcMS9WZ8oWlkV86mqG6G5Zc/j7hE7SL72bAuN1qb+6vz0mhk7qC0WeyzB83ip43r7mQFWYDm10FFZ5fE8hxXoTgOzBH4idTvYk5Qpf6sDmshWaeUVR+3Jylc9lVtv2soXchw2JXCyYOdYGg1zwDJ24RZQvYgU3Kv6V7TYWk/YhjZ3cjxNRKs4j/m9J4DH96tc6D98oHl1Kdjlqzz9lmXN3C5vhW9e8Hr8lpWjrTSbpaEJoS7ol7wfUsd7AfCPSrqCrjFn66GL9CXxT0DxEC9aM2rbDhK6CqSJUA8C0jN711B3Bia5TwIbYCaL7nzw06vi/9ARj71OTZoTCfQQkdzPdVRa2CK9OxuudVGJWAMProYnKYiWFpQQNhysfP6h2st+vqXGNSg4t+9S7/yLc8VGak7gPUGkJj3goxGePjoK9byjaFZ564aEHMrRMpKszfgBdOpprWxstUvq8vPWyC9Hnnm24QGUMJS+J+IIgyg+dd541yyKav1NAnMzYq8ttGGdPh9oF+YmqA1Dm7/JPJ+njr3zFQb7hID7cpuUuMibcuHisKiirejzVXrzv9+zjKyISMy11khziazG5NAkCQKIs2lJwb8OIrE2bLuskMBiAx0+n+RXM7BdYv6n5vc+uAzPPDKc87zLhL8q3OaCjqsOGOWCu/c+7wnl4r/IJuOJsIEgYeg+4wVfgEBUNZ8uDlrmj+OSICRwgkKXE vTTRORa/ V1OwCrcwLHhdKwEqfInshg/L5Z3fhmucB+r5uAjPrH+KH25KDpWO3L4pAKQS1iPO5qzzFDb/Ze6cAKmJIs29QF8mUV9LtWurcBANlLHGKCv8ET9kqM/6YxSQ+/n1b4MziiSSJyB4Ei9URmad3mkvhe2a7ex1kWUkCATWIQ7tjLUZoeuniOJMI92Gb7mt7DuJUOkhh3DVonFvGR8lou7SjdQZ6VJ0USOKFPMDO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/5/9 上午10:20, Huang Ying 写道: > Previously, in migrate_pages_batch we need to track whether the source > folio is large/THP before splitting. So is_large is used to cache > folio_test_large() result. Now, we don't need that variable any more > because we don't count retrying and failure of large folios (only > counting that of THP folios). So, in this patch, is_large is removed > to simplify the code. > > This is just code cleanup, no functionality changes are expected. > > Signed-off-by: "Huang, Ying" > Cc: Xin Hao > Cc: Zi Yan > Cc: Yang Shi > Cc: Baolin Wang > Cc: Oscar Salvador > Cc: Alistair Popple > --- > mm/migrate.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 10709aed76d3..2ac927a82bbc 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1618,7 +1618,6 @@ static int migrate_pages_batch(struct list_head *from, new_page_t get_new_page, > int nr_failed = 0; > int nr_retry_pages = 0; > int pass = 0; > - bool is_large = false; > bool is_thp = false; > struct folio *folio, *folio2, *dst = NULL, *dst2; > int rc, rc_saved = 0, nr_pages; > @@ -1635,13 +1634,7 @@ static int migrate_pages_batch(struct list_head *from, new_page_t get_new_page, > nr_retry_pages = 0; > > list_for_each_entry_safe(folio, folio2, from, lru) { > - /* > - * Large folio statistics is based on the source large > - * folio. Capture required information that might get > - * lost during migration. > - */ > - is_large = folio_test_large(folio); > - is_thp = is_large && folio_test_pmd_mappable(folio); > + is_thp = folio_test_large(folio) && folio_test_pmd_mappable(folio); > nr_pages = folio_nr_pages(folio); > > cond_resched(); > @@ -1688,7 +1681,7 @@ static int migrate_pages_batch(struct list_head *from, new_page_t get_new_page, > nr_failed++; > stats->nr_thp_failed += is_thp; > /* Large folio NUMA faulting doesn't split to retry. */ > - if (is_large && !nosplit) { > + if (folio_test_large(folio) && !nosplit) { > int ret = try_split_folio(folio, split_folios); > > if (!ret) { LGTM. Reviewed-by: Xin Hao