From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACC2CD1283 for ; Mon, 1 Apr 2024 09:50:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E7986B008C; Mon, 1 Apr 2024 05:50:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 271546B0092; Mon, 1 Apr 2024 05:50:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EB436B0093; Mon, 1 Apr 2024 05:50:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E4BE86B008C for ; Mon, 1 Apr 2024 05:50:17 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7782D805DC for ; Mon, 1 Apr 2024 09:50:17 +0000 (UTC) X-FDA: 81960492474.29.1BF41FC Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf26.hostedemail.com (Postfix) with ESMTP id A370414000D for ; Mon, 1 Apr 2024 09:50:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=FpSh5jv+; spf=pass (imf26.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711965015; a=rsa-sha256; cv=none; b=YeKdHaOpA6g72NHdr0GMZ8loiZssVN6MsTKMXPHPQRbLe5M4U2fI6LfrTN2CJK0DYxU/U1 mptHAKhIVDm5BB7x7uoLjk0h+2q35KkAz8cr/4IeggfgtoTOmjzHcjIGPIXUAdSTcXiE2x O8RZ2B8qHspT/1YAHL1+QW5Shr3t0cA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=FpSh5jv+; spf=pass (imf26.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711965015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ql1TH15I8Hj/wsidMi8cCe8wMqgq2i07smtwV4xaxUk=; b=kddX40qL7XBV9ms+/mhSho6xcrRxcSwjkFCBcv26YLJTgpjidoLxqIENudhmk1GtDSYJ7i kch+ib+KhWvV8B2GjBtTN2mskq7y1aszb3fOK7gz8itchEHLwakW2qbK7syX8fguP79BLn S6nywj5tlhLNWLYQ6kGZaKWZ/hm1Up0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1711965014; bh=7ysw4ufqTXNT3dIoSjrzTxCpKtjVoVAcMuNW6UXWP+M=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=FpSh5jv+L0Z9PLapdkN4Gx01Y2IlfRjhwCxGvkepetDwug8NV39krbt1CuU3Pgjbq bGjSURTa8wmqPbxCscLDQ6gQiNqjeQ5/OOqZKCSdk7qHwhnZH/i1LsyT3zmCCueRhh fpxCGkcSK2n5Mx9FUD9w4MAOeMIkETFMZ04vKDD2RATvpio3GPP9Mj/BrQSdBq+TmY Aw+Celgabdcjs09bVOiKwIjYNc/bxv12AeMmAJIZ5Qp+rY7C91gb3ly9ktX2BX2zvf rc4F6qfVCI/5kIADtlPc9FTxJATOP56ZvrKO7QfEDY2ju9esvWPWBPta9JfON9fMOf Nr5OYy+UcMATg== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id A6BAD378148F; Mon, 1 Apr 2024 09:50:08 +0000 (UTC) Message-ID: <30e88cb0-e31d-4cdb-bfd8-4559854937d1@collabora.com> Date: Mon, 1 Apr 2024 14:50:29 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, Andrew Morton , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Peter Xu , David Hildenbrand , "Mike Rapoport (IBM)" , Axel Rasmussen , linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCH] selftests/mm: import strings.h for ffsl To: Edward Liaw References: <20240329174236.2278217-1-edliaw@google.com> <909806c1-a9c4-4f51-a807-46075efb8ab9@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A370414000D X-Stat-Signature: 8kxeqmggrrjzic6t973m3adzoamdwzse X-Rspam-User: X-HE-Tag: 1711965015-66003 X-HE-Meta: U2FsdGVkX1/OC+BlQdzr8YXc9dzMYZhvkWezBsDS5eXsmB3b/RQ5vv8gXMMnusq4Incj5ImdUIfQfez3EMQxJXG8Xn88A8Yh5NkadMIzoDKQAEayF0cM6N8NmtWDV92PDR1W4d6sD+7UJT1532/52hQmXxqq6SnTe/unePpqPBs+WyXUaFPvHv+A5wmZNTd6BMDDbrgEK2vDDWmwjp/KrQNmS99D9/oJJff6fSamfr6M3ZnAdHY4O1uyFk5ouH8oRf8ERlcRJ4kDFV1c+NSEHl6K/rUI3TeSIJHFFnjabyL3WnRQJ57ikhFhU2OWFHzAHAkwQh2tXHC5r3jXTNxM6rTwDaTdBWDWQyTTjh6Fla/XJO2WVCjCBzrtqWrvi+zuCa0B8/mOc16j8jFGtDE8TeuC6pEdg2k6pwDQBYMp9BMsjW1LzQoJFrNFSQjneAkJ8MkJqlNwixJpww1BweXGBw9sfhaz4w56c35xFldhyOBKbg+obLCF/JS9GCdBhOsIETDH9egATDUjCxX2Tc/nyeBXv88tM08iEoBbu0U1xONofG8vLUen2SpA5dqQOsKcIzs6/KiuFLqoq/fdXBSAhpcpzxTLofTOltqaVQvQgcTw0rCpi3kUKHiUqNVsh81+S0NFrwwyr86MRui0jlqPytHMLDqUxcTBwohSNP4T20TinFC8qK1O0CNVZ7AwRYDTSM/OmYV/HIOj7qFnb0vtgvMoX7vKC+3LbzWmswNNX2rj8SmFR3etwX3fSzj3WfrkoOb0WzS9HLbQM6QggDhb8NRrMcwlJQp1FDbRFT9DtlEyAW763GzXb4kW9l/Modd0Ytk/g6ZzB2sWD7Mgz8H9y6TbcTSCxAslbAierI/QTUeicQhyRt5lzqPdZhH0E/zMkpPE3DGOdrPqPIrU3ftPyJBytcfAgYxLHL+Q28AdRU6WZolBMITaCG9YwhSM3efe9WlVPVRmXi6kwdqwNfj 11t1t8A+ FVUAXFUS96I9hwiCLhlB5H8gbZYtL+jkd9ck8IpBeGeyOEYF1ipx3hE1iV0H71LRr6geBNVEw3JJLLSPb3LX+Vq2ypeoK1XWdy1z6qg+SmgCXkCRCb0hYz+IP8ySQ4vQv0sRFVKIbN1Gi0/9o/GvECIpNeuotMTdhhVjXvPlT9F0kjQejAcgAGtMMgwPCrWzd6/QT7dh2BccUH1ckKdP8Cv4Sti+bFLhAtWl2svZOLtBEaNeHRZF7+FMEubnehnrF3PqsPTcq0x3Cs8GkLlyftjZ44ChGfZmDhN+MEQVEMdj62ss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/30/24 1:33 AM, Edward Liaw wrote: > On Fri, Mar 29, 2024 at 12:32 PM Muhammad Usama Anjum > wrote: >> >> On 3/29/24 10:42 PM, Edward Liaw wrote: >>> Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix >>> map_hugetlb failure on 64K page size systems") imported vm_util.h. >>> >>> Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h") >> Why do you think this Fixes tag is needed? This refers to a patch which is >> just moving code. It doesn't seem to have any thing related to strings.h. > Oops, I guess it should be: > > Fixes: 6f6a841fb77d ("selftest/vm: add helpers to detect PAGE_SIZE and > PAGE_SHIFT") LGTM > -- BR, Muhammad Usama Anjum