From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71151C32772 for ; Tue, 23 Aug 2022 10:36:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8B678D0001; Tue, 23 Aug 2022 06:36:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D14316B0074; Tue, 23 Aug 2022 06:36:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8D668D0001; Tue, 23 Aug 2022 06:36:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A336C6B0073 for ; Tue, 23 Aug 2022 06:36:20 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 770D1C14F3 for ; Tue, 23 Aug 2022 10:36:20 +0000 (UTC) X-FDA: 79830502920.17.7B10B57 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 078E3100042 for ; Tue, 23 Aug 2022 10:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661250979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+XmamW+3KCH3IL/ZlnTQBO91CZuDPkzzeMMrWghge4=; b=hqOPuJ9NFwy8/dQOCO/nCRDWJbwweehywyBHsjMU/fvnVUY/fHUGBUZvtokkONCnHeVE55 gI5WfSeTD/NBBY+tz2UhhA6SQnk/PJNsSvkTnI0UsDy3Q1WVLdvKSwGfXMEhzV4LTvpJl7 iGfmTs08K1xZP1ix9CzzRyes9MsG1F4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-631-F6WZ6WpgOayoW3KrCCT0uQ-1; Tue, 23 Aug 2022 06:36:18 -0400 X-MC-Unique: F6WZ6WpgOayoW3KrCCT0uQ-1 Received: by mail-wm1-f69.google.com with SMTP id j36-20020a05600c1c2400b003a540d88677so7778332wms.1 for ; Tue, 23 Aug 2022 03:36:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=I+XmamW+3KCH3IL/ZlnTQBO91CZuDPkzzeMMrWghge4=; b=MyRR9iLmcOvi3eUtfM6J0C2an8EteiNleXXoY+OQQdIiE+AL8zA98Q13/2M4J5Qp4/ +Bw+OmsoA6VAS3T3y/0/Q8PURy3oKzFmfCZDbcKk5vkkui4mE7BHLf74ltEu3JS+++Q0 ySgKnSdoAFJWsWTRCC2QGMtd1FSOpUboYyqkGuDH1ti0l5iB+YY9lHvQkhBCMEyn4GoE bdLmg+SXzOVLyMp7mA0ZCNwL2n7ByzyzPq6mTYH6ESx/QXR8i8GRUL+9KMTwavXCGuGk IGlCaSzfoFoRMPQNSD5uU3GcJ2VGcl9Faup2xJ2U4GfPiPmPwyp1JtJvDhUXYe5tyXmf jnXg== X-Gm-Message-State: ACgBeo0WzWGz5gQqTTc0BZziJazlh2tUEdMwxtXhVe1FzenKbTxDUd42 lKPRBUklDAxyCPFAQrlm5bzTY+Qqypfwl3wJ6+WXz7GtZ6Ixky/IaGbdvGsQeoRuSzVcgNpUwzw ZCez0TtdEPu4= X-Received: by 2002:a7b:c045:0:b0:3a5:ff4e:5528 with SMTP id u5-20020a7bc045000000b003a5ff4e5528mr1802860wmc.150.1661250977101; Tue, 23 Aug 2022 03:36:17 -0700 (PDT) X-Google-Smtp-Source: AA6agR50zssAIWyW1NcEa71aF+5HM7fzk5YasmUkHJtycFU+9mNi8F9TjaaXWZSXDKmO118IQz2YPQ== X-Received: by 2002:a7b:c045:0:b0:3a5:ff4e:5528 with SMTP id u5-20020a7bc045000000b003a5ff4e5528mr1802841wmc.150.1661250976859; Tue, 23 Aug 2022 03:36:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:1600:c48b:1fab:a330:5182? (p200300cbc70b1600c48b1faba3305182.dip0.t-ipconnect.de. [2003:cb:c70b:1600:c48b:1fab:a330:5182]) by smtp.gmail.com with ESMTPSA id c9-20020a05600c100900b003a2f6367049sm16693484wmc.48.2022.08.23.03.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 03:36:16 -0700 (PDT) Message-ID: <30dd7d1f-df39-ad89-94aa-d1562b84fa8b@redhat.com> Date: Tue, 23 Aug 2022 12:36:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH v2 06/12] fs: proc: use pageblock_nr_pages for reschedule period in read_kcore() To: Zi Yan , linux-mm@kvack.org Cc: Matthew Wilcox , Vlastimil Babka , "Kirill A . Shutemov" , Mike Kravetz , John Hubbard , Yang Shi , David Rientjes , James Houghton , Mike Rapoport , linux-kernel@vger.kernel.org References: <20220811231643.1012912-1-zi.yan@sent.com> <20220811231643.1012912-7-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220811231643.1012912-7-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hqOPuJ9N; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661250980; a=rsa-sha256; cv=none; b=PCO3GwQUn0fdMoPZrG1Yp96PHVnTDYWrg4maJEz5C7aimoDmxbkyHahbIWB2V2+EpoIPLz 039Chzehnt0YxVPqixT5tJwrDBgsSLngaUkozY/FVZq4lAGsCdTi2lTq06RT7OF9Rm5D2W 0dlWJwd6XGk6nVfU0gTytD6MuEar/Eo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661250980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I+XmamW+3KCH3IL/ZlnTQBO91CZuDPkzzeMMrWghge4=; b=3Ck3bSoh+whlweTbsunx8IQ23WipP0XvVHVToM0aGYjsifQCAis1CcSy2Gs5WqK/uaZ9e0 AAvv+9iRMy2qV8U9mX9Rre8qyflqQ3JHEiw9j/7zNI2zlrTwfAS6A0gJ/15BRGms9fGxXh 1JDQJbskFdzWEFvcmFlRDUKA/0w8E3c= X-Stat-Signature: sgyabnhq57w8ukx6kzmmjq35ihzxeo7n X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 078E3100042 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hqOPuJ9N; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1661250979-393280 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.08.22 01:16, Zi Yan wrote: > From: Zi Yan > > MAX_ORDER_NR_PAGES can be increased when it becomes a boot time parameter > in later commits. To make sure read_kcore() reschedule its work in a > constant period, use pageblock_nr_pages instead for reschedule period, > since pageblock_nr_pages is a constant and either the same or half of > MAX_ORDER_NR_PAGES. > > Signed-off-by: Zi Yan > Cc: Mike Rapoport > Cc: David Hildenbrand > Cc: Oscar Salvador > Cc: Ying Chen > Cc: Feng Zhou > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > fs/proc/kcore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c > index dff921f7ca33..7dc09d211b48 100644 > --- a/fs/proc/kcore.c > +++ b/fs/proc/kcore.c > @@ -491,7 +491,7 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) > } > } > > - if (page_offline_frozen++ % MAX_ORDER_NR_PAGES == 0) { > + if (page_offline_frozen++ % pageblock_nr_pages == 0) { > page_offline_thaw(); > cond_resched(); > page_offline_freeze(); Yeah, the exact number doesn't actually matter here. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb