From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57DD1CF649A for ; Sat, 28 Sep 2024 05:42:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5BDA6B018E; Sat, 28 Sep 2024 01:42:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D14B56B018F; Sat, 28 Sep 2024 01:42:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C21C36B0190; Sat, 28 Sep 2024 01:42:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A22C56B018E for ; Sat, 28 Sep 2024 01:42:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 648A8160F48 for ; Sat, 28 Sep 2024 05:42:11 +0000 (UTC) X-FDA: 82613051262.20.655A4C3 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf23.hostedemail.com (Postfix) with ESMTP id AB3C3140004 for ; Sat, 28 Sep 2024 05:42:09 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aNeeuCbi; spf=pass (imf23.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727501966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4FyavcNvp8cx3hxPaHac4eX/KSEDHBck84c6tqVegF0=; b=G3VH/xD95bzA6eKO4i9WRPcBRmwCgP6ZMiQeUAcFRAUn8oEVFVq1QEsCldxHhkDhXGfvfX thlLkUR7pO/LL2evoTooq+XSt/C8kNe3sV4myyup92krM56BIKuhbR/xWPkKkdMSAhtQ0k ijpQkEHPZKHL+5kHHWrb+rCAhaRfTks= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aNeeuCbi; spf=pass (imf23.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727501966; a=rsa-sha256; cv=none; b=W5qWqJiq/RTRr4fGtffZeJCRjIf8n3R3O0JT03WudUEw0GxpxpB31XpGLyfP+ELPu3xMae Y8QIq/7oEmphk0rPbQi1E2heVXhMKcHwMHPeIX40aheoi3C4ub8oSFVegqPy7I+wyr3AD9 Dq7+XL0EGgMmCh+U1wBbFde8KSTina4= Message-ID: <30d0d552-d296-48de-8e49-dc1d3c733131@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727502128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4FyavcNvp8cx3hxPaHac4eX/KSEDHBck84c6tqVegF0=; b=aNeeuCbi2NCUNT27dq7w9mSV6yFP+e9F2hlHy5GWvIcYaKe/b0SKJhA60VLD6d871y7RKU 12MLCQ/Lic1/m4jz98RpwCMyo5jINQ6xvhPBcImj+WS5NBwTCST6gRxKeh5TMMMq5yxC1l nK9j+PcCTfYvGBlPsnNMZJmKyqkzep0= Date: Sat, 28 Sep 2024 13:41:57 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v8 2/8] mm: zswap: Modify zswap_compress() to accept a page instead of a folio. To: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org Cc: nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-3-kanchana.p.sridhar@intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240928021620.8369-3-kanchana.p.sridhar@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AB3C3140004 X-Stat-Signature: 7ohguhg6szf5449r7s914ux538pq41t5 X-Rspam-User: X-HE-Tag: 1727502129-758897 X-HE-Meta: U2FsdGVkX190dOAJt62RFr4QMA6DAduyJdLFGmPwuHPp5bA+5EOos92Z+FrRm6SScIPNsUpxEK/JkJ+z2w5Y5hIdriQ8hk4oqjsv9wZfbnmWJZm4lcty3V/WsTPc7DKwuz4saGzjFBqWYZJBGBqE6os+831At/YOl6mWXewc5RMMv27VVuAeeTYvN8oEpxvMROLYXoJrBsBj5WR290d1yXj/s5GGtP+/FdJ8cJzieScdv+1QBe5B9ymhr7N4TiwgFJFbWJmNMGs/xCZ93u2dnmYAml6dRYc4Obb6vnBEkT+BFr8Son/hhAWLy6g4Vq5p9j5U+shz6QH31VtqfP0kHmYZoo3Ddf0Km1//fTTn1RNrlF5XtWMPrXEiGzCSeDrle/y5vQA6xZmzki8sr8ynJ8lxTtpCw8WA3q7GcjzGxdzoS6xiCsYC9wr2VxssxgA+cmEoOXdO1k9L/JBq4bdQoK8JeZrmPSo0boE6aUG76Xf15nTXJhZjN6O2EtHP7zBHJKVmHUZpBfL2iGl84WFMLow0dJ5lRerAer+O9I8xMcNyx/k011Au1H0YICAbwYuUkm8o0TEGySxjaTB80852AJilZyX9ffDfRkEyeqiV+Ha9UCkEuna6gEZUwB6mEwO/xM29ewYo5MbJZYvkYPK0fEmjFQQspCHUZMpvB4SuAVRWXurHoedEP7MSBuQX14KFCXZBPnVj47Ox5zJgdciswVE5zfOoNec9EdCnI37e+xmefZLtCAA4Atr7YFFT+bPiUa5eocKPpve67YK4cB65Aro0f5gBW3l+XG8r47kp318AlfCsSz7IPws+9eQEnyITuHGhHiinjJ+jWIRuIH31f9GFV7t9iQ2aupnzJo+WyuC5b+/39HcRmKvOCRHR/BX4sSiefRBg5EN/0ut9FCnf7vm56AntfzhSaJK0Awh6YENP30sOBSq+4ZIPF79Gw5NknTZ5yPkt+b4riO49mzV J1pDhPgV /afooOipQsW8NN674WXtZ3tU8azZWiOwGbd7nTs5uVLT3J/MM6ui39jj1ywNjnUKwdrt0npdp93rKildSlyy78PjZ1iN1ib3cbnI4Jt35vG93B7IGe0CWCcBImiNR7yfwpyTjScXO3kBE/fBPDFZLMk5NHwWSJZaOrgQMFZXlMGKuxgROHrQJkxaDI2LwcV085u6B+GizidARSDaqSnC6UVMhYNVrqoDAZSjm+JI7Dp9TpqLxbVprXoNzjdpAioZOnwXh3iOdCYywwk06zjB/aeMe6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/28 10:16, Kanchana P Sridhar wrote: > For zswap_store() to be able to store a large folio by compressing it > one page at a time, zswap_compress() needs to accept a page as input. > This will allow us to iterate through each page in the folio in > zswap_store(), compress it and store it in the zpool. > > Signed-off-by: Kanchana P Sridhar > Reviewed-by: Nhat Pham Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index efad4e941e44..fd7a8c14457a 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -875,7 +875,7 @@ static int zswap_cpu_comp_dead(unsigned int cpu, struct hlist_node *node) > return 0; > } > > -static bool zswap_compress(struct folio *folio, struct zswap_entry *entry) > +static bool zswap_compress(struct page *page, struct zswap_entry *entry) > { > struct crypto_acomp_ctx *acomp_ctx; > struct scatterlist input, output; > @@ -893,7 +893,7 @@ static bool zswap_compress(struct folio *folio, struct zswap_entry *entry) > > dst = acomp_ctx->buffer; > sg_init_table(&input, 1); > - sg_set_folio(&input, folio, PAGE_SIZE, 0); > + sg_set_page(&input, page, PAGE_SIZE, 0); > > /* > * We need PAGE_SIZE * 2 here since there maybe over-compression case, > @@ -1456,7 +1456,7 @@ bool zswap_store(struct folio *folio) > mem_cgroup_put(memcg); > } > > - if (!zswap_compress(folio, entry)) > + if (!zswap_compress(&folio->page, entry)) > goto put_pool; > > entry->swpentry = swp;