From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F1DEC873A for ; Thu, 7 Sep 2023 15:47:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BED286B0071; Thu, 7 Sep 2023 11:47:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B76C16B0072; Thu, 7 Sep 2023 11:47:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97F808E0005; Thu, 7 Sep 2023 11:47:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 77ADD8E0001 for ; Thu, 7 Sep 2023 11:47:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 32895B40B1 for ; Thu, 7 Sep 2023 15:47:50 +0000 (UTC) X-FDA: 81210231900.12.507C58E Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by imf02.hostedemail.com (Postfix) with ESMTP id C111C8000C for ; Thu, 7 Sep 2023 15:47:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Sfwf9pFT; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of adrian.hunter@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=adrian.hunter@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694101668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JUF45aEKdsaHkXz7Lf1PSRtihc4r11mTIEWxoNdLSLg=; b=QqMwt/ousn1KoESxkP/Z0qbYKGMK4/Fn5D++8Qx0eIBBDGBdLtK7LoL9sE5R1Kz0IwBJs3 PZvb2ABu9jcKzJUkSrwvzIXjQMUkN7xTsoY1SZfrCGCafz8dj1mUNyZ1N1YEB33rCJtIIn EfENDVFilND3B+0d6uzWkrX5D0X0w8c= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Sfwf9pFT; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of adrian.hunter@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=adrian.hunter@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694101668; a=rsa-sha256; cv=none; b=peVcdLciL4Z/jA7ioPZFVqapx2Utk+n44qNRZMWIne8hnoi5Z1SRD/9x8C0M2/5exdxDyK x1PY+B2dI8AT6nZLovgZy3ssg0xByRikEWNFP+7wQ+IUXAE05NabHa/f8nuwYDxFohUoWk O38/GS9lo/zXqNNkekrgYw10+DZlVCw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694101667; x=1725637667; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=fFdJWlOfOQFNWE/wQ1sARfEDpEEqtJd3bE+CeaqxZ+s=; b=Sfwf9pFTovtX3sbY2QSAgIVS3i+StBa8o3lGp2U/tjcZLH/3yvPm5Kw/ EfReBYU1/HclnIoSbkMPFG5ICI/06oFD8eZMV/bLZPaX6Lmrb8TL7tqTJ r0vrYj7Nm7oIdGYe3sffwPcmDUIEtzs7XCx2VjuIgI4mWtwtinzw3bzB8 /8A0nC3ZQlsWex8tVyhSS1hqZTrMzmA5QAre7t2PUWC9rQtSHFhhdX62T yIFn9iarfsoMb1qLM7ub+W2ectonF5Q7k6yJPq07RuT0O/eLdUh35Bf4K v1WxdYJcMOlzNkABoS1K2d2hBgS0Y5seHWzfXDjCf+J2HXxjQmrm9+i/k g==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="443807585" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="443807585" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 08:44:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="988818775" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="988818775" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.34.181]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 08:44:11 -0700 Message-ID: <30d0cebb-13f9-572e-9baa-b7450fec9108@intel.com> Date: Thu, 7 Sep 2023 18:44:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.15.0 Subject: Re: [PATCH 1/3] proc/vmcore: Do not map unaccepted memory To: Dave Hansen , "Kirill A. Shutemov" , Borislav Petkov , Andrew Morton Cc: Vlastimil Babka , Mike Rapoport , Lorenzo Stoakes , Tom Lendacky , Baoquan He , Vivek Goyal , Dave Young , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, kexec@lists.infradead.org References: <20230906073902.4229-1-adrian.hunter@intel.com> <20230906073902.4229-2-adrian.hunter@intel.com> <21bf2e44-3316-2372-44cb-1488f88650f5@intel.com> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <21bf2e44-3316-2372-44cb-1488f88650f5@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C111C8000C X-Stat-Signature: t9fzpemt3cjj6awwd7ngh89dexk4egpp X-Rspam-User: X-HE-Tag: 1694101667-820118 X-HE-Meta: U2FsdGVkX19M7nwHziTBjCM7+AK7MbjeQH5EglFUOhwKO/GbIDTScWlMOkabNu1I/pLRSGf6eIiKjZX6m0fQPmcrNYCNpT9/70cJr++T7zL5MJnEvzYGuiZNAPJ5QG/S3BG3HmLiNPuYvFnY8LQeXbnQdNmUqnhtvQgl5Rgga9sHUggZ2gPIOyGQ7OezdhPFw6qqYSf6/+qbP2yZezMxVjwoncp7RddtB2HMOBE/pI9VrKJlFMydiUrNpIPzTCWsiiQosw/mWJpoJDUlJq2ivlVDLNQkI6XQ/SFPoy1OGyUs25fW7V5Obe7k3o7qEyfCr0g3rtRa0sGIPCOFpYAFpXHVkJ3tRGJlm94oEMumVJHG0LEMpWdiwySlicWzi/RgcBs6Y3OWe6F4uI9pAu3gQetQEqPuEYVd5a+mK3lFSaeKqCDtAt2E3rrUZ6mGMBmzo2+8gDfWDEK46+llFiWJHtNo09Zt+xUTRT8t3QjM3pgTI1GXI0y2L69fnmqYzh3slMlWUicPWfp1NzZCZ6xjCBGRSG8GZ39zYuruajq0nWDaEZ6lZq5chqw2hUWiBoXmpSJOcYlLPXtTeIwwb/qGkfEQc91xWp+UjAAR1yNZCGgFYV295ezfJf9+by8Z0TeHlhtA+TmAIzW1ur/TPsi+R95I29VDSCV1I4UgbKHKi8OI+Fo5T22aXgFZoUtNyrJbDGsx4w4bk3AC6iHq4DBVGGCJ6eH5s1rSJtXiVBQQEWME5by3AiKh5YNTItDzPBJDB4NApKDF54gHEqdD9qJMJff6HkCbI0T4a2x7kXEZByrQ0lMm8xQlK45Gn8dOFjudqoXFd59M0/hxI3DzyApZksCs+TbkGwAfpJ5GfmF0K0dAaS42NycNLSitiVK2o/94UcP/7v1wRJV9po+jurouYA96k2OEBQMNGhxC2nC1/sIa7sOu/tOYgexgQTlwL6Wbk03ltN3n98SiGaBpiMi bb4sJxG6 DsB6Cvl7cRCRy7NcQivjan37z7s1hjQQ3weISMlR4kZ7m/WyA9+yGnIMEtuhLD37VfGt++StG9I8yLs+CIMAobJx9bBtPExCBpzYSmdENfAYgtWpUPg9CzfJ97OvMR2iEJA/SZxn7PlKdKhDjxsmQDBw75Xt2JYgsOeOGkr/mkqoDeNRcjFblid+hdw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/09/23 18:39, Dave Hansen wrote: > On 9/6/23 00:39, Adrian Hunter wrote: >> @@ -559,7 +567,8 @@ static int vmcore_remap_oldmem_pfn(struct vm_area_struct *vma, >> * pages without a reason. >> */ >> idx = srcu_read_lock(&vmcore_cb_srcu); >> - if (!list_empty(&vmcore_cb_list)) >> + if (!list_empty(&vmcore_cb_list) || >> + range_contains_unaccepted_memory(paddr, paddr + size)) >> ret = remap_oldmem_pfn_checked(vma, from, pfn, size, prot); >> else >> ret = remap_oldmem_pfn_range(vma, from, pfn, size, prot); > > The whole callback mechanism which fs/proc/vmcore.c::pfn_is_ram() > implements seems to be in place to ensure that there aren't a billion > different "ram" checks in here. > > Is there a reason you can't register_vmcore_cb() a callback to check for > unaccepted memory? Someone asked for the change to be in arch-independent code... ;-)