From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE3AE77180 for ; Tue, 10 Dec 2024 07:13:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 337DF6B012C; Tue, 10 Dec 2024 02:13:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E86F6B012D; Tue, 10 Dec 2024 02:13:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AFFB6B012E; Tue, 10 Dec 2024 02:13:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EF4DD6B012C for ; Tue, 10 Dec 2024 02:13:29 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A47B1C04B1 for ; Tue, 10 Dec 2024 07:13:29 +0000 (UTC) X-FDA: 82878182898.13.33E784E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf23.hostedemail.com (Postfix) with ESMTP id 1A46C140012 for ; Tue, 10 Dec 2024 07:13:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733814797; a=rsa-sha256; cv=none; b=7Mg8NR7KLJu69GxiuWvzNB3jqAZh+5IG51nf4zriIk9gwwOH62v+D/vrsCURKxVPMXOQHr rmmpBEgWod0AFJU3vxbVjpuOQS3JuPHrbbLt7/E9kUT6IMnXxBzl4NCml/tJ9onrrTVJO5 qONEY55h5pzvIwXKAy37vOdwdETVbt0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733814797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPVN4KB9sPbAMlcmGaZokqjQorSwbnzy96sgkqHKMww=; b=g6xxnrI0ZAzYwObBidloHCKaSew8yCkpNd6hg+LPoG6fEJlw9ckeu2FjPlpleJFh7cRoO4 3JC5gNUtQMNLrL94EtiaUtrNMLA2LuSqf4uOVhzsmEqY0HYAdwI8JvXlOYelGfopauq/8z nGXUsWrdkWlTC0eLlZsRiG65laUyjdo= Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Y6qcp1ZB8z11MHf; Tue, 10 Dec 2024 15:10:18 +0800 (CST) Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84]) by mail.maildlp.com (Postfix) with ESMTPS id A014B14011B; Tue, 10 Dec 2024 15:13:22 +0800 (CST) Received: from [10.174.179.13] (10.174.179.13) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 10 Dec 2024 15:13:22 +0800 Message-ID: <30caaca6-df23-c1cc-1980-88b83600807f@huawei.com> Date: Tue, 10 Dec 2024 15:13:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH -next] ovl: respect underlying filesystem's get_unmapped_area() To: Matthew Wilcox CC: , , , , , , , , , , References: <20241205143038.3260233-1-tujinjiang@huawei.com> <4a8e2901-12b3-b700-383c-3193adc0ed60@huawei.com> From: Jinjiang Tu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.13] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500011.china.huawei.com (7.185.36.84) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1A46C140012 X-Stat-Signature: eqnfrymhadhptpga1dyfedeat3rm7j7h X-HE-Tag: 1733814792-192643 X-HE-Meta: U2FsdGVkX18diRH+ppCtzHUUr4KbjCoCefMhbEemdViouC9C2NxlLr87kKm6VWHRv6E7cpr29f0au5Ro759cRoaDxpkS+Knlq1hs+pUq93uZttwrcvFt6Rn4LP7IqXyjIwZJM59Skv/pK2YDHOJC0Duebx4RLMs32s4HJ5wGffFAoNS4M5tvEQvZYXQesD4EjSNo5dTA/U1NLjLld98vr9xALsuphgOHRwFSSsuiYD9UQISsRcCNDTXHhuY1yh3F/ICaf3wgDCmdLKKAESVKAIIORB3hAVakD3lJdmuzlG6ch5Ys6VP4Ew/nqAWKlAXUQ6scORu2mFqN7sLyv9ZFDM2RoR8/t6mhLJJ3NwtQ2v5vRa9bZDWxgagZS4zmRwuEQCqXutR/Ip9y8O4CtMBqNNa+ljEPYNFE6qqyb46neJ91HW31fczyLWQLcaEopuz8mG68slH0BuPYrXEU+8D9A8/5bxc1+vj7NL9lVdaI6TVrNpPhvsFMhg5z6byBAGI521k0gOLtRIa1uR0JSy4mSvWbDn0KS1wJFzYiR0MADJOsA5HXLHTBX1DyXPzKU4csbTDxT/IcWWkWFmq1OAMi8bGjwb6/N99eoZ9a/5cVXuDjNiSkylIy2Xk+nq5/TB+VOIeHWzi5OkXQFfc+iD4P/tHyWMet5mcvWPVn3Ob4bkDSNTiBigSi2AHwOIf935VFsC1tqlM19USw2dWQoC33dTtuBlIR3LUSzvLR8vOFoOcOID3cywA5CD4sTnhzg2T1dvI15iHAxEpHvSzYHGlQgyASeE0sSqv9j2ZZGWSb7VFebSyZhEZ+SUML9/YZbA2ZBitaHkRG3R6igcJ2nRGPCkfq1pgTHbPGThpS9U+DbbbSXFUR/17cYqBO/ddDRXeuDK5E/BwWaRRTG2Brgkdip9gM57iz4rglOyFL0Jo1gLpXyR1y6AckPichDnI8m+qVSlI+NK2wk0LWAVWdjTq YKvuNJxK 3J9ZjWKYV7BPshH9jKarVxvLCfjEeEZm0vRrf5/AfRp28KqLdGTbLhLK+KTVylC7gmHemHLg38BBUQXZ+Wqc8Y778twE6Foc6RhcJZ8YzfdtTBOv4sBJlGp4y0p3sPBjVf7h2PvBnTdC/qcRMmdq8OY0pLggOGJvG4o25wM2KNSxJwXZhWd3WbSMuQmiKJLJCDvt5u3tt+tdTEtc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/12/9 21:33, Matthew Wilcox 写道: > On Mon, Dec 09, 2024 at 02:43:08PM +0800, Jinjiang Tu wrote: >> 在 2024/12/6 21:58, Matthew Wilcox 写道: >>> On Thu, Dec 05, 2024 at 10:30:38PM +0800, Jinjiang Tu wrote: >>>> During our tests in containers, there is a read-only file (i.e., shared >>> Show your test. >> I mmap an overlayfs file with PROT_READ, and call madvise(MADV_COLLAPSE), the code >> is as follows: >> >> fd = open(path, O_RDONLY); >> addr = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0); >> ret = madvise(addr, size, MADV_COLLAPSE); >> >> The addr isn't THP-aligned and ret is -1, errno is EINVAL. > Then your test is buggy. > > * Check alignment for file vma and size for both file and anon vma by > * filtering out the unsuitable orders. > > You didn't align your mmap, so it's expected to fail. When mmap an ext4 file, since ext4_file_operations defines ".get_unmapped_area = thp_get_unmapped_area", it calls thp_get_unmapped_area() in __get_unmapped_area to mmap at a THP-aligned address. For overlayfs file, it's underlying filesystem may be ext4, which supports large folio. For this situation, should we mmap at a THP-aligned address too, to map THP? Thanks.