From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB05CD1284 for ; Tue, 9 Apr 2024 09:43:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41B486B0095; Tue, 9 Apr 2024 05:43:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C9EF6B0099; Tue, 9 Apr 2024 05:43:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26AAC6B009F; Tue, 9 Apr 2024 05:43:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 08BF06B0095 for ; Tue, 9 Apr 2024 05:43:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D01D7A033E for ; Tue, 9 Apr 2024 09:43:41 +0000 (UTC) X-FDA: 81989506242.04.53A4E8F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 3C92D40007 for ; Tue, 9 Apr 2024 09:43:38 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N5QueZ7G; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ITTDgK+h; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N5QueZ7G; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ITTDgK+h; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712655819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JHzZNoF9LAIvqfpzqC49aZPvSP3IXdtgTHyGdNdqBqI=; b=l0ZVuhL/haI6vVZjUFu6CAqfsAaTN8IWeD25FYgY84lDg5MD4tHj7X6Hv10RsgqOQ4ezIx jLaxk8KRy5fknbZB/P7DPn5t5aGiIfEMFBeZwzFfphUUBufMgmjVKT7Ndznao1wCH11Xho 8+LPlA8IlRs7akcQU8sVsS5XOXdYh+Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712655819; a=rsa-sha256; cv=none; b=2mhdIlhLciBgpIpvruNfhAmuXMXcCJqnKB5oZAO8X6Gyni7V0/kwHPkfzPpHDcIguaJr6S +uKS3OHwIwPr+4ZLjnVamk0ZVewwvBYtzJC4pkx2itklcG/IENx8eIuufct/kAxhVf+S/k 6sXX2MAyyeDfvntEoVwgVeewO59TNOw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N5QueZ7G; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ITTDgK+h; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N5QueZ7G; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ITTDgK+h; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A0CE0338FB; Tue, 9 Apr 2024 09:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712655817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JHzZNoF9LAIvqfpzqC49aZPvSP3IXdtgTHyGdNdqBqI=; b=N5QueZ7GNlOz6aejdtTmFzmOGT1NHPAdPmdR4F5wY3VxhzfvvXL//unGVuhDCiMUSgSH0m jmzrJsrm8gxGoRLoTucuIJFe+tPebyJf5gYk9m/axUzERn7BK0Xyw4DN/FFBwQtpVKInzL kI5khzm6omixZeXIhjkDJ/E4FrksOV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712655817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JHzZNoF9LAIvqfpzqC49aZPvSP3IXdtgTHyGdNdqBqI=; b=ITTDgK+hY8xgcy6d+tXC+pHLC0KtYjToV0nvdTKtes8Fla1SV7nmAUU0D6uQ6MKuie4jXY LEUhMtthaogykSAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712655817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JHzZNoF9LAIvqfpzqC49aZPvSP3IXdtgTHyGdNdqBqI=; b=N5QueZ7GNlOz6aejdtTmFzmOGT1NHPAdPmdR4F5wY3VxhzfvvXL//unGVuhDCiMUSgSH0m jmzrJsrm8gxGoRLoTucuIJFe+tPebyJf5gYk9m/axUzERn7BK0Xyw4DN/FFBwQtpVKInzL kI5khzm6omixZeXIhjkDJ/E4FrksOV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712655817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JHzZNoF9LAIvqfpzqC49aZPvSP3IXdtgTHyGdNdqBqI=; b=ITTDgK+hY8xgcy6d+tXC+pHLC0KtYjToV0nvdTKtes8Fla1SV7nmAUU0D6uQ6MKuie4jXY LEUhMtthaogykSAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 84E2B136D9; Tue, 9 Apr 2024 09:43:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OK0UIMkNFWY3YAAAD6G6ig (envelope-from ); Tue, 09 Apr 2024 09:43:37 +0000 Message-ID: <30c6abf0-ae96-410e-b266-3fac9d4d2e40@suse.cz> Date: Tue, 9 Apr 2024 11:43:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slub: remove duplicate initialization for early_kmem_cache_node_alloc() Content-Language: en-US To: "Christoph Lameter (Ampere)" , David Rientjes Cc: Sangyun Kim , linux-mm@kvack.org, Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Hyunmin Lee , Jeungwoo Yoo , Gwan-gyeong Mun References: <20240406074449.563704-1-sangyun.kim@snu.ac.kr> <5bfe9c1c-7620-b7fd-b5fb-c481e7dfa5e7@google.com> <0ea2b92e-7152-ebf4-e1cf-ddb28b536c17@linux.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <0ea2b92e-7152-ebf4-e1cf-ddb28b536c17@linux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3C92D40007 X-Rspam-User: X-Stat-Signature: b9bqqmqu75jsis65huq8hdrb6mxh1s63 X-Rspamd-Server: rspam03 X-HE-Tag: 1712655818-715179 X-HE-Meta: U2FsdGVkX18YQX9ZviKdMg0q/BC4JWB4b1A9MeSdSjqnJtB5NGM3u/nFHBF1bPc9x+d4sMY2TOeYakqvCN1Pl52MSUqqwUTTh3SWEt6NJRd91Qify5F1XVlye9Uj3rwbebdijW7V8hAhYkvnGOEqMi6NadgnD0u5iZkxtlwpmMMDKi/QmFPhrb2huM9vQ0thXghdxNcbMszRsb6FBmU5r3CX20HUZ9zvLnO+FFhfBE0nGmDI2DOG+nBi4QnatCdowUDrWy0MyiKKGO8rLxdjrvD1hW0KIgy3sqIvQpHJgVKrjgNjsAWk9hX1vKTDyeqAI1BlY5kqkzbSv0nXf6mIblDJkACxzwtLABYORcZNH/m9u9aaCvF/lwxe60w4S838ljzQfr36TFf+qV2sBOIsdQzH57ZzuERgs4gVgE8datjx81lYjd8c02D+RSDxBTJcVQdeFTkkLtUGajLn1YzrsnY/DTlkUUKnnc/Vl9spWtAiTLbn3j9kDai5pDyNqd0E58bkT0rrazL3X/0YeUXFGqKXhJie1eYPv30kn5HyBwqjUksaeToNFfLrGZ4tueOQc4Cxw77oDm+G6f4gXRC6pB+maTVMTWY6lS26sVVyj2bXwgYDqAvrOO9YEGtnx1YNWXgW38462ied03VUBwVnsnqz6Xlvw+GNO9kmJyZlp0m3AkmTEE0FLs5H/D6zcjHqX0ZpsE0YZxzh0nfXmC5gQHPQoMis7irYd03Yj61SP3VIiTDtnP7yvoAjFh7A6edvoI7WhicQZ1PX1dHNIWeo7PTK67FDNvhHcHe0Vom9A5iTzD//YsrC/en0ZcksQ+1Kls8Cxpuz/X4APG/RkatGcBrj7T7KnmrF2NW6rTBFzZWPqO5qm80HD4qwraATZwgRpWV7rOFk9sopaX59PFdH5g0fW7k6FSYP7Q7uELRzAvGBEjQZaJEdkWBsaILms1nonIsSBtewgmrqKzWlwNj FQOPJxlS VTOPnuU+pVowrJIAtTRQf3+rMaV72ffMEkOB/EBXCN6jignOnK7IoYTd4YzlK/1ixV/8UCIqPQKtH3NX9Suu0NGBKN5aShFhLtDr21DGx+b9MXgzmrKyr6hm4tyZW/HwrJ795tDmQY3Nd6RF6+K7NBi79Wi9FeUz5N2r/S+cMp6RRJESe+CclLWhinlwrcbnZ3ehx+Ze6KAUNCkVVuYbr3O5Mrp/L7V3PLPhllGp2U537WQQjxkiUaz1qaO1+GfHj0PDOqXfc5uac3bxT55hpcbkngr9SIyu+CNljECBswO9+vxo2JboSYPSYEWNGoJ0uVjAHUAdo+lyCBgQy+t53Lai/zcPF7ChYIhz3nMAAFuX6pboqdYSC6JCNxEgTyDAgztkf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/8/24 7:14 PM, Christoph Lameter (Ampere) wrote: > On Sun, 7 Apr 2024, David Rientjes wrote: > >> What user observable effect does this have given it would only make a >> difference when slab_state == DOWN? > > It reduces the kernel text size and removes a line from source code. Yeah it's not helpful to have redundant code, it may mislead people that it's actually important. Merged to slab/for-next, thanks