From: Vlastimil Babka <vbabka@suse.cz>
To: "Christoph Lameter (Ampere)" <cl@linux.com>,
David Rientjes <rientjes@google.com>
Cc: Sangyun Kim <sangyun.kim@snu.ac.kr>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Hyunmin Lee <hyunminlr@gmail.com>,
Jeungwoo Yoo <casionwoo@gmail.com>,
Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Subject: Re: [PATCH] mm/slub: remove duplicate initialization for early_kmem_cache_node_alloc()
Date: Tue, 9 Apr 2024 11:43:36 +0200 [thread overview]
Message-ID: <30c6abf0-ae96-410e-b266-3fac9d4d2e40@suse.cz> (raw)
In-Reply-To: <0ea2b92e-7152-ebf4-e1cf-ddb28b536c17@linux.com>
On 4/8/24 7:14 PM, Christoph Lameter (Ampere) wrote:
> On Sun, 7 Apr 2024, David Rientjes wrote:
>
>> What user observable effect does this have given it would only make a
>> difference when slab_state == DOWN?
>
> It reduces the kernel text size and removes a line from source code.
Yeah it's not helpful to have redundant code, it may mislead people that
it's actually important.
Merged to slab/for-next, thanks
prev parent reply other threads:[~2024-04-09 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 7:44 Sangyun Kim
2024-04-07 21:06 ` David Rientjes
2024-04-08 17:14 ` Christoph Lameter (Ampere)
2024-04-09 3:51 ` 김상윤
2024-04-09 9:43 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30c6abf0-ae96-410e-b266-3fac9d4d2e40@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=casionwoo@gmail.com \
--cc=cl@linux.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=hyunminlr@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=sangyun.kim@snu.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox