From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF6EC48BF6 for ; Mon, 4 Mar 2024 09:55:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A60AA6B0085; Mon, 4 Mar 2024 04:55:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A10606B0088; Mon, 4 Mar 2024 04:55:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B29D6B0089; Mon, 4 Mar 2024 04:55:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 779116B0085 for ; Mon, 4 Mar 2024 04:55:57 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4ACA5A09DC for ; Mon, 4 Mar 2024 09:55:57 +0000 (UTC) X-FDA: 81858900354.17.A2F0B53 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf08.hostedemail.com (Postfix) with ESMTP id DE3FC16001B for ; Mon, 4 Mar 2024 09:55:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cGvkmAD0; spf=none (imf08.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709546155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fJL2FZjp6FpJVIHqmMOMutJHefMDGUSXIqNWloDrn1M=; b=QIpV5GXNqCUmNVDJXlH2uL6TDamO/wBlBkU4T3MF/qnNH5QNd4NB+wFYZOiZF8asw1NJYa qFNxPAykT6I/Epa6h7E6rGJikXqbTzWWS9bU0begfsgp8ZKPgBH4MO5d7Z0Ia6hpzJqvhd XBSuVrqj8wggilhgVlfvwnUcLGQEc2s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709546155; a=rsa-sha256; cv=none; b=mD5/z46ofdMKVwDC7M1wjgEYNvrWCcP5pPTHz/wNiQOZfSIbFuVN8k3V3g6tiDo2d4G424 Aou5vKZVT9sjXabd+wIkjkC/lLU0+6Vv0gTsD5ouwuu8+445eN2pCxv9fZ6vTUCpZBqVAz 2T7dSvYaTKb10BQJ9DJTqvg3Jd06VzY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cGvkmAD0; spf=none (imf08.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709546155; x=1741082155; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FNurAoSIJM5iqfJTeKCtzPgTaSyy2bsh6qtFhnt9DPM=; b=cGvkmAD0ZjvE5s6GhTjj+7OIT47lyKJxQU/hcu9HsmeAbRNyR2Y+iuZr NolEs/Ccz70D93URY+54OapIa7SuymqCj1zaTJMZiXmO63rlEmR+Rv8wL OKM5+Y3ZFHbi0jkZUZ7iPzS1hXBTSYDj9JgololL77rosVJ7+/5bC/fUh vHXjCZ0ePTorzZ0tVB5UflVXZ9jx4TGp9lkM+bF4EC03prubcAWIz0K7V YBbkfDL3Ug6U+VEs1GvqYYS5ii2NnVh4tzLhrHFH+rfL1YDfe7hgHPITd PxQCN44nwTBWeMiWym5HNxF/yGViBp1NX8FR3VUNRDUOwK6unjBzQ2T75 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11002"; a="6980718" X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="6980718" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 01:55:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="32105342" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.238.8.218]) ([10.238.8.218]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 01:55:49 -0800 Message-ID: <30c3bcb8-3bb1-4c88-bbca-909a02903f0c@linux.intel.com> Date: Mon, 4 Mar 2024 17:55:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v5 24/29] KVM: selftests: Expose _vm_vaddr_alloc To: Sagi Shahar Cc: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Isaku Yamahata , Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <20231212204647.2170650-1-sagis@google.com> <20231212204647.2170650-25-sagis@google.com> From: Binbin Wu In-Reply-To: <20231212204647.2170650-25-sagis@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: swanmk11ip3mrqc3dthqhem4iy7cisdu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DE3FC16001B X-Rspam-User: X-HE-Tag: 1709546154-418944 X-HE-Meta: U2FsdGVkX1+PDU63GXu4buugVO4Gwr+zoLnnGutsIpyGBj618hXOsfKkJSdFFGAIikGQyqf1uNuz7OBJMpQlxg1a3PppI4OFjEL1rbZL/XhIUYePhwo0DxmNLccXMLqCvNILL4EYbr4+i6FupVyOP7DPc9Kfa0Ck/RjAfzaPpSdiJWxWb6Y4sOXP8eXglCvIsCKu1fXIsrAI7/L1UIK2TvDNflKYLwnohF8f1CHL9H6opShD2OwHHpJvBDamq0BwH5TRIpM3pySQG9bw6pP0tW6wD63f7zEoxUgys2D4UJIK32FZ8rCqkm7D6n9ZZ6eypC3NIxFgIyE3blkpFsChERg2jD22Qx+hTkpb+iupehE4w6RQJQReMnE8Dfzyn7mS3XcEy6799dT0wavwqjKnzVWaaSouJQF8E2acxk24LliaYwyMooEXMcFHKmOC94EWvJQFQ2hVU+fqsV8CyQop1yFiocDYcdf2wfkdb+utDaq4PXOgVW7AboRsB6bQ9dep+Tuwoh/X5h96QlVgTE6sBlTR5BrAR3f/W00UGqlzImr7Si3wrFLbZsQkurU88bT/Kn45Sh3K+sJEbIgOqxxP6Y9dGgQli5GpNznWaBFRuRK/xwlwT+ZjAMj4islLxw6WnokuKI8hsSrvMzkSu5dDp+HXQdQ66NazBgAME1OoFIsmTc1Zf2k6NVGeZP6Mz64IZp6JMWtSbQGaGziPA81eB7XSVixgfQ91Am95B4vP3dEjg1DKf6Gh3y+uAQBqJOn6FzQkq1Yv2DucyHKCxCX91MPtEw3kU4sXfZXevFO79GLBu47IU9wWj000tqh+JiI9r+93ywWaqRc04tqB+rz2uDGq138QZnQnb/x5XZ3dAjM8Wh4UPhr4ivRM7AmY9bez/br5aq7BDaNJu+ncg1oOMMXWl8WIwX+o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/13/2023 4:46 AM, Sagi Shahar wrote: > From: Ackerley Tng > > vm_vaddr_alloc always allocates memory in memslot 0. This allows users > of this function to choose which memslot to allocate virtual memory > in. Nit: The patch exposes ____vm_vaddr_alloc() instead of _vm_vaddr_alloc(). > Signed-off-by: Ackerley Tng > Signed-off-by: Ryan Afranji > Signed-off-by: Sagi Shahar > --- > tools/testing/selftests/kvm/include/kvm_util_base.h | 3 +++ > tools/testing/selftests/kvm/lib/kvm_util.c | 6 +++--- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h > index efd7ae8abb20..5dbebf5cfd07 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util_base.h > +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h > @@ -561,6 +561,9 @@ void vm_mem_region_delete(struct kvm_vm *vm, uint32_t slot); > struct kvm_vcpu *__vm_vcpu_add(struct kvm_vm *vm, uint32_t vcpu_id); > void vm_populate_vaddr_bitmap(struct kvm_vm *vm); > vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min); > +vm_vaddr_t ____vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, > + vm_vaddr_t vaddr_min, vm_paddr_t paddr_min, > + uint32_t data_memslot, bool encrypt); > vm_vaddr_t vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min); > vm_vaddr_t __vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min, > enum kvm_mem_region_type type); > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 28780fa1f0f2..d024abc5379c 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -1410,9 +1410,9 @@ vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz, > * a unique set of pages, with the minimum real allocation being at least > * a page. > */ > -static vm_vaddr_t ____vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, > - vm_vaddr_t vaddr_min, vm_paddr_t paddr_min, > - uint32_t data_memslot, bool encrypt) > +vm_vaddr_t ____vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, > + vm_vaddr_t vaddr_min, vm_paddr_t paddr_min, > + uint32_t data_memslot, bool encrypt) > { > uint64_t pages = (sz >> vm->page_shift) + ((sz % vm->page_size) != 0); >