From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54CC5C433DB for ; Mon, 8 Feb 2021 17:44:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE5FF64E84 for ; Mon, 8 Feb 2021 17:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE5FF64E84 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 301ED6B0006; Mon, 8 Feb 2021 12:44:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B21F6B006C; Mon, 8 Feb 2021 12:44:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EEE66B006E; Mon, 8 Feb 2021 12:44:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 0993B6B0006 for ; Mon, 8 Feb 2021 12:44:29 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C4FD41839B992 for ; Mon, 8 Feb 2021 17:44:28 +0000 (UTC) X-FDA: 77795825016.26.sleet21_4e0b4e927600 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 9EF4A1818A921 for ; Mon, 8 Feb 2021 17:44:28 +0000 (UTC) X-HE-Tag: sleet21_4e0b4e927600 X-Filterd-Recvd-Size: 4154 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 17:44:27 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4DZD102Hn6zB09Zb; Mon, 8 Feb 2021 18:44:20 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id CNsTdCz66tzp; Mon, 8 Feb 2021 18:44:20 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4DZD101NMQzB09ZZ; Mon, 8 Feb 2021 18:44:20 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id ABEFB8B7B3; Mon, 8 Feb 2021 18:44:25 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id Xw3J-TpXLojL; Mon, 8 Feb 2021 18:44:25 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D98298B7B2; Mon, 8 Feb 2021 18:44:24 +0100 (CET) Subject: Re: [PATCH] MIPS: make userspace mapping young by default To: Andrew Morton , Thomas Bogendoerfer Cc: Huang Pei , ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Fuxin Zhang , Huacai Chen , Nicholas Piggin References: <20210204013942.8398-1-huangpei@loongson.cn> <20210204152239.GA14292@alpha.franken.de> <20210205154105.32bb13df439aa49b7fc167e7@linux-foundation.org> From: Christophe Leroy Message-ID: <30b3fcb5-a60d-228f-15d2-cd182953de45@csgroup.eu> Date: Mon, 8 Feb 2021 18:44:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210205154105.32bb13df439aa49b7fc167e7@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 06/02/2021 =C3=A0 00:41, Andrew Morton a =C3=A9crit=C2=A0: > On Thu, 4 Feb 2021 16:22:39 +0100 Thomas Bogendoerfer wrote: >=20 >> On Thu, Feb 04, 2021 at 09:39:42AM +0800, Huang Pei wrote: >>> MIPS page fault path(except huge page) takes 3 exceptions (1 TLB Miss >>> + 2 TLB Invalid), butthe second TLB Invalid exception is just >>> triggered by __update_tlb from do_page_fault writing tlb without >>> _PAGE_VALID set. With this patch, user space mapping prot is made >>> young by default (with both _PAGE_VALID and _PAGE_YOUNG set), >>> and it only take 1 TLB Miss + 1 TLB Invalid exception >>> >>> Remove pte_sw_mkyoung without polluting MM code and make page fault >>> delay of MIPS on par with other architecture >>> >>> Signed-off-by: Huang Pei >>> --- >>> arch/mips/mm/cache.c | 30 ++++++++++++++++-------------- >>> include/linux/pgtable.h | 8 -------- >>> mm/memory.c | 3 --- >>> 3 files changed, 16 insertions(+), 25 deletions(-) >> >> Acked-by: Thomas Bogendoerfer >> >> Andrew, can you take this patch through your tree ? >=20 > Sure. I'll drop Christophe's "mm/memory.c: remove pte_sw_mkyoung()" > (https://lkml.kernel.org/r/f302ef92c48d1f08a0459aaee1c568ca11213814.161= 2345700.git.christophe.leroy@csgroup.eu) > in favour of this one. >=20 Pitty. My patch was improving page faults on powerpc/32. That one is only= addressing MIPS. Any plan to take the series from Nick=20 https://patchwork.kernel.org/project/linux-mm/list/?series=3D404539 ? Christophe