From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0F9C021A4 for ; Mon, 24 Feb 2025 12:18:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5E466B007B; Mon, 24 Feb 2025 07:18:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0DC76B0089; Mon, 24 Feb 2025 07:18:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD4876B008C; Mon, 24 Feb 2025 07:18:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AF1376B007B for ; Mon, 24 Feb 2025 07:18:39 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6887280361 for ; Mon, 24 Feb 2025 12:18:39 +0000 (UTC) X-FDA: 83154741558.27.293B257 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id B72168000D for ; Mon, 24 Feb 2025 12:18:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740399517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zq8IpaMhz3nRLokE5Y6J87NVhZxZSHgDWUh5tPMsgOw=; b=crf9YhlikTwmgsdRRgv/3WawX8nF9KUi+LXLo7xQClQus2F4AoxGkFwwgoJ7CHh8Q08LOq GaOvo3QZnxPgOorfimcRGF2YLn2oNTPsl9YR7MKbsc7YCPsw1tqb57c//EAgX6vxuiGM4u dyB3jU4j+bb8JAZ3XYmTDMK8nILYKaI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740399517; a=rsa-sha256; cv=none; b=vxtDT+9aXVQaKdWM0nCqClwnySvSjQvrxtxZpxadhrjN1XKLr2+KRnR/OK7e6OdBdRLLJb INlG0/2ojpYExXNLpXwkoJqH31OR0dt5+Lo80cSzAMPBKzR6IoqoI38GW0vmTfbl9QTQkJ 7ksdXObN7r6yuncZvPtLhRRghgvu5fY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B76E61756; Mon, 24 Feb 2025 04:18:53 -0800 (PST) Received: from [10.1.27.150] (XHFQ2J9959.cambridge.arm.com [10.1.27.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D73FA3F6A8; Mon, 24 Feb 2025 04:18:34 -0800 (PST) Message-ID: <30b3ed49-1e83-40ed-8e59-f891eb416289@arm.com> Date: Mon, 24 Feb 2025 12:18:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/14] arm64/mm: Hoist barriers out of set_ptes_anysz() loop Content-Language: en-GB To: Catalin Marinas Cc: Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250217140809.1702789-1-ryan.roberts@arm.com> <20250217140809.1702789-7-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B72168000D X-Stat-Signature: wnymmj93a1wscsmysien4ptpjkrmynm8 X-Rspamd-Server: rspam03 X-HE-Tag: 1740399517-893636 X-HE-Meta: U2FsdGVkX186jJ3+sb3qWkkKivOyvBOKF8n+wpFtCEF7ZIObe4w1B33juCxdYYJIiX+XXD+/IC+re2b1rS2+2q44ahI0jFokZNSrYXX2vHXoq2gcCwCiTaqy4+90y3xwPIj4tWiyzM1qRZblaqfUG8EACrHcgzHWeJ8IEtdXwVaq08MreWfKJUvMlTvgyrZX9ZnNXPhBWYud+IJ6qpGQxKzIZufn5NFv5WvmKYS70QUp1rR6E0mPWQh3xd3AZC11RZuhACG0lenfmZLEZ61sNtTpJQ9CcSwH18gBDAeXkRCrQAQZUlwliR/z9rMAmnj2YKtk4rEtn3PfWaLAxeoRwTkr040fnDMlBqbrvl3qKOZGHKQmQtL17583Z3F+Cm22Ue6Ttv/z3gy2NsirZ9/ofNskFbOZ3QmY0XeHaIUThW15xs31prbRWbKgU3ydMPuSlosDsvr8ykIDgxgQ83JTPQmS9uAk8hmIK4MqhJDJ4TF13xgCBheyR4U3Qvrsy5txMaDw7noCTF95aA+7vngF13OOHOSJ/DSbKThtMm4Y/z+8iue12R8xHyqxAPG/tAIISxC71BWmmw0sXnl23itcGvmcv5A9SY90C83TTcD2b/EoaQl1tY7wLtBzabgoMooXSukD2t8+hxBTbsUj/UljjRIvk47xTpvG+nILJPiC9O8NVuaBY3b+fKqH+/mJTXP076iABNHyY2NhgJI/Mr3TTNxKBF8o62uKlPr5GPhvVq0Q0mRpNscEnmRIeSpgOY02SaI8HWRCnQICyWBYBJpqcUzNBVaz5wuCdFWyFdQYxEwdDnzJ5BdnPYqWFcUcFa1hS6SlemX2OO28HYKRNNMWW/MkkZWic2mIUJcepkEMLwcbZ3iNPgErgt9QAEfqWbDDrSMp6VS33qV/piqqoa5bc76AlfhVIQfmv1qdBbocnMsS1GiH0G75SRk+MmHqVRr5qlBoRfSmA1hdpfyTWwm LtZMEvbO +vsKzh0VwE3NkboQFeGcp5jPRHMPmfG2qKXtwdfbEax2LzJHI+4e8QHKbQE0PhHO1gL1f9jwP2v4v4jFulWH4rjqukQkOxsvgE/WKsQYK/ZNScglCpqhx1VrPdTlMfh8sVklq5l9RP4+pFR3fnExQfADG9dGJkM0M7NQ0Ly7gBMLccSwW7+Rn9kCVk5dMPrOGVsHK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22/02/2025 11:56, Catalin Marinas wrote: > On Mon, Feb 17, 2025 at 02:07:58PM +0000, Ryan Roberts wrote: >> diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h >> index e255a36380dc..e4b1946b261f 100644 >> --- a/arch/arm64/include/asm/pgtable.h >> +++ b/arch/arm64/include/asm/pgtable.h >> @@ -317,10 +317,8 @@ static inline void __set_pte_nosync(pte_t *ptep, pte_t pte) >> WRITE_ONCE(*ptep, pte); >> } >> >> -static inline void __set_pte(pte_t *ptep, pte_t pte) >> +static inline void __set_pte_complete(pte_t pte) >> { >> - __set_pte_nosync(ptep, pte); >> - >> /* >> * Only if the new pte is valid and kernel, otherwise TLB maintenance >> * or update_mmu_cache() have the necessary barriers. > > Unrelated to this patch but I just realised that this comment is stale, > we no longer do anything in update_mmu_cache() since commit 120798d2e7d1 > ("arm64: mm: remove dsb from update_mmu_cache"). If you respin, please > remove the update_mmu_cache() part as well. Will do! > > Thanks. >