From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712C4C43334 for ; Thu, 23 Jun 2022 00:50:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BD628E0105; Wed, 22 Jun 2022 20:50:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06C2A8E00FA; Wed, 22 Jun 2022 20:50:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E760C8E0105; Wed, 22 Jun 2022 20:50:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D3C058E00FA for ; Wed, 22 Jun 2022 20:50:34 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 20728205EC for ; Thu, 23 Jun 2022 00:50:34 +0000 (UTC) X-FDA: 79607669988.31.E7DBAE8 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 5375D40015 for ; Thu, 23 Jun 2022 00:50:32 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id d5so16776639plo.12 for ; Wed, 22 Jun 2022 17:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hCnyRyRjzk8DADp1qb3IgyvoAVy2J0edojYwRmYBh68=; b=AvJSSjxvborSxb6EJTrdIKT/iaP46rFLZqshkq+Tc9/BZG6ZjvR1RWlkoz9eKmwb+a MKQim0qrvEl7aHfugLLvia+gxjAHCZmSYRs9smWzPv5ZhQGjS+lqzulnylSG55Gh0Lf1 K2nuzQiE3eH3a11ONSogawryHGzm8DmBUdek7ax7paxg43PtICAXMi+MzzokXFlldO2+ xNWQa+xSyTFqKH0Z4s9ipHajsTGAWjRDlqRZyotRKa5C5Sb4tjNlLo18gQgXKUBZ6WWj 26F1hJci3FfoQpYImE1+WpLcKKSrXrhrJMj3nR6wbBheM10OCPt9R3Gyib41yywwdT2v F0yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hCnyRyRjzk8DADp1qb3IgyvoAVy2J0edojYwRmYBh68=; b=qF9dyRy9LdGU3Yl7yWirjB8yEkTKV8mU8vpR/UzEPw19LEud6+Mye+1CdG2MRY6U2h a2hiMlMv2LtMO00CLbQa46B+nBfurALZL8WxnXfgKOuzcPL0KKApZn5kiv6NxMaRMUHk 0SeHki1P6mJ0mrPi5cHrsuq8zbd8xpinidOTBeO/MRs5hyLILwkicjmweYWvk1W/FalQ CZfuVe69egeovAsk4BKMlZIXl5Oo90mdHK/PO26YE9GF6OQeGHB6N0384Jp2di42RnjP sd8UKkjrLreg4sm7TBaHMa+RnEXqVmPv8J7eg6/3VEPAHiwtdi1iQ7kGXY9u3wMhZqVD Fptg== X-Gm-Message-State: AJIora8lwBuTvteoFJSn0c8QuMelUzKZIh3Da63cEzSSHgwJttcF9Ybp 0lhsPx3qchLQRXlnEG1rhoH1Sw== X-Google-Smtp-Source: AGRyM1t6rtuE5DrAjHU7n06TIhxfsDwPMJVPgI3IoHgAeTiJ5hhKICpJWIetBdYDZJhK52Tj7RM7yg== X-Received: by 2002:a17:902:d4c8:b0:16a:480b:b79c with SMTP id o8-20020a170902d4c800b0016a480bb79cmr6004566plg.15.1655945431198; Wed, 22 Jun 2022 17:50:31 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id t66-20020a637845000000b004088f213f68sm14001919pgc.56.2022.06.22.17.50.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 17:50:30 -0700 (PDT) Message-ID: <30b0adb6-a5f2-b295-50d2-e182f9dc9ef0@kernel.dk> Date: Wed, 22 Jun 2022 18:50:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v9 00/14] io-uring/xfs: support async buffered writes Content-Language: en-US To: "Darrick J. Wong" Cc: linux-mm@kvack.org, kernel-team@fb.com, linux-xfs@vger.kernel.org, io-uring@vger.kernel.org, shr@fb.com, linux-fsdevel@vger.kernel.org, david@fromorbit.com, hch@infradead.org, jack@suse.cz, willy@infradead.org References: <20220616212221.2024518-1-shr@fb.com> <165593682792.161026.12974983413174964699.b4-ty@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=AvJSSjxv; dmarc=none; spf=pass (imf04.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.171 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655945432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hCnyRyRjzk8DADp1qb3IgyvoAVy2J0edojYwRmYBh68=; b=GubIDUDW9MvO81Gm/108XbjGyBqoDv2JVaCeOf4FRhgaB6uMds0OUzVc2dIrUAnD1gw/J/ JASZLK7j2wgVAX0sm5WRtTgWUHvdcURMuzFZAC9BfFCtxmSQyiGyA7s53guBb7h+q7vBaQ fZO2SO3kTBXhDamcBy7oAKRCeBXUIRw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655945432; a=rsa-sha256; cv=none; b=YINWrzj2l/HiLQWP4nE+tFTJdo1AI/7ggy5CsWcBs1DVUBNHG3KuzBEgkxBwoAxniY0OM4 VJmlDkzkKa8Qp96fo9/T6pohXKK0RjTAW6qJr0tJz7FZ8IvwAJopsMqNSOQHt9ymJv44H2 +QyD/5taDen3pA1Ejp7XwDiUHi/WZHc= X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5375D40015 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=AvJSSjxv; dmarc=none; spf=pass (imf04.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.171 as permitted sender) smtp.mailfrom=axboe@kernel.dk X-Stat-Signature: ofpc3y8f6h9ursw74xqe4g5wf31i9mid X-HE-Tag: 1655945432-768300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/22/22 6:29 PM, Darrick J. Wong wrote: > On Wed, Jun 22, 2022 at 04:27:07PM -0600, Jens Axboe wrote: >> On Thu, 16 Jun 2022 14:22:07 -0700, Stefan Roesch wrote: >>> This patch series adds support for async buffered writes when using both >>> xfs and io-uring. Currently io-uring only supports buffered writes in the >>> slow path, by processing them in the io workers. With this patch series it is >>> now possible to support buffered writes in the fast path. To be able to use >>> the fast path the required pages must be in the page cache, the required locks >>> in xfs can be granted immediately and no additional blocks need to be read >>> form disk. >>> >>> [...] >> >> Applied, thanks! >> >> [01/14] mm: Move starting of background writeback into the main balancing loop >> commit: 29c36351d61fd08a2ed50a8028a7f752401dc88a >> [02/14] mm: Move updates of dirty_exceeded into one place >> commit: a3fa4409eec3c094ad632ac1029094e061daf152 >> [03/14] mm: Add balance_dirty_pages_ratelimited_flags() function >> commit: 407619d2cef3b4d74565999a255a17cf5d559fa4 >> [04/14] iomap: Add flags parameter to iomap_page_create() >> commit: 49b5cd0830c1e9aa0f9a3717ac11a74ef23b9d4e >> [05/14] iomap: Add async buffered write support >> commit: ccb885b4392143cea1bdbd8a0f35f0e6d909b114 >> [06/14] iomap: Return -EAGAIN from iomap_write_iter() >> commit: f0f9828d64393ea2ce87bd97f033051c8d7a337f > > I'm not sure /what/ happened here, but I never received the full V9 > series, and neither did lore: > > https://lore.kernel.org/linux-fsdevel/165593682792.161026.12974983413174964699.b4-ty@kernel.dk/T/#t Huh yes, didn't even notice that it's missing a few. > As it is, I already have my hands full trying to figure out why > generic/522 reports file corruption after 20 minutes of running on > vanilla 5.19-rc3, so I don't think I'm going to get to this for a while > either. > > The v8 series looked all right to me, but ********* I hate how our > development process relies on such unreliable **** tooling. I don't Me too, and the fact that email is getting worse and worse is not making things any better... > think it's a /great/ idea to be pushing new code into -next when both > the xfs and pagecache maintainers are too busy to read the whole thing > through... but did hch actually RVB the whole thing prior to v9? Yes, hch did review the whole thing prior to v9. v9 has been pretty quiet, but even v8 didn't have a whole lot. Which is to be expected for a v9, this thing has been going for months. We're only at -rc3 right now, so I think it's fine getting it some -next exposure. It's not like it's getting pushed tomorrow, and if actual concerns arise, let's just deal with them if that's the case. I'll check in with folks before anything gets pushed certainly, I just don't think it's fair to keep stalling when there are no real objections. Nothing gets pushed unless the vested parties agree, obviously. -- Jens Axboe