From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD2AC433EF for ; Thu, 16 Jun 2022 23:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FB216B0071; Thu, 16 Jun 2022 19:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 883586B0072; Thu, 16 Jun 2022 19:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D58B6B0073; Thu, 16 Jun 2022 19:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 592286B0071 for ; Thu, 16 Jun 2022 19:07:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 27FCF35B58 for ; Thu, 16 Jun 2022 23:07:46 +0000 (UTC) X-FDA: 79585638132.02.94B4515 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by imf09.hostedemail.com (Postfix) with ESMTP id BBFB1140015 for ; Thu, 16 Jun 2022 23:07:45 +0000 (UTC) Received: by mail-il1-f182.google.com with SMTP id y17so1908306ilj.11 for ; Thu, 16 Jun 2022 16:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A/ErIrNj5gItrQCkLlcIujK6eoGjp3nC9yABjFCnK/8=; b=dqGsgNArhDuF3C4hLhzp+lhKzSPCpnjS1CN0m8V2rVj3xLISsiNjMqpGoEp0xfWG/8 QadAGuhCBY7yWgoT3uNjJMIyx0CSG/wAyOPavmcGjx6Olz6I1vG3ePcCnNArbMg1OP9Z xIDkKeBumj5d6hBpuSqw78YfEdqxBNSDGcSNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A/ErIrNj5gItrQCkLlcIujK6eoGjp3nC9yABjFCnK/8=; b=1VFTJc7vTR/QNzM3AJXOPI4OiZKQ6JDiU2T1OyBktFmwAMxmbOGlW+JQGZs+KraVuF zDxhB6stSuIr64xfO652yqqjcHDqII4S6Z4wyFUyDMiiwrdG9psVQqCWE1qTivgOTbS5 HJ6aIPjmkr2fgAJRWc5kVpRGDyAaaD0nDUOsfjaZfuPPBQYxpOUQWfg2tJ4BEFR05Lvm fSo10l6DC9ifGiaPXvIKK5+eSgw1+1u80hxl3MYtDXg/mlWLZ8FkUp+P78gsiY1tQcwt DZRdsfmCCADvbO00kC9qojNsXNyu/V+EeLftuqzylQf7/yMDldRZGpHzKXVb9bDAuCxk sd8w== X-Gm-Message-State: AJIora/ZtSmrw3r2FgWC9/JTLCdcQ1UckvMaBICH12DjggGONc8ZtKyT 6rTKFQt/HJVC5wZ4iiLJv4p3xg== X-Google-Smtp-Source: AGRyM1vwvwGPuBp7z/XIoKlWkDKMY8JnO1t3HY94c0elZo3/2d39TUYxR+t5/rxgFh1iaB+puAZQAA== X-Received: by 2002:a05:6e02:1a43:b0:2d3:cded:23dc with SMTP id u3-20020a056e021a4300b002d3cded23dcmr3942385ilv.43.1655420865020; Thu, 16 Jun 2022 16:07:45 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id z4-20020a029384000000b0032e91c1f73csm1439619jah.92.2022.06.16.16.07.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 16:07:44 -0700 (PDT) Subject: Re: [PATCH] selftests: make use of GUP_TEST_FILE macro To: Nico Pache , Joel Savitz Cc: LKML , Andrew Morton , Shuah Khan , Linux MM , linux-kselftest@vger.kernel.org, Shuah Khan References: <20220609203217.3206247-1-jsavitz@redhat.com> From: Shuah Khan Message-ID: <30ac57f2-c95b-27f3-888e-d89c125770b0@linuxfoundation.org> Date: Thu, 16 Jun 2022 17:07:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655420865; a=rsa-sha256; cv=none; b=gAiYdV6kacmrF4IY4kpoFZ9RnUZMl14EMN3+DIdLrZBErR7tDKU85znsevNQjIPZG+mfAL 8InbsKfg6aNO5Zdesg7iqhMur+K7GOWgnLN7VXIGiP1tR6O30wvpINqVpLSlJLwSx0gAxn V33Ws65odbryzxp8hn7TilS7wqeSMVY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=dqGsgNAr; spf=pass (imf09.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.182 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655420865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A/ErIrNj5gItrQCkLlcIujK6eoGjp3nC9yABjFCnK/8=; b=j1sHAbtTJPrAwSrP0m+7vAQaO3PUJZm4cq7DHs7lqerUEQf+dKXoJLK7l/f4yUaQ5XfX7J akqcdN+HRAy+QjAwe/XXwq+JEu5ONHo0N+YNGvp31kS7AzdBZlLfF4id4zevbyop5CJPui 7hWnTrhZVmNtRcEKIYB80zecOe/qP0I= X-Stat-Signature: i3oymgf5durz7tyapfgfcw3zr53gngcb X-Rspamd-Queue-Id: BBFB1140015 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=dqGsgNAr; spf=pass (imf09.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.182 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655420865-464776 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/9/22 3:50 PM, Nico Pache wrote: > LGTM! Good catch :) > > Acked-by: Nico Pache > > On Thu, Jun 9, 2022 at 4:37 PM Joel Savitz wrote: >> >> Commit 17de1e559cf1 ("selftests: clarify common error when running >> gup_test") had most of its hunks dropped due to a conflict with another >> patch accepted into Linux around the same time that implemented the same >> behavior as a subset of other changes. >> >> However, the remaining hunk defines the GUP_TEST_FILE macro without >> making use of it. This patch makes use of the macro in the two relevant >> places. >> >> Furthermore, the above mentioned commit's log message erroneously describes >> the changes that were dropped from the patch. >> >> This patch corrects the record. >> >> Fixes: 17de1e559cf1 ("selftests: clarify common error when running gup_test") >> >> Signed-off-by: Joel Savitz >> --- Applied to linux-kselftest fixes for next rc thanks, -- Shuah