From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D663E7AD77 for ; Tue, 3 Oct 2023 16:51:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D8146B0174; Tue, 3 Oct 2023 12:51:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 988836B0175; Tue, 3 Oct 2023 12:51:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84FE96B0178; Tue, 3 Oct 2023 12:51:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 75D906B0174 for ; Tue, 3 Oct 2023 12:51:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3EBB8403EA for ; Tue, 3 Oct 2023 16:51:29 +0000 (UTC) X-FDA: 81304741098.29.394BD62 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by imf11.hostedemail.com (Postfix) with ESMTP id 156D140017 for ; Tue, 3 Oct 2023 16:51:26 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Y2heZlf4; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696351887; a=rsa-sha256; cv=none; b=0AJ2TtWRzHZktiX/qHEbXgaKnDn7a4ZerH/HtJ1Fxs5zNHgshtUmNl7IiDAfQOmtMBFEGk FM9v/30rHCkwf78klmgf2zSTR3R97tTZK7M7u5Zs+6oUf2zCH4a8PbquqnQGiNRfq1uAU4 Z72E7JFtWKCPQAE++z7VrISymi9Z1PQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Y2heZlf4; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696351887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WoP3/Jfk0Z1Lt0llT34rXBYZqsDzxuvh0a8+vt2k6KY=; b=i+67zuwLnwOobKE17fcW8U8ZNKRgr06LsOJfJ0gB5dC1Uixs61/4XAhk13XVDLFfxaGqpo CANCtGB4N6yXVXObGtDbfrrz+MItP6X72DjIMr+fhPFY2LFF7jpAEt/ywmm8Zc6z6EZwjk j34pMhh7LN7htBjCCDEaLXkokp+n1us= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696351887; x=1727887887; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/AiN8Lf0vu90G463DTMPZKWFCMbDc4/B5lvdM2PPWQQ=; b=Y2heZlf4bsjA4qtlEiiObz0n6tEd7SBE5Htln+6kin7EQTFfZOL1WCWL Sa6P/gkkoAqpbuCq7uot8GO9E5ZgO+fHwAQ9zNG1nc4LuazUvr9Wr+hhM eZjget7GdRl4jOIW+X6Tfk/uyk7EEMcuBN0QKKM223JzOZUdpsoxEXceE 35pqE0H7Q9CZh/ebXusT9WYbX3OKesfvRJKTNRgqkXti2ZtBqZiFfZjiq c1p5dX1bJS9/MNjTYEkAPDunNYz3fI6AK4/sXVMmGkdytBU0v7PNeMSxR +5Jg2fNfacnZEMpYJ3qysntL5uBxc9nhkDYryc5KZqy8j4CBYdHFU9rsh Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="413835574" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="413835574" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 09:51:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="816754780" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="816754780" Received: from ddiaz-mobl4.amr.corp.intel.com (HELO [10.209.57.36]) ([10.209.57.36]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 09:51:24 -0700 Message-ID: <309e8637-c317-3bd1-fbe3-e15a4138c127@intel.com> Date: Tue, 3 Oct 2023 09:51:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v1 09/20] arm64: define VM_PKEY_BIT* for arm64 Content-Language: en-US To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, catalin.marinas@arm.com, dave.hansen@linux.intel.com, maz@kernel.org, oliver.upton@linux.dev, shuah@kernel.org, will@kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230927140123.5283-1-joey.gouly@arm.com> <20230927140123.5283-10-joey.gouly@arm.com> From: Dave Hansen In-Reply-To: <20230927140123.5283-10-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 156D140017 X-Stat-Signature: raphqscdc3eds1feczn93wpgoid5raa9 X-HE-Tag: 1696351886-745036 X-HE-Meta: U2FsdGVkX1+9uP+RCogDvmW2NWiWAsV3Ii3vdzDPWxcrw9Osfs/5lQ8EwSoceFDuF0vzPJJbu3OzNdECofnWM/BgN/fw0xZjnpJxAlQQbXjiJT0ko35GIB2fSAUEvQtYM9J1D9OTfdwqMMi9o4GR5cVDO9vKoAntxxzXtg4NizjS0cYGX6AWaVy/Es0d1R8vCBNisGBGfnouGPmLAbQypErrJgrXov27xKyVjqro8PFzC/nMtMBd+WSBO2WkNHF6NAv5mUzCqn8QYPOcD4UyoLX25gwbONj76ElfsvDr6wCYZ0S+c9duTNAhjkWFD5HZ1ImQ/7+vwcg/QbkdUiVg/5npZDf97a+MYwYT8UubXYtRjD8Pv9Evvu+pWbSbxQuzlbQBIO4s7Tm8KXyY+FzkZE99/SslDdnlbCLLe6unTCRH0xZXC+TjKw94k8ybM4oPJ0L4qZtD01jsG9qMxrBudtLln2g5/jhvR2JAuCRa11KQ11kyHdsfwr9Gqzcy1WyH1b3mjo+MqZWEtdjURRKwcr+fW6203fjyFGdAVhtcXLajVTYYxgqevC1NWGcNwcCQSIKF7qephZNbkZ2kQXMr6GrzjbfHIxBaC2cTIlED79Pyxw73gRYwQE38s+uhMogDCBkoPD/URccZ0Atzl4sn6I/XBguepLxisIBEHB+5/46DvkMkmnja0iHevhNZc8y68kIDSmtkYLH7Hp22BQ1N4ZONenWOOAg153z0Z3RA2Y64BAO7/y97kd9kQ+iHSq9BWmctq9eDIWpb7AnBGVaD7t6pf1QQXN2FAR/n01uOzaMn6bVHvAXAS+fnbjEcuO2S/x0hbq24tdy9pcIT3LaM1+TqBDxBK+H5fiBCzxYemhZd+CICQXCL6AMkdAYu68TVfjyPXQMeXfBDl+lzjc+02Dotfk+sMRp6cQq9f1DYpplfWrB0un2lKthLIKLS9BFTBf0e/p4eC0lMAfHP42P ZtOSuKso wT+AQXji8z8aEOq3+K06pvoGp0wdJ45Tt8EGHjmI+pGEU5Nh0ZGJEnnf9UtMYuqY2x6QylU7xAvZPit6MEaN90+f3wKRh1HELByJGESypJOyMzSN13Io/kCug94IVFwZydIRxr5GBNKZ9HQ6VZhRZ4Y2edStRJAz1G1JJJC9Y48oP9kP3yQr8YBBIgZd3prZGHAxO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/27/23 07:01, Joey Gouly wrote: > -#ifdef CONFIG_ARCH_HAS_PKEYS > +#if defined(CONFIG_ARCH_HAS_PKEYS) && !defined(CONFIG_ARM64) > # define VM_PKEY_SHIFT VM_HIGH_ARCH_BIT_0 > # define VM_PKEY_BIT0 VM_HIGH_ARCH_0 /* A protection key is a 4-bit value */ > # define VM_PKEY_BIT1 VM_HIGH_ARCH_1 /* on x86 and 5-bit value on ppc64 */ > @@ -341,6 +341,15 @@ extern unsigned int kobjsize(const void *objp); > #endif > #endif /* CONFIG_ARCH_HAS_PKEYS */ > > +#if defined(CONFIG_ARM64) > +# define VM_PKEY_SHIFT VM_HIGH_ARCH_BIT_2 > +# define VM_PKEY_BIT0 VM_HIGH_ARCH_2 /* A protection key is a 3-bit value on arm64 */ > +# define VM_PKEY_BIT1 VM_HIGH_ARCH_3 > +# define VM_PKEY_BIT2 VM_HIGH_ARCH_4 > +# define VM_PKEY_BIT3 0 > +# define VM_PKEY_BIT4 0 > +#endif This might be a bit cleaner to just defer out to a per-arch header. It made sense for ppc and x86 to share their copy in here, but now that a third one is around we should probably move this to actual arch/ code.