From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBAD3C83F09 for ; Tue, 8 Jul 2025 14:40:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E7FE6B02E6; Tue, 8 Jul 2025 10:40:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C0506B02E7; Tue, 8 Jul 2025 10:40:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AF356B02E8; Tue, 8 Jul 2025 10:40:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4B3EA6B02E6 for ; Tue, 8 Jul 2025 10:40:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EBB0EC066C for ; Tue, 8 Jul 2025 14:40:39 +0000 (UTC) X-FDA: 83641358598.16.CC613C6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 91C1A1A0013 for ; Tue, 8 Jul 2025 14:40:37 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GbOWK9eK; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751985637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OkhNafGrkOV7xyaO94NX8KYucK3aUTcUdxPsOzblwlM=; b=6DCzz4PMgU7Lk2x4XaF8G0eBZK/HRyD63fuRC+wVTaWjc3KIaTXroFZeN7d9Rb0xV/txU4 MHMYKX0F0H8/Vx1zkpz8oJDFVLQJ3baBekSPdbzNMcvZAWqeZySMcmzfd3DiIweLgL9Mqs vfmQwo0CI5w4bsSTqT3iROkSEo3aCbE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GbOWK9eK; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751985637; a=rsa-sha256; cv=none; b=4WRioK6xcRFl3FXKJxrpOQjsKQwM2CDCSFTl8OS8vVlbajWH9hR8l8R0UpSQ/IlKNrE3c0 FiQ3k8AE/a4QytcEyaRpm52g0EIyI/wB8uexxaiUZieMyvgy4DR2aqR9rt+AhrJ8RYuJtN /9HXyJLY1l2MT90H1mB0LYAwTVfG2QQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751985636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OkhNafGrkOV7xyaO94NX8KYucK3aUTcUdxPsOzblwlM=; b=GbOWK9eKLY1VoLsoqZsi3HNUreMKAV64eT44BO+5hw0rr/gGfNaO/ff2dZONfOJWLUUkZ1 AvYSSwtPnosocw78L062kRCoL8w7kGUQYXM7EUTRiy7q2ruDKXLD3348q5KatkYVoAXDsV N/9p/edrY+6duZwEXJAJ8JAFB5wMSC0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-P1xQZDceN1Stt126rMiA1w-1; Tue, 08 Jul 2025 10:40:35 -0400 X-MC-Unique: P1xQZDceN1Stt126rMiA1w-1 X-Mimecast-MFC-AGG-ID: P1xQZDceN1Stt126rMiA1w_1751985634 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-454acc74f22so28731085e9.2 for ; Tue, 08 Jul 2025 07:40:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751985634; x=1752590434; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OkhNafGrkOV7xyaO94NX8KYucK3aUTcUdxPsOzblwlM=; b=jYDL+eKRb6b6lxPolmPe3zS8+9TgeyKuQud0+CdDFfDAsXs3zHSzJyP6ok/xU6ORl6 PbksDPCM7jaJw95J3+a/fAipFXtaO0oYm+q/zw17sItRvOJ6MuUe005+qzO2bqeXgWCD 5DjB4sPaFD48JhXlKo1rr7LJuxeIVoTa6jLHaAaZ6V/Mhf7yQzMaS20MSTA/jDT0/mbz MgKm0+1wUxFjeuS6iTY9m2GuFHTk1Vl5GZYMm3OGHsYXTBg9S8Fy/FM5W1wjWDx4x31O yZ12hFm0Xjb68Ug6VS/o0R1qYfnlmykaZ0igr1/7F8eoG/FWzMhGCL5dANSfxKdkKbaY WI6g== X-Forwarded-Encrypted: i=1; AJvYcCXyV1qXlmih1iAmBnKxbHhMtN/PPKBb6ddWgOYi+9QmaSpeWr+JUbe5xzfo3LAH5BsncWTQSadLuA==@kvack.org X-Gm-Message-State: AOJu0YyGrr5ilSbWFctqFssGByJ7vLwz0VCavoE8mxuDQF4c+NpeZzDI t7FFZBHbtxF4xirC6UycrpivBN2eLhhDPZpPxPsRWKmLXnacGkXbjZAM+PonjBYUOii/Dk+mlTH bzk4F1nfziB5StfaWvIJU1hoSjIb1W4z5wRfLHJ5WZ2W6/likL6SY X-Gm-Gg: ASbGnct6qW8shAGOPVimgq8RyFHbiBHrW8fP01n7DiD25U4eJhU59IlaSt0cxv8/pjw ijbuGBD1bKZ4ezVNZ/8bS3qAj2zWW/32oAeLucQs3INrsqh2r/TQG0UfSrM7Ncgh3OecuCDWm1j NyES+UyZ7GTzKsKzcrmaFuBQ4+HxOVNf5eG/tUHzwLB0mdJicph2XKPK+4OBpIz46IWRrfFvHyT ECObQIWjGg4hfU5UyZ+HnQ2GeX1Q4y21uAh+a3388aq96/6i9E1OsIuLnoL23NWvXpNSTiXHeQQ RqV9kcEMEOfAR2uYCKkoP/Mo1WIkNglZW87/7OUrgV3AdNqj7V0kwWuX9cVnxDp+vgZq/ByNbws +Yb6zViaf7++FpYEVFPcWP+qfm3NRK22CICTm0pMugncyPBW/6w== X-Received: by 2002:a05:600c:4e05:b0:43d:2313:7b49 with SMTP id 5b1f17b1804b1-454cd4cbd79mr34231005e9.12.1751985634177; Tue, 08 Jul 2025 07:40:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7704N8AonHRhmAKpslFBnCYzTFDT1HqGSr8qtxRp4vTBOvWbadg3iV4yJ5Tan3/eZLUOHRA== X-Received: by 2002:a05:600c:4e05:b0:43d:2313:7b49 with SMTP id 5b1f17b1804b1-454cd4cbd79mr34230645e9.12.1751985633696; Tue, 08 Jul 2025 07:40:33 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:f500:4346:f17c:2bde:808c? (p200300d82f1af5004346f17c2bde808c.dip0.t-ipconnect.de. [2003:d8:2f1a:f500:4346:f17c:2bde:808c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454cd43cfe3sm24671795e9.2.2025.07.08.07.40.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 07:40:33 -0700 (PDT) Message-ID: <3098c728-c4a7-4559-8213-2bca7971fda7@redhat.com> Date: Tue, 8 Jul 2025 16:40:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 05/11] mm/memory/fault: Add support for zone device THP fault handling To: Balbir Singh , linux-mm@kvack.org, akpm@linux-foundation.org Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Shuah Khan , Barry Song , Baolin Wang , Ryan Roberts , Matthew Wilcox , Peter Xu , Zi Yan , Kefeng Wang , Jane Chu , Alistair Popple , Donet Tom References: <20250306044239.3874247-1-balbirs@nvidia.com> <20250306044239.3874247-6-balbirs@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250306044239.3874247-6-balbirs@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: H80Q9VYBq5tNzuF0ZyWdrrQSF0cZc-Uoxgxz1d289c8_1751985634 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 91C1A1A0013 X-Rspamd-Server: rspam09 X-Stat-Signature: e8d9b31rqmzqpq53tuk6xpdzgwwgq87f X-HE-Tag: 1751985637-886305 X-HE-Meta: U2FsdGVkX19+tZmBQOuhJkSiz6Pv+TjmDf7jInlu9vA3uXBccriB/6mYKh4/Cd+O3WWILx6DDV37kWBsO/nFoviguObNzeFXfu4YQlZRoWWq/YrBWGxeJy1/DwmR2PeoutpdetfJQGAmlZA7VlxfC+Dzw1BTXIdW0N90cnS6xE6hhz+zMWaIGdGacKnJXwbaX8Q4I8ZpsJ0LrLSQNALDznEhBhYtLl6i9f/7u8wXjuSVYbm9TXkqUdgdfWK0mGUL9HeqxpnaspyPGtnMO935epQFqRpKY1UBbvK9imRDq1ocQe8/DHRN8ZC95vrPqKLRuemO1EQQKw6dc1NttE8hd94CPjXnT0tzOac4+iZ8ZNTEnR5Dn1PAsXW6GCSDLsn4F+WHtxighmGkdi3D8wEaP+a9XAv7oIKebH2r7I1IrNmULohCmgBikbsZ9e5kerHA8MkwEwbIZuR/7JGUOob51Alh/ND0kglvycX3lWdDpnRLbgxbIrkGfqf3SjFqlCMBcSX1U2Pg5w6ot8c5yKoJZq//Jjb9NNoeOopUdveUvzWKIUVZ+/AHPfYObDCki0IvrVnbsLRnwPUJLiJQ5arRVfZKZNv6O1OVRdZSJCoUAiLyCuf/Z3jt9vkcwXbwWS1qwL1BEAu0oOt1O34NCuPKshCb/+AdowaXkJ4ctppudTNqz1ukgS578diPPMK0n2TW2HO4TtYbo00dDv05vW7kupG+mnqrylQELhXMa1v4L8DQThCR3qMLpOqREELzC7MxqmdDeDJACOfqD0KkUdVOAU1Z5NuQNmtF73QQnyaI1S9O7zRPHidGBs5haVqXz6jmF0YhC5DtzFf75yeJ/fh5z4RM44FPxRKgcpmKJClpV87f50zXvxOrWKnndTtqg7BLMQNmjIJXADkfTzMbI/vFegd5bURT2MAnFjXA/bbxvktPysagYnT0MY0UlenT70M6+z5RvxN/q/KrJjt+0Wp DLkBbBAm dHoqp0CzZYgdwdg00udCUPxgvhUbatRyJVR8qxNWGKv47qH59UK6IIOxbgAGXnZD0ApaAhrBskREalTj61g+3Zgn1o4kZO3AFYMB4gRArNsrjbyx16xmtUQDtTDAkpPwH5PI/f/d5ILwdPiN6Agvg2RDq4Rj8ymShHA9Rk2UhkdSWUbZEZY6BJJqD3y39vpN5uDCz3+Xgyq/SIQsv5V8emK+9xfU6I8J4hvDnNyARMrGkw7SwWCeTOmBqqvKZ7FDOffQhDpbLmhx/YTDGqrZwQdwDy9CvrgaJEt/rONkB7kwJOGHo68AeyhJYv2Wi9ncE0wtF14Q8ZAZmtSA1qf77Nc6lMHdItcp8bLLc/98Oc3XGt37rVQCqYYGwCpLrzB/JjjJldSuuS59is6rmR0rDjzPPLNpYqOjuXoq1AXUc2INnW3+rnjS/27Il+kxtPk3UZ89otO75Hq1a4f8l+1Vbtv9OL678OonGSSGnL+ZVhH1SnuNrxN4WTqGzC77bpqr9LH4U8ZFFCqa0pPo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.03.25 05:42, Balbir Singh wrote: > When the CPU touches a zone device THP entry, the data needs to > be migrated back to the CPU, call migrate_to_ram() on these pages > via do_huge_pmd_device_private() fault handling helper. > > Signed-off-by: Balbir Singh > --- > include/linux/huge_mm.h | 7 +++++++ > mm/huge_memory.c | 35 +++++++++++++++++++++++++++++++++++ > mm/memory.c | 6 ++++-- > 3 files changed, 46 insertions(+), 2 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index e893d546a49f..ad0c0ccfcbc2 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -479,6 +479,8 @@ struct page *follow_devmap_pmd(struct vm_area_struct *vma, unsigned long addr, > > vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf); > > +vm_fault_t do_huge_pmd_device_private(struct vm_fault *vmf); > + > extern struct folio *huge_zero_folio; > extern unsigned long huge_zero_pfn; > > @@ -634,6 +636,11 @@ static inline vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) > return 0; > } > > +static inline vm_fault_t do_huge_pmd_device_private(struct vm_fault *vmf) > +{ > + return 0; > +} > + > static inline bool is_huge_zero_folio(const struct folio *folio) > { > return false; > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d8e018d1bdbd..995ac8be5709 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1375,6 +1375,41 @@ vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf) > return __do_huge_pmd_anonymous_page(vmf); > } > > +vm_fault_t do_huge_pmd_device_private(struct vm_fault *vmf) > +{ > + struct vm_area_struct *vma = vmf->vma; > + unsigned long haddr = vmf->address & HPAGE_PMD_MASK; > + vm_fault_t ret; > + spinlock_t *ptl; > + swp_entry_t swp_entry; > + struct page *page; > + > + if (!thp_vma_suitable_order(vma, haddr, PMD_ORDER)) > + return VM_FAULT_FALLBACK; I'm confused. Why is that required when we already have a PMD entry? Apart from that, nothing jumped at me. -- Cheers, David / dhildenb