From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C424FC001B0 for ; Tue, 8 Aug 2023 03:08:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B8506B0071; Mon, 7 Aug 2023 23:08:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2661F6B0074; Mon, 7 Aug 2023 23:08:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12D9F8D0001; Mon, 7 Aug 2023 23:08:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0021A6B0071 for ; Mon, 7 Aug 2023 23:08:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BD7ECC0128 for ; Tue, 8 Aug 2023 03:08:44 +0000 (UTC) X-FDA: 81099454968.21.508090A Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf28.hostedemail.com (Postfix) with ESMTP id 22AD8C0005 for ; Tue, 8 Aug 2023 03:08:41 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691464123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fjfo9D6nlzH1RkU+wsZpqy+hOVlYaqgLE5ihFcXnnQA=; b=AaUAba0AGXxluYvr9kwiLMKBKKUQidnoSqRUYl24o5pC9ozQ5ukV6fdGNBA1tMDtD43gd4 NHmFdQHZaZSVd4uetXNNSnXMdi8PqGOL1V33OwoHB071oHdLWi3r6Hp4JRsNGqmOx5oZ6W 9fDCSVWbO5qUoLBDUhAU+kJ6KtxFjXM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691464123; a=rsa-sha256; cv=none; b=ypw3/1e7flsOZIQVG9Ll1Z1yFW0k7/dVGA6qFd7DqABoq98J4Sirj9autzRJeLBxJEA0xZ oYySrrTZIj6H0YpWWQ/Y/x07a2A9Tnuz5eyN1JqeLUJ/tX3Y4NkWMEA2PzR//5dzdPYU2/ swyhm3iEca1hocu/xmSWcu10niKNpoo= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RKdN53LLxzNmsy; Tue, 8 Aug 2023 11:05:09 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 11:08:37 +0800 Subject: Re: [PATCH] mm: remove unneeded __meminit annotation To: Matthew Wilcox CC: , , References: <20230808015831.608454-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <308f326d-c7ae-be49-22af-189a81a89aa2@huawei.com> Date: Tue, 8 Aug 2023 11:08:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 22AD8C0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: x1hnuq8n49ompjr1nfodn7hbpr7tmntf X-HE-Tag: 1691464121-608136 X-HE-Meta: U2FsdGVkX1+S0iz9j+2InmCn3wHTEJsLe5wSz01RO6TAj3UOKTVJK5VDGPmDgjeBXwr+1ujXD+UWfUQfZnTBHCQOifTjY2qL62BsH9rJjECMnFV86v//Xb5w3ca/aoYYGsxCUkNMwtP2ONKJdukbMnkNd2aeYrcdBSdN35UCXtxTuWfwXk18HTPIaofbM8YiLAtmGabHmNpLHSqORPpYxCOdp8AKpOK8gSJHj5iNbblWbYyfmzJBNxJgMyI46Wh0m+GYp5Xa+mEUb+/UIkuQ0BuggvnlSG0ksi2VtWxNwcQESV7C0FGTGo8f9qxSHciANYarUcq6FE6emyA9eEZfz0nxi37g4kTeDlEgjBwW9zf/GB/hE+J+mPdQmSTLBr93z7fFVmztQ3ZpYD/VS+WbS94sKociMIfKFcILHVfVguGi8tcLFbhs8pbHkucT2vsbu+7szrQ4WNBCs+wqVTqT0Ocuwui6ilmuz/LyiNCSYClopz4cLzD5TPKwYZ2tUg3+gyC2EQTwiJJmcHspcbDpzV81wFUPGpsQBn1yOd/1wGz/7OavP6YbQW+PjAt4ugQ1Gk/38Zz4B09nYDmoAzLpsvNJXzJ5IL0WHW9n/rqs4CsXmxlMJFwq+9DN2ywntpbwwH1tLRuwBuAiwI3A2UzEsSGeeQerCK8gWfWagSoiHUzaqZF0O4WrDDQVT7UQV6JfNA5ulRKTRa0QMNpLC7ZOZ8PLjcxiYXg134iAyvxzZh1zZQxxhUslvgnvof3tgLV/q5BaMZzGIY2vQRTvH2BErKW1BnCAn/E3fUcqhjay+7CvwTmANdL1arxMgFCv593rE2qwq0/JpVuP7/a9d3pSaT78IwZL5Fc4/c9W3lVtbZzgIpfPUznBOsf65p8beV2WHI4FJD8MD1Yya+LSfpfIJj+7BBY67awQUV9IwJEkJyxJHcfJNG5v6rz7R24EK5GwbRYaOb/vAgSnI2KbLxZ vu1uJZ30 6gryUQzFHRR2rQ1QdZHbAzRAOiUzxPbFgIZdS4SU3meQPhdRRhvgYir6xeQZ3ux3zi4/QKC24KNrwS1sHc9xPyRbvdQQr8BZtHDzeX490yA0ZS0BaP27FYZbOQqrj4KQLoq4d0p4vFcR9Vf7acTbzMB0LppcuuIgmbenvHT2IA10aPP4oESlWBby8yg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/8 10:31, Matthew Wilcox wrote: > On Tue, Aug 08, 2023 at 09:58:31AM +0800, Miaohe Lin wrote: >> kswapd_stop() and kcompactd_stop() are only called when MEMORY_HOTREMOVE >> is enabled. So wrap them under CONFIG_MEMORY_HOTREMOVE and further remove >> __meminit annotation. No functional change intended. > > I don't understand why this is an improvement. If CONFIG_MEMORY_HOTREMOVE > is disabled, the linker drops this section (... right?) If it's enabled, When CONFIG_MEMORY_HOTREMOVE is disabled, without this patch: size mm/compaction.o text data bss dec hex filename 103164 30873 0 134037 20b95 mm/compaction.o size mm/vmscan.o text data bss dec hex filename 158775 49612 64 208451 32e43 mm/vmscan.o while with this patch: size mm/compaction.o text data bss dec hex filename 102915 30865 0 133780 20a94 mm/compaction.o size mm/vmscan.o text data bss dec hex filename 158534 49604 64 208202 32d4a mm/vmscan.o We can reduce each .o by ~250 bytes. > then it gets shunted off into a cold section. So it seems like this > patch strictly makes things worse. But maybe I misunderstood. What about add __cold annotation? Something like: diff --git a/mm/vmscan.c b/mm/vmscan.c index eb4db273bf7e..e27ffa22c70f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -7902,7 +7902,7 @@ void __meminit kswapd_run(int nid) * Called by memory hotplug when all memory in a node is offlined. Caller must * be holding mem_hotplug_begin/done(). */ -void kswapd_stop(int nid) +void __cold kswapd_stop(int nid) { pg_data_t *pgdat = NODE_DATA(nid); struct task_struct *kswapd; Thanks.