From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53]) by kanga.kvack.org (Postfix) with ESMTP id EED8C6B0035 for ; Tue, 13 May 2014 12:06:48 -0400 (EDT) Received: by mail-ee0-f53.google.com with SMTP id c13so564815eek.26 for ; Tue, 13 May 2014 09:06:48 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id l44si13538811eem.13.2014.05.13.09.06.46 for ; Tue, 13 May 2014 09:06:47 -0700 (PDT) In-Reply-To: <20140501123738.3e64b2d2@notabene.brown> References: <20140501123738.3e64b2d2@notabene.brown> Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions. From: David Howells Date: Tue, 13 May 2014 17:06:10 +0100 Message-ID: <30769.1399997170@warthog.procyon.org.uk> Sender: owner-linux-mm@kvack.org List-ID: To: NeilBrown Cc: dhowells@redhat.com, Peter Zijlstra , Oleg Nesterov , Steven Whitehouse , dm-devel@redhat.com, Chris Mason , Josef Bacik , Steve French , Theodore Ts'o , Trond Myklebust , Ingo Molnar , Andrew Morton , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org NeilBrown wrote: > The wait_on_bit() call in __fscache_wait_on_invalidate() was ambiguous > as it specified TASK_UNINTERRUPTIBLE but used > fscache_wait_bit_interruptible as an action function. > As any error return is never checked I assumed that 'uninterruptible' > was correct. Bug. It should be uninterruptible in both places. David -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org