From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB46EB64D7 for ; Mon, 26 Jun 2023 15:12:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 045048D0005; Mon, 26 Jun 2023 11:12:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0FE78D0001; Mon, 26 Jun 2023 11:12:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8A8D8D0005; Mon, 26 Jun 2023 11:12:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C47B08D0001 for ; Mon, 26 Jun 2023 11:12:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9C073A0450 for ; Mon, 26 Jun 2023 15:12:49 +0000 (UTC) X-FDA: 80945241258.05.C481BA1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 9DEBF140028 for ; Mon, 26 Jun 2023 15:12:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="HR/mAtQE"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687792345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z1slXFtt+G0ex6dm14v502Z751krJvUwrnDBAKAckFY=; b=bfor6jilgvqL01YAXLMK0MelgWAWXYN+mO7++Vh5XmwiClfnmaB/IrDvmViMveU2EPBLDB GpDwx7efb2sAZCX+q3lUeLlf6LVfZjGK5/x73Xtj3lFLHYNJil2WdbCE7wVdGjjHVkaNEb BceVMOKb4GM65n2WJsYjlX9Rac6Ndms= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="HR/mAtQE"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687792345; a=rsa-sha256; cv=none; b=fVqEddCXXOoBSapuINl3wLMbkaJEveRGA+Q9d5fPLrSWHK00qSk8XOlUwEOhiSxApKRmED yUJ05xiQ3MtzW+ErJKVGonKPzrTAus8NhXqI/b/KPB8DK7tR2t28+uH+X+7AZMIh+25He6 IoWj0DLA5PISmzqJoiFDW/VbcXCcEPs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687792344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z1slXFtt+G0ex6dm14v502Z751krJvUwrnDBAKAckFY=; b=HR/mAtQE46+zJ1gtS04FMo5dOKOswVbCDyMBM4/FVvTYNtK0vxQIiMYBUm5N25KDDwzECp tpHymXnWTyiikgoTXN654BQIVjnKndqWc6hRc9nrORGbswnjOJVEvDxy/OSjgeEE3vhZGQ VgqizLcMm7J93DKOd7lMnFxAx+6nbU0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-440-Nl8n0UMiMmuAUl-8QQKKKg-1; Mon, 26 Jun 2023 11:12:19 -0400 X-MC-Unique: Nl8n0UMiMmuAUl-8QQKKKg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80E0985A58A; Mon, 26 Jun 2023 15:12:14 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5A7D40C6F5A; Mon, 26 Jun 2023 15:12:12 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230623225513.2732256-1-dhowells@redhat.com> <20230623225513.2732256-4-dhowells@redhat.com> To: Ilya Dryomov Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org Subject: Re: [PATCH net-next v5 03/16] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3070679.1687792331.1@warthog.procyon.org.uk> Date: Mon, 26 Jun 2023 16:12:11 +0100 Message-ID: <3070680.1687792331@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspamd-Queue-Id: 9DEBF140028 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: aq5afbiaorw33z8iqjogrrxj4oxjnwx8 X-HE-Tag: 1687792345-317996 X-HE-Meta: U2FsdGVkX1/gl97Ii9p6eejab9EAgVnNDZ/dijphuT2AWBGbgeAkHtqapJ9UNgmQnhfkjBWE0bxbyBMcwsVLCyn5hmHq/yVjDCpwDxWsELriL90a7Kb8L3i4zh2O4eqvmTQaTBeTVFnLBx65/NgeVUFYjE0ITdcc4FlWa+piu7Tw7cxsdnwuDL655ILndjht+l3gXjAm0i/xdlJoxvHa0nnoxuGMIBsoSgXI10ULoHJr8t2zc6QpoCuJYFq77+21uRM8lmP/tbBrK6JjgZ8U+/ET+XFHb1+ZWclorvfwHjo05iHyiOSk/n2dIkQByJUEhQggoLDPZIrNOfCSKt1ViqOwA2a4KsCvwJvHi5hSVyLCB/OPr4O4x5ZZuBxZjz3nc2sdi3krQc9g2lCVvuNSTJgxEL1U7Qyopth9MfR9SWACekWB2LV0fLVq31ArWrW7KQ6LDZDwLGNefwPEnkqzvjTLYVivtBCPetAsAPudwmhEowZAR+b3h6xhilb6V8y4qoIdUPn0o4ZUQL4Ryoi2DzmNp5EFm9HYoimVsbNHeYsgkVPn4jJAITZhp57vkEQSFEc1p4L2o/lWzuXTo3QYU/9hDiyV4d9iOUilX1odTd2uTv25CfkEM4A8wlUMKUuoUCigrr++GvBSNwSgieVtBIxaQjH0PiG/SGGRfGRg+15HC8P1Bza4Az4oxIug1S7mthS9f7Tz0royGfRqgGji2EVNOQKgiJjCJlpyiR4DpnNnOyR8uxGzkSLgoI6kh46Vq/hvalcISG9uclZflhN/SyfmC9iO1KqIsPeAyFpoPXMA4VrPOAZXyhhSFpjhcOMhhAGqrOPI61MSDFWKNjGYBpi0tu6a9+wrfLOqjE8YnmWmKxnTz6So6npEIHuUSN8oi3+X7voHUQ9BnQdoAlX+h1eMrfFb2qWumFv8eTTCybtKz7p4DKvfXCX85jP9HEEeWhh5xpl68xO4IeYm1TP w3dc1Gxk HykY6dLWS8dLgdJYKSEK/ko6iR/fHW6Q4MEzug7q5lB0nOoNc86sZiOkPC+aD4VCg5AbH105gJ+VFTxHHfJC22fqT64lGBjrrPtz1xIO2Rj+TZ4kOsDtZoIdj61yE7KvIlW849wFOIUvPm9SUtLJemqWFT0B7+T8gvBs20Wsjv7DqTALpNNE0Xq7+sgEKKeBYIVRRLQKD0ZB/WtvVyrMEfk1bg3cdhz2smPqbZKcpBxFpZjDcbAIw6GReG03cyPWepinGD/WNt5blTrURCElJ/IaVT2HzSBKyUscWuw+Mwmvhryk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ilya Dryomov wrote: > > - int flags = MSG_DONTWAIT | MSG_NOSIGNAL | more; Btw, why are you setting MSG_DONTWAIT? If you're in the middle of transmitting a message on a TCP socket, surely you can't just switch to transmitting a different message on the same socket without doing some sort of reframing? David