From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503E9C04FFE for ; Mon, 6 May 2024 00:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FB626B007B; Sun, 5 May 2024 20:29:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AB4E6B0082; Sun, 5 May 2024 20:29:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 324FA6B0083; Sun, 5 May 2024 20:29:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 178A16B007B for ; Sun, 5 May 2024 20:29:25 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AFB11C05CE for ; Mon, 6 May 2024 00:29:24 +0000 (UTC) X-FDA: 82086087048.16.672775C Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf22.hostedemail.com (Postfix) with ESMTP id B0D03C0007 for ; Mon, 6 May 2024 00:29:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=davidwei-uk.20230601.gappssmtp.com header.s=20230601 header.b="JgCIjBB/"; dmarc=none; spf=none (imf22.hostedemail.com: domain of dw@davidwei.uk has no SPF policy when checking 209.85.215.181) smtp.mailfrom=dw@davidwei.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714955362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sTixdwfAlIVssw/yTwe1uZ1trqj6K9Ho7zGTIsCsG3k=; b=iocBgvG1BnIfgpZi+K5ArQSxFWtlP0m676pmbaPDCMfOereiU9YPG+HcyPvj9IJLZw+LHc ZhkJLd0Pmp0UzaIDVF8DF2Yhgl3gn4dqUrZhOWwpACKcZ9cKkQPoJYgIlLB3rVV/YjB8Ml mtwIgPoCh1zYEOphDf3fllWsFattlgw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=davidwei-uk.20230601.gappssmtp.com header.s=20230601 header.b="JgCIjBB/"; dmarc=none; spf=none (imf22.hostedemail.com: domain of dw@davidwei.uk has no SPF policy when checking 209.85.215.181) smtp.mailfrom=dw@davidwei.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714955362; a=rsa-sha256; cv=none; b=ODGzc20nI3fSbcsQeWct/Lqt2qR8Hl1VzHQCagwW2r1S7N40k/qArUs2mBtGpwE5UWvK29 GqC1LI5zho6FMfOOCtq/nA+qGKnPX/5/aQVZIR0r5pluZ9DZOE4GdyNaVVwkxEvb5klhUK W7uy/7hJvozVVfzzbGkDTXhEJvEbRJk= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5f80aa2d4a3so893858a12.0 for ; Sun, 05 May 2024 17:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=davidwei-uk.20230601.gappssmtp.com; s=20230601; t=1714955361; x=1715560161; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sTixdwfAlIVssw/yTwe1uZ1trqj6K9Ho7zGTIsCsG3k=; b=JgCIjBB/6iCG5CorcrAYufu8F+ssp/BzFTNhjPJqqK7H95qXr2KF1E9vrttZetHKaK y6KAgEb3gZhNhumLbvtPFeOMOKaarPkT7fj7eZRR9PVYFs7MpF6xowmv0JwvS3TtkcXg HyBe408lEdIKF5Ggl8LzYa1VvOtei6w30n8SwIV4IXSzam0i/BRK3c67kMqO/JBMkFP+ pCCBOW+go/CppnYqU6B0f89sJJcG26pskPUfr84j/mzLtah/JjBOrCm8Tc43KwZLK9JL JUc7yMGuEYY08eWQm10nc190B4Wwk5g9dBPTHKoHh8qLoi7oLJZI0hNtoFiWTtzOhVbu AW4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714955361; x=1715560161; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sTixdwfAlIVssw/yTwe1uZ1trqj6K9Ho7zGTIsCsG3k=; b=q9uNlHdjThktWceeH92FDuFD2o14hZeb4k+ZeDw4/zFuzqiwjxBux82DEOoa27gDbN lRLSp63V+V5jqEI1JG4UutplVbQHsYrtoHmcsbS9LkqUGve7p+zNyt/M854V/JR7h6Fp esVTclm20W1LBSi/gK2ffye7P8TBK0vkARTOCpa7kAJbmKzkkSEzVECALJCbFapOmys+ cGiJfbJzU7+5i3HUWRTWwDezToF3c9/mMyYbk6sCzz1TW7mORfzV+u2hbvkuDsdilAT3 WBwjNeGwbXgtLZtnS+TtAwewZ4q49ip8WCu8g1YMyN1HiK/S+wSX/5B9XoxDSyvLOKxp 8LZw== X-Forwarded-Encrypted: i=1; AJvYcCWIMm5ia3wKHFQzssSwO/vT960VxEfd2+TGQ521wvLqymobv3Q0SrEIXnjy4in8zmSHD5TvQfvAnf9N1Pu2ltVgZ9k= X-Gm-Message-State: AOJu0YxR0cQJPgm9pggSv+aWPAI+YDlDKSeI96q/UviN7Xisc0VzGBkC rcySN4k9EyJw7L4l/rF6n1mHdzmfVvF8vlUIzQkG4GhHuM88rcl1EcjVHPI06hg= X-Google-Smtp-Source: AGHT+IFapiyynwMzWBFC3qoHSlJe6Vp0gcSIQLTrnjL4T2m4HyoHAt77UaMOEYoyby7VMZX56YX6rQ== X-Received: by 2002:a17:90a:d30a:b0:2aa:c2ba:3758 with SMTP id p10-20020a17090ad30a00b002aac2ba3758mr8212757pju.42.1714955361360; Sun, 05 May 2024 17:29:21 -0700 (PDT) Received: from [192.168.1.15] (174-21-160-85.tukw.qwest.net. [174.21.160.85]) by smtp.gmail.com with ESMTPSA id h4-20020a17090a710400b002b1314ba8c0sm8708252pjk.57.2024.05.05.17.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 May 2024 17:29:20 -0700 (PDT) Message-ID: <306cf793-6f96-4a22-aca0-53c0ccefc0a1@davidwei.uk> Date: Sun, 5 May 2024 17:29:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support Content-Language: en-GB To: Christoph Hellwig Cc: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Amritha Nambiar , Maciej Fijalkowski , Alexander Mikhalitsyn , Kaiyuan Zhang , Christian Brauner , Simon Horman , David Howells , Florian Westphal , Yunsheng Lin , Kuniyuki Iwashima , Jens Axboe , Arseniy Krasnov , Aleksander Lobakin , Michael Lass , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Richard Gobert , Sridhar Samudrala , Xuan Zhuo , Johannes Berg , Abel Wu , Breno Leitao , Pavel Begunkov , Jason Gunthorpe , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox References: <20240403002053.2376017-1-almasrymina@google.com> <20240403002053.2376017-8-almasrymina@google.com> <8357256a-f0e9-4640-8fec-23341fc607db@davidwei.uk> From: David Wei In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B0D03C0007 X-Stat-Signature: r78mjp4nauseofs9mr4nrdt4ehyfcj4u X-HE-Tag: 1714955362-903598 X-HE-Meta: U2FsdGVkX19zYlov738jIOu5FuPWDVX4Y9QBJJho+yiYmxwQazLdahpKYiqRwmUYOFZQpsOL6a3ntu5U3pqcNnzaoRSOypVvRTKUwoG02ksHmEi2eF1jVuPNBEdxSH0pF4CG8T8O95BT03pwkXdE9C2JRYV+NTmJG/rQCqXe5T0tWrUhw1rP/Viip3yxmB3RXQuEoe87b6rfxmf1Op7pu8FOgPAm9n1sEkcR2DUkl6W8XJJK3z91wlsKe8uTCYV+icAx0YdYqpF4FbCXHJRDKD9q625mrOa2V5c1kIXIqbTcRoKP5AcAUtJnckMV3EUFo34VmFaw903BQ+IbRNIZIdt77O6tMOLOcDzv/UDnNhJka5gEkpuwAegd06hvj2J0/XiaxK7kytN8NGgOE0rxYF+TqmySnxtMtYte+XA96sPPiLkWaeT1s2egfVPojQNQugIGfV/PlKsMXkpdbSz8QJlFIG64yJxTAwouI/YWVbM5+0KYB22tHssyCzrjU5JKdQhJ+zVeExiTg4uTMMFYYY+qoEYy3B7q5XKQkV4twUlA6ZsJk9Qc5Z/tPiRO4DOB6+BiPQdSEJSP4yrlFTZZeaI0dsSwE+7p6lDTgynHKQw6huJ0RUX7L6xdTFHf1Ygbgzyf6TBaJeWthiG/lUZL4xWa8blbRr4ZSQl8Ugqsf/NQqpxUeuNsq6tlwLO3lbsx9LLFtGYdJbs57xHBUF7ZbdP7ghbQrQxLgU7R9GxrTFMDBU36VJcig+FbE/cSsysIG+2eY11pBHXV96ONbtZsPEcp2uySc3eg/Ta3wKWxfZppCQMj8iy35vPe0iXECKYsVE+s6EUTl7ckAeBfPQ3Wt8cqOtAmjXxqO/NGf/KprpyuwiyfkKHIlVCdHH24lCIFN/ao4D3ylpKY4D6jZ5ni/4PJ2DV6+jzQZ9rYdcKVfzpOp4+EgwwkhYacQcEBG8DsLwyOGJiNm0e6UVtNddb Oa79Ftgi 1zYg8j//VZ9hLdnFZNjZfUKYETN3sJG2bBYm+btr3T1Jyquq67Hin79TajEbKU5w62yX+Dp/DGn4wMeVyHaxtTlWfOpR+wzD4bd+Kghi6iiovy3J8VCeC5W5GpndfYC+6G433WVDbjTbcksF6ibbbNZ4kHGFxyLKopm5XWTJhMEDZedNB6SHPNdnulwRlPF02nokUESaGDrbVxTcIBy365RbNsukLC61Z9gmxd749xwE+ctz/gj5AySB11W7Ao9qTiWVDalXHWwAVJ/QuAWSxO5kJy18FMy2KKKcs5KHxwCTcx/WkFd2A4oj0hV6hF+K0rYY1fZbV6bTZyLQ/GFUl7xcfOHkWB6vC5W0jKcRIH2icQrEQdtmVvhqn7EIGYbaTVTDbbl6/TpmNBZkIDJCEmjEDr5GqvySg5L/vcMrolkUUTK/mIDT1sJAmIS3V+wNf8hScV4TEoGF4myLPjGpvGlq3X0Y0AwDG6Q57lJub0wETFHx7YpeMLqxU1elb6LkdQOKFhtY4AFIWZJmQ4VJrlywFpA+KRlpM549g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-05-01 00:55, Christoph Hellwig wrote: > On Fri, Apr 26, 2024 at 05:17:52PM -0700, David Wei wrote: >> On 2024-04-02 5:20 pm, Mina Almasry wrote: >>> @@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov) >>> */ >>> typedef unsigned long __bitwise netmem_ref; >>> >>> +static inline bool netmem_is_net_iov(const netmem_ref netmem) >>> +{ >>> +#if defined(CONFIG_PAGE_POOL) && defined(CONFIG_DMA_SHARED_BUFFER) >> >> I am guessing you added this to try and speed up the fast path? It's >> overly restrictive for us since we do not need dmabuf necessarily. I >> spent a bit too much time wondering why things aren't working only to >> find this :( > > So what else do you need? I was assured last round that nothing but > dmabuf and potentially the huge page case (that really just is the page > provider) would get added. I'm using userspace memory so having this gated behind CONFIG_DMA_SHARED_BUFFER doesn't make sense for us. > >> > ---end quoted text---