From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C51B5C30658 for ; Tue, 25 Jun 2024 12:41:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31DBB6B0301; Tue, 25 Jun 2024 08:41:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CD626B0302; Tue, 25 Jun 2024 08:41:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BC3D6B0305; Tue, 25 Jun 2024 08:41:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F27C16B0301 for ; Tue, 25 Jun 2024 08:41:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 992F1A42F7 for ; Tue, 25 Jun 2024 12:41:11 +0000 (UTC) X-FDA: 82269371142.14.D32CB45 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 8B2A9120006 for ; Tue, 25 Jun 2024 12:41:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719319256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9CcLCOccFhfBPz2VhaI307IjIn69/hoFG5OuPLpt8TM=; b=j1PBXO8bwvwve1wO6bnWKS9vesc6bnKthcxMYyg10/xMJ26C1mnLSa5lK1RAisHLIakz02 3qkhrovq7Ax51odmCcq+F+mKj+3zfl59OPRq3wWyGxN6qk0yYWZISEm5ZJGvZFTU6/IJV8 jvhWD5gt7dZcxhExcKD6YMR8PO9V/JQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719319256; a=rsa-sha256; cv=none; b=0KdD8v80IeipW776q4pcojwSJJMR1QltWo67a8m8W3JDqTQP93/sPOxluTWaN2ONqE+VD1 GtRhaK8TEABkomIk/kdyYZlvS4uvRpM9qISYoNefFzW2JW/cbteAZBjEiHYSkEZgayRqcn qk8/zzQcTWrPURo7WF69rOzuD4sBL2M= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50EFA339; Tue, 25 Jun 2024 05:41:33 -0700 (PDT) Received: from [10.1.39.170] (XHFQ2J9959.cambridge.arm.com [10.1.39.170]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 774F33F766; Tue, 25 Jun 2024 05:41:04 -0700 (PDT) Message-ID: <306874fe-9bc1-4dec-a856-0125e4541971@arm.com> Date: Tue, 25 Jun 2024 13:41:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings Content-Language: en-GB To: Baolin Wang , Kefeng Wang , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , David Hildenbrand , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Yin, Fengwei" Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-19-ryan.roberts@arm.com> <1285eb59-fcc3-4db8-9dd9-e7c4d82b1be0@huawei.com> <8d57ed0d-fdd0-4fc6-b9f1-a6ac11ce93ce@arm.com> <018b5e83-789e-480f-82c8-a64515cdd14a@huawei.com> <43a5986a-52ea-4090-9333-90af137a4735@linux.alibaba.com> From: Ryan Roberts In-Reply-To: <43a5986a-52ea-4090-9333-90af137a4735@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8B2A9120006 X-Stat-Signature: eghuoaf16yqitk7wgt8bioczac9o9kck X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719319269-854753 X-HE-Meta: U2FsdGVkX1+X8gMKAO1hLezsOq6SHEIfj4enwcvhfrCMgg1IbaDSvHwKLfCjCOW1LoYTiavaJ4DLuI3W4bRY3AHHS1TXXKpBQ7O2M5lfFO9EoZNMHpa88VNQAk2HARNARxlSMXJR1Nv04/JhL3TP4IEBrisPGyMvaKU1TcpX2ODZMX9X4XLfKIfqKGwPdFwNnEqpXwoNlNgk89zdTiPmpcdHOf7xlmIOEfMsVM921q9I9paSKqiyurHPT6NObeN3sW6wLcmMxbDygN2iB/yBOodEY+XUz6KXxa9H0ZOzlb8XYOjCbCF0Xm9wcWqSl6NHz9STY3HGI4Tk9D0pgSzjc6kYyah7lfy6T8nEKPccRnodwDPKafk9rPSkkZvTE/To7Q95wSnIaeS34d94GFtWTv7yRMPU3A6dCQyNVZgzML+TAesfo3d/2cVDB3DQCq5+HVLqQl3HfqlEDI8UmL36fTKw1ld7hDGF4+oeQIEcUnqD181HkVoRzwFG1iYVhGCV3ZcOPA+TfU2vr0E+38CEReq7EFrYru7ocGgKs0Ihod2kv6zp+0Or04RrYTaL3RiNZwkC2th14bSkig8Actn2mIBhovWyR86RTjqREpIAqHrRRjVPlQWtFXR93+P1fDdg/nj0Ty89oWJyVFx2Xbh2mMJVfcoMsY2lF6MWimVcX9KQ5oxwoAc5UwXE9DiMuyPh4FHMlgJpVMQpLHCzaUCG/rcX0dS9mwg+U8KduEcg72VGjc7dpw1sfjrtI8o+mxqTMle2R4vJ+wQboz5EXhdaR5R+MSvp0BGkWnmYcWhnbwYhdD8h5NSNTHDL/cwb1+yZ4A3r0oX5CzD8ZmOL6jMMlbyz+IJWTDtdRU6XwXUt5zxhN88yB5zT9EVaYjb3bn71k+n1CXCPNcM5bB3FbgZPmHI3Xl2wvr1+nAT0KarNEvI/bhbCN5apzS41l5n4if6xKVUDTZVPBqYTPVu1U+Y e5hpL9Uf HUc7Sw6U199kbmfejz0aGo+Gi+oiXsxeHiiZ4bahSfevpXzsI5/zPzLIZj4C+6M3bm+EqMhJsd5ZMQL8CDW3uXMNmZtTYlH+vuthVh8/gLsquUEKY7kWJd4cw7zkRdPRfiSgfBNGRWcECTosy/nTx5k0l0qZkOaMkJybTNXioCPY1HeobZhnsy3PiZOTT9k5nmlECTf80S/fsIrCserDQEtP7lA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25/06/2024 13:37, Baolin Wang wrote: [...] >>> For other filesystems, like ext4, I did not found the logic to determin what >>> size of folio to allocate in writable mmap() path >> >> Yes I'd be keen to understand this to. When I was doing contpte, page cache >> would only allocate large folios for readahead. So that's why I wouldn't have > > You mean non-large folios, right? No I mean that at the time I wrote contpte, the policy was to allocate an order-0 folio for any writes that missed in the page cache, and allocate large folios only when doing readahead from storage into page cache. The test that is regressing is doing writes.