From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B63EB64D7 for ; Mon, 26 Jun 2023 14:01:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6D708D0002; Mon, 26 Jun 2023 10:01:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1E2F8D0001; Mon, 26 Jun 2023 10:01:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE58C8D0002; Mon, 26 Jun 2023 10:01:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9FBB88D0001 for ; Mon, 26 Jun 2023 10:01:09 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E7C59C075A for ; Mon, 26 Jun 2023 14:01:07 +0000 (UTC) X-FDA: 80945060574.21.9B2C3E2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id C351D1400D4 for ; Mon, 26 Jun 2023 14:00:37 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=er5HZrmY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687788038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7R5wAW69Y9SPx+cvsoxbJGKBGWs/a2ilDi5P0yALs1Y=; b=DrPb06dPM1ErxOjfgO5ssdbunpcdiTdsCEX9qaANRd350JBaV0+kmi5iXGlPxFyFG60J7o rw8Qvk3qqOCBJtChHBAQqLDedRQVrretRmkjNsZD9tF9+ie2H3GuVKfaDPUmUOo7BZjcQ0 oNveuzQ0hfhNsFsol38aGHuLRg01w2s= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=er5HZrmY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687788038; a=rsa-sha256; cv=none; b=VsF+GA94qDnO/XVOE+EEtvuVamDvCxBknEnWqBmgmd7yoyfvBLnpCVrdLI5fQQbsf0NX34 Ig+uOZNcBXsEPG8oUQ/pwByiaAmqz0wZhB7cOeZB6PqU47ThtAWKnSkDBc46JJ6R1zGpxH fNS7udYhGUupqVi70/0MxgN+i+tIoO4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687788036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7R5wAW69Y9SPx+cvsoxbJGKBGWs/a2ilDi5P0yALs1Y=; b=er5HZrmYaGdP0bmzhQQlcd9or0tl3Htt1ZUgdb4b2WjayJ1NRhhvH+2EjZlIEgc3dj/ovS xOvGtQamYyJBK3XCFiCQbRko37ExvwbHlohJ0swE6WhqXs2u/FWibtF1X6c9FlYbaZgk9+ 0e8iYqLd6MNesPoH/p+C6ea6Nnmpgbc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-rCQr8abpMMS8ijQ22hbUyQ-1; Mon, 26 Jun 2023 10:00:30 -0400 X-MC-Unique: rCQr8abpMMS8ijQ22hbUyQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CD8988564EF; Mon, 26 Jun 2023 14:00:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0457A1121319; Mon, 26 Jun 2023 14:00:27 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230623225513.2732256-1-dhowells@redhat.com> <20230623225513.2732256-4-dhowells@redhat.com> To: Ilya Dryomov Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org Subject: Re: [PATCH net-next v5 03/16] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3068220.1687788027.1@warthog.procyon.org.uk> Date: Mon, 26 Jun 2023 15:00:27 +0100 Message-ID: <3068221.1687788027@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C351D1400D4 X-Stat-Signature: 3qbyhooprgr5t3cq49fmaadzubtmgmjc X-HE-Tag: 1687788037-356503 X-HE-Meta: U2FsdGVkX19d3yVICvsJooXAQY8CrKv/M95lnYLGspSXhy+d8/UTsm0XODWjGkWKwNf3aIb+LyeXM7Jfkl+k3KGoZq3RSL0q/v8q1i+0aWqrwaUltMV5zhnnnL8/1vr49wdxzaz/djVgTgKjBKsbmH52eGPia6wdFIcRNPTvlpN0K9QpWQ8DYYwlVKHKQQhmW4htWKtMSAxW2MhVghwhzOO8HeAYIUZNqnaTroRWpCaD0cwa4bnLFKFFYomvVNbehmf5QWXB6emZ/IhTIWfkMllEwMxtByb0XK3HHRI4Fe6NJ7kkS9FWa49ZK9MRmfzgUskNwKVdx6Pdsm+y6+ib4jH86133nww4WSu9MzZyBzUSMku8YB9jglD2ARNHnFjB/E3U+NiNKPamY3SMvlArolf0GrDan3NFBFSawKAACjOq4E3GOIh6YpZql3ljMUmSQyfv5TJask7B7DRy/1FpYjnPM9tAWBIaXjV9x/WjrVPNGIfC/VxCkmU+SE26Dqs+Zu11RJ2W+07XEbJUzKUYyRLvju15b//UV5vIMY+KCbAhOTProHep0ocFlo4SSKRiyBAHacZErWdMCrP+rpuOKKaKpm+Hq1cuFP0cLDWT0zmYHz9RR/hgvyfHPlHNPJkHcGHKT/rMifqVHidDitDbYvOk5HIMYIik2083IsQ7rWx+J0tGtqof2WTx8QUEcVcIHvY7YML+hwfMlAQNiTfxwO2cnPewwjietJwcO/9dL689bMlqOueU+zRR/vsw2P5+QPSCDbNb/Cj4XeRp1Gh5GQaYTXaM1tMXGEX97A1gCLYhoT8fH8OGHkYi6Z1sDBC4+ojk7+O7d6ZncpyUvFpuQCBrIq5rcpL4d1qvGFeNIzq7+cKh5sABuyF5nMMnA6k1r4JpEBbND/SXAKFd6KMC6ByBvyS3cRdQjFt51f60chcDzDf7DB+OkwLr3LRVg/Aney79C8vycmzR4VwLqPQ 4moY9d7K T9nc0u7LxzwVZDM5frGtPBfF5OMXS8ToFUXNybrPJydYw0pMr7IDWi+W9MeKBxilwLcG2DDyOuYD8o0mJJFkKx7TrZim7YOgcDFKZWICP1ZVgRbMr0iojBhy36UhawBlsBkW8mCt4Bre3rMuXs6/NwflyjEmtiqnpvlEWPHuBzczR4a0rSvRPZI2owb86QOs+jhDM53I9bE8dtCZDVDDNA008s1aqiwtqclCq2cOBtRZsnp2H70HGxd+/Rf05yhZnb+VvKUW57ACki0uAQ4A4rQemVAEnkQE+i4vdVd3WRcni5WgVjJ/yRT+RWI87CrA1nMQx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ilya Dryomov wrote: > Same here... I would suggest that you keep ceph_tcp_sendpage() function > and make only minimal modifications to avoid regressions. This is now committed to net-next. I can bring ceph_tcp_sendpage() back into existence or fix it in place for now if you have a preference. Note that I'm working on patches to rework the libceph transmission path so that it isn't dealing with transmitting a single page at a time, but it's not ready yet. David