From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA92CC636D4 for ; Wed, 15 Feb 2023 13:02:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 951926B0072; Wed, 15 Feb 2023 08:02:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D9C26B0078; Wed, 15 Feb 2023 08:02:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 754826B007B; Wed, 15 Feb 2023 08:02:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 611456B0072 for ; Wed, 15 Feb 2023 08:02:10 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 09DA8160721 for ; Wed, 15 Feb 2023 13:02:10 +0000 (UTC) X-FDA: 80469539220.08.07F6248 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id C2809120005 for ; Wed, 15 Feb 2023 13:02:06 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ChQXqeMq; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676466126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1kO8N6JLykhQ4YdfKs2d43b+gPORvqK7xPAz9ypT+Zk=; b=h++F+H3v8r1BNCF92CSK2tSMOwbwDNC0afIKTM5/WM/Fx4LSlwcy5+hEcEVWe8L90vj0xT +xeNWW0bnYVaUfn6EwGcBS6kztKFyAhW4YsupXVHHGiHJ/xEWZYhRAdXer+BgUiaFF932p +1WedUczyB+lOIsZsmupTeQEUYbekMc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ChQXqeMq; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676466126; a=rsa-sha256; cv=none; b=FO0nLU4WE0ivPkqQxr4MVgxH9cjrypgPZ8+Q2EEXbJjfvhCgWKSj+XtjwnB5Gel0d4kpiM 9XGmlV4aEryiN8ipuCjMLU1vnE5kCr2PcoSh1nWUZFQaBjVFkoGI7wqHwZ1P8xg5BcPYee PpDI+639oe3X99u3vZME59nwVvyyxNw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676466126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1kO8N6JLykhQ4YdfKs2d43b+gPORvqK7xPAz9ypT+Zk=; b=ChQXqeMqdW+QnogcPSvUwwiVHsWkjON+7pvbwLVNRByY7t+xWvvnoUtFoKH8vOTdoV1g64 k7dRasoPguYkz1T9MaR1Nx5wO2wenWF4oYdV7QML8MacYAhyI5DNBgU3AkzB0XMt0BgNFn 4MD9edPySNGvBlDbDreZEXc6ridb0FE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-BxtiEXZhM5WJBsv1CLOnxg-1; Wed, 15 Feb 2023 08:02:02 -0500 X-MC-Unique: BxtiEXZhM5WJBsv1CLOnxg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 842BD3C10691; Wed, 15 Feb 2023 13:02:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57EA9140EBF4; Wed, 15 Feb 2023 13:01:59 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230215-topic-next-20230214-revert-v1-2-c58cd87b9086@linaro.org> References: <20230215-topic-next-20230214-revert-v1-2-c58cd87b9086@linaro.org> <20230215-topic-next-20230214-revert-v1-0-c58cd87b9086@linaro.org> To: Konrad Dybcio Cc: dhowells@redhat.com, Alexander Viro , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , "Matthew Wilcox (Oracle)" , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] Revert "splice: Do splice read from a buffered file without using ITER_PIPE" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3055588.1676466118.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Feb 2023 13:01:58 +0000 Message-ID: <3055589.1676466118@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C2809120005 X-Rspam-User: X-Stat-Signature: roqsyij9mzmiuiuc4m3egs3pd6y1z3fw X-HE-Tag: 1676466126-322819 X-HE-Meta: U2FsdGVkX1+lxiLEMIBjmY3kR2p8dMi1ctIQNffjaKEWPUEtdgOll3B8LTicnW2BFjltlvXpdaWHVoCSLr1gj41JW0QLjM/MKLadXjQd6l9LhJdP98oVBClyLVokGzcFWIdTw9pRGaCzbRJDekalz7BAEYfncSU3WuIOMOWNlcGYbaxFV24mkDJ82RQOhVDiBm+fveFVH6VEi5ef5Oheyge3ozSjQhyPC1vMhlySBrvlhS0jih9Yz4y9sNJ4g7lopfYn3sruK53GWKxEKd7lAPSZveDA52SL9CY96+WEUGRRHnalUHVRa2dgZB+RMKJVTrjmyZxN/mTbfljVu62hef03y5AeV83FctfIoynu4i2IOc8AquRXi3zCWPZZ9pZdeDfYYWeki4c95bjqQxKuRn44JlNwOdBCbAqR5pILa+I0fB2vB9C8TxXsByO7554T2yXIXO2MA2TQHvj5/TEYzCFWLxe93hoQ1ZBEmi/noscWvca/7VEJh085pm8chxF1ixgQQmsd86besXJoFwvzVvXFSuQxSt4djUFUCNjDLr2SWu3e0Gtq/GHdYG8xsPGTG0xZbUxrUOeljDyV/A97EhHSs8/bCuDm5lj2wzojXuhB8Q8Wf1p/6EMzdv1gvELQnPanr4pGzrB5160MXs3cFSTt7XwRGaKiLg8u7h4TDovUf3ncqzjAhNw7JCVVFxW4zrs9bwa3Q56pXXZCnFq1ofOi0aJuC40P66bZllCmpiBIlaz8dzWviwaBb44wde+dhrvesRJt5KEADXTweZSkwq4HJ/8mRikwiEOPIY4HozKQAF5IrX7rKKuwCO+qSMfpPuU+ZvejjUdTRxPj/eiHu5nIIQCb8ZAc2tk8MpaZN7m6vO8hlE8wXySFEwvQKNb6b3pU0dZI4X/nzCHXj4Pvu5HZ+SUWzWn0M/wNt+rbZFw9LgOm+yA8r3tHeh15Sokx3MBgAIw+4M4GWx/SQpe h4ZQutS1 /6t/FjZsXd5tXbX7oZs4xk2T1tnJHCv2Id6AObxpsEU4M8Vkj5Jc5FbsajM308swRKd7ClCuu5BGF5qfQKiC6bFDJMtvlxz4O7xZTDsF3vuxUx8rlgZATw4C2syUCq09lVfomP9VmXOq4bQskd96jFENC35SfTsAMR4h6V9N/lQoGSGZF7uXR3mfUhyYHXrMq7iCvJzf0SvSouT5Syb9q4BdglIOsnU+x967DBA9Xn98Fo163x4DaKuzvM0Xhi6braZM1ccUaKWbWNmYXvutWGaYEGocONf6q/yx8m2FZBSKqreSbiYVtzNs1vnFw4h+sXydrkUFkz+I7anpQBF/8o8GJbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Konrad Dybcio wrote: > next-20230213 introduced commit d9722a475711 ("splice: Do splice read fr= om > a buffered file without using ITER_PIPE") which broke booting on any > Qualcomm ARM64 device I grabbed, dereferencing a null pointer in > generic_filesplice_read+0xf8/x598. Revert it to make the devices > bootable again. > = > This reverts commit d9722a47571104f7fa1eeb5ec59044d3607c6070. > Signed-off-by: Konrad Dybcio Commit d9722a47571104f7fa1eeb5ec59044d3607c6070 was part of v13 of my patches. This got replaced yesterday by a newer version which may or may = not have made it into linux-next. This is probably a known bug fixed in the v14 by making shmem have its own splice-read function. Can you try this? https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log= /?h=3Diov-extract (Also, can you include me in the cc list as I'm the author of the patch yo= u reverted?) Thanks, David