From: David Howells <dhowells@redhat.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: dhowells@redhat.com, Alexander Viro <viro@zeniv.linux.org.uk>,
Steve French <sfrench@samba.org>, Paulo Alcantara <pc@cjr.nz>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] Revert "splice: Do splice read from a buffered file without using ITER_PIPE"
Date: Wed, 15 Feb 2023 13:01:58 +0000 [thread overview]
Message-ID: <3055589.1676466118@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230215-topic-next-20230214-revert-v1-2-c58cd87b9086@linaro.org>
Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> next-20230213 introduced commit d9722a475711 ("splice: Do splice read from
> a buffered file without using ITER_PIPE") which broke booting on any
> Qualcomm ARM64 device I grabbed, dereferencing a null pointer in
> generic_filesplice_read+0xf8/x598. Revert it to make the devices
> bootable again.
>
> This reverts commit d9722a47571104f7fa1eeb5ec59044d3607c6070.
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Commit d9722a47571104f7fa1eeb5ec59044d3607c6070 was part of v13 of my
patches. This got replaced yesterday by a newer version which may or may not
have made it into linux-next.
This is probably a known bug fixed in the v14 by making shmem have its own
splice-read function.
Can you try this?
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-extract
(Also, can you include me in the cc list as I'm the author of the patch you
reverted?)
Thanks,
David
next prev parent reply other threads:[~2023-02-15 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 12:00 [PATCH 0/2] Revert boot-breaking changes in fs/ Konrad Dybcio
2023-02-15 12:00 ` [PATCH 1/2] Revert "iov_iter: Kill ITER_PIPE" Konrad Dybcio
2023-02-15 12:00 ` [PATCH 2/2] Revert "splice: Do splice read from a buffered file without using ITER_PIPE" Konrad Dybcio
2023-02-15 13:01 ` David Howells [this message]
2023-02-16 9:10 ` Konrad Dybcio
2023-02-16 10:56 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3055589.1676466118@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lsahlber@redhat.com \
--cc=pc@cjr.nz \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox