From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA51C25B74 for ; Mon, 27 May 2024 18:37:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F5E86B0085; Mon, 27 May 2024 14:37:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A65B6B0088; Mon, 27 May 2024 14:37:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16DAB6B0089; Mon, 27 May 2024 14:37:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EBC8D6B0085 for ; Mon, 27 May 2024 14:37:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5DBACC155D for ; Mon, 27 May 2024 18:37:21 +0000 (UTC) X-FDA: 82165033482.24.C55F62F Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf17.hostedemail.com (Postfix) with ESMTP id 8294340007 for ; Mon, 27 May 2024 18:37:19 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hgowiNjP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716835039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NZREJP9vEhBnXbP7OCuzE5kdbwmu9xegRbDK6klfZJg=; b=y9GrbezVkVtDNyAt5L5uyHh57KLXqNOlY/Sm21VnRNxSL73zCFzANU7KdHoIesO5T0pzfY a/o4CaRgzlYQ3dS6IG0R6BG27WZND6e5IB9sFzkM/iFv7l5oqAHu4ge9fb7Cq+vhOTGo9j frp7iPAkLsAQk5tWJm2R+VMcQbn9Cew= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hgowiNjP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716835039; a=rsa-sha256; cv=none; b=tYkNEB8I/QpM2P5kZ3lJ6Ns12hA8RvOKqcXMOuJI52NO3jiKIvaMynvD3R4nAVUj5854ZS p6jZ693EYC0F5QO+rgAOrtvaEWTLkv3EuSBd0i0bI6NCwsUnXEbR9d9+votUR4FUdDL54X ljJ145S+8u0VFm8mm4CB16T9m9l75Uk= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f48e9871e2so188875ad.0 for ; Mon, 27 May 2024 11:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716835038; x=1717439838; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=NZREJP9vEhBnXbP7OCuzE5kdbwmu9xegRbDK6klfZJg=; b=hgowiNjPBJZBJEoxb42pB1DZhK2bcWftZGzgurJ0J/CAQZ6+/RbKUk43V4D9VOV/Gw 7Jo28oQoHpNXkx/JHqTQdFbIeJfMs6jJ/Ms3/8uxossMk3SVFh4hQnFrZH71xL8wJRKW zvX7TLTO35kfSPIdGFQcExy6RJsGLjhSMyRV+L8A2GCoaTha30X5x5LvFjqdo7S0xkL0 x4PHCavnxJSurW8wnfMFVZ4uhQVghKs2FQDeUC3pxrOz7NLN+C0oN5XUQiUTu/atl20u 9aJ6CKIvOzp3NaWt6HMBWOJI2ulpWCr62eel61pIt9VKy8DpQTam7LWdxDJaZHtLgKfu NDDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716835038; x=1717439838; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NZREJP9vEhBnXbP7OCuzE5kdbwmu9xegRbDK6klfZJg=; b=JfReXNuVLJt2ifZc2AtZjzuOjXpzJuyxPMEf2BMSoJ/kra8LtZ22cvX0XK4EC7zwK8 gp+pKgp7lhwfFdGRk5VXK0weHk56Cdf6tXSuU1UTKcrW1Td/XJK6h2+PBFkp4xmON5ou fUGxP0YtDChXtccMVq4ajbMYxG/hYrQK+OQffVCxuvNOlGSOg4r3wQvwer+b+TqqBfHl o9XwfbvXPlSz334v3CXNeFab9IJdeG1wMPOFFriNzAzxsvy+CG5I+pT/z7X2GyRr+iSk OnW/9Xb9qcu0HZuiFDErCu1J4AJ30tTN15Mr/V6rh0jZ6HJcnILebSn/tasfL/dtuCLm tlRg== X-Forwarded-Encrypted: i=1; AJvYcCXKCQ1D4bVnzo4Rx0EcKv6KUcS5ON8lD5RFL1YooZFhqC/JL4MYIkbq5j3MJhcTgJEFkbYGI7V2uJMl9cfAXaQj26w= X-Gm-Message-State: AOJu0YxYRLACA2qgpxCLOan4BHf6zUrvTrElVGF+WuPdFAJlyKdLJ4bT 17Gj5ZPEI24pOlqLDUQosiHU+9JdB2bvhk+bbq0/h4ZSLAGNHDBeu3BsbDlB+A== X-Google-Smtp-Source: AGHT+IEAL9UflWJoo7lbOoL2iTxPWvC4MLeycXG2R6EPtLWseyz3TQ+/DhwL1Fdid2CUzoLzhdeWCw== X-Received: by 2002:a17:902:c384:b0:1f3:61f1:e340 with SMTP id d9443c01a7336-1f4693d8fd3mr3532215ad.13.1716835038114; Mon, 27 May 2024 11:37:18 -0700 (PDT) Received: from [2620:0:1008:15:2ed5:4637:e8cc:f09e] ([2620:0:1008:15:2ed5:4637:e8cc:f09e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c968386sm66391625ad.146.2024.05.27.11.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 11:37:17 -0700 (PDT) Date: Mon, 27 May 2024 11:37:16 -0700 (PDT) From: David Rientjes To: Vlastimil Babka cc: Christoph Lameter , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kent Overstreet , Suren Baghdasaryan , Kees Cook Subject: Re: [PATCH v2] mm, slab: don't wrap internal functions with alloc_hooks() In-Reply-To: <20240527090127.21979-2-vbabka@suse.cz> Message-ID: <30544807-e9a4-f764-d113-d446242e9f35@google.com> References: <20240527090127.21979-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 8294340007 X-Stat-Signature: 7f7bukq9rgrnhgj46s6yzdznkwie6k3h X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716835039-19431 X-HE-Meta: U2FsdGVkX1+Rz372cLtl61mgiN0eac/Z5Crssk5GRY209rMjpYD21268BcC0TZtivHcKxDsiDTTX1aK2nG1ysoSr6kDh+imk5Ysj02n51ZSUVx79XDtFVLO9nvpSgHXyX1ixo57L/SVWd0FGjUFAVdeJMDmOVHqvKwGCKa4onT5thjkqRMUGoT+/9eFf8lDtj9q19auzCeRp5f9iwaofnCk37W3kP2c/yOEv9He/mcVy3XolVq2t4Dj856l2t14SpbIamjgcR4RKGbofOTeTQNDIaA/SWqd5og6doFzg7LXvAc9VEzhXk9WU/B97isGINxv5R4xVzqHvHm5uM9or39MkLRdn5emrnHJ0fL6ABFiFPu4cIpbiQTS/GMjbkb+9yA6gdlaSFi2QAEevUgjI8/x6TDxWMOYvZ2wsc20YuB7IOMjfuzl2ahkY3DxuVoTLw+igevXfgYwf0W/orn8ODY/JxAv5WI2oJdM2/7CqR8etBTWND/PPRRN7wzMVMjgnVscaxV9w0cB2rqazwDhSQfyJlOcgZABm0bfX+U9oGi0We+1U8uGvuJ+YUy3TFWSOmm1jcZr8s9D/JN5ygM0mlMIr3ECwHN+TfpKbP+5it612vYl/qxcMNcpZ8OfJuNXWXUFkUIt1bkFLSFgO4RJINzQSDjvUvVouI+jd3h5N4u5NGZtBB4lGQTAjcomeY0foRtaNfn1hUfH9iPKmhdgylS5T+nN7cDo18W1CRNOJhLzyOHazU6xZBD1BbJ+xBUaUgSIduu+3QUvwBTQe8rxdjQNyLF56pYOOehfRAAEdj/gruEv3dmPh6EGUVOlOlO7fF5+MHTCOYYZLlMU0/OL04Z6dLI5IzzAfV7WNSXee1dlWqNd50orz4oHNL4CmY8YXmKjACRchXYTa2KO5PIU7H3uxmbI3px3+3pKcvtYWxOKgqbbFffrCbrEAUkVYvc90H/S5hAexx2ZtYmO1ZFv 5QlyAIIM IXtkqFxArIhKFo3hMsPWeLs5o4SPVrc1QVdz64+BGoYivaJWMAbds1xn4diWBl5CHoz78GpRdWFy1wDqILiH29nX8pqW0u5OSIzc2g9pHmUsX5Azi1xP9hG8KOv7qf+jHHZAmxxobVdkVL4xxoUe+3eIQ+kBmWkN6faolS5EGzql/GyUc8sKcGL/lycfE0QZ3W1G7R+kL7xKEIaXLwQsUev3LMfN6yfIWMXMMtzfV7ImAYkcu8Na3umKVZJ0DkBi/ixNpEr/o2HOCU5Mc3gCPSaOJFmDiZEKNV3dD3UcmIFKhVs7TXOl/HsMyU6qzyMkhFMcguxJIKRhhMrykTNfe90grPQUu2B7D9WKL+xKa3djp+Kfy6KcN8Kze4Jtf3AxwiAyZUYUYBJk+PMvmEhJDQDxhsikBR4MfSTL4eqKebEBHbBPLVppaFTbZA/+EBqQHf5sSt4aPyN3kQPTuCrNwkQsEs6R6HOgUP1C5ZBdb3TYf9DxA/97TzS4NNvIKIsuTd06KFdMjCjadM4dsJ9u2zZEzAFIXRWjnzJj3MLGY/Rbzy/otmPx688PCKXGeGaa+7+P/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000166, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 27 May 2024, Vlastimil Babka wrote: > The functions __kmalloc_noprof(), kmalloc_large_noprof(), > kmalloc_trace_noprof() and their _node variants are all internal to the > implementations of kmalloc_noprof() and kmalloc_node_noprof() and are > only declared in the "public" slab.h and exported so that those > implementations can be static inline and distinguish the build-time > constant size variants. The only other users for some of the internal > functions are slub_kunit and fortify_kunit tests which make very > short-lived allocations. > > Therefore we can stop wrapping them with the alloc_hooks() macro. > Instead add a __ prefix to all of them and a comment documenting these > as internal. Also rename __kmalloc_trace() to __kmalloc_cache() which is > more descriptive - it is a variant of __kmalloc() where the exact > kmalloc cache has been already determined. > > The usage in fortify_kunit can be removed completely, as the internal > functions should be tested already through kmalloc() tests in the > test variant that passes non-constant allocation size. > > Reported-by: Kent Overstreet > Cc: Suren Baghdasaryan > Cc: Kees Cook > Signed-off-by: Vlastimil Babka Acked-by: David Rientjes