From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6AFDC61CE8 for ; Fri, 6 Jun 2025 11:51:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 622816B0095; Fri, 6 Jun 2025 07:51:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FA216B0096; Fri, 6 Jun 2025 07:51:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C18C6B0098; Fri, 6 Jun 2025 07:51:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2A95F6B0095 for ; Fri, 6 Jun 2025 07:51:46 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 72849BEBCA for ; Fri, 6 Jun 2025 11:51:45 +0000 (UTC) X-FDA: 83524811370.28.09E30A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 189C7140004 for ; Fri, 6 Jun 2025 11:51:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MYgTOCPy; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749210703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YuDqZfBW806rEHMVFjcdFO+ADelk/lfDf5CqIzU3/HY=; b=cpz+HG3sPtKXsP4CzAX2pc35FJuhnJrFopgJxyP+QYk8d+pk/m0JB67e/9otXHPjx1c8S6 DtJmL9DDGOI8Doef7vAMTeo4WnQtNbFDye6YerGuEIylOBKqkXXrzWc/FVFo7QQBntYOlx nky0vKzo/bz6xLuKzFAMWLlChSwej1o= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MYgTOCPy; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749210703; a=rsa-sha256; cv=none; b=r1RH/S40RaOUVnl/AZPVsX7OCYCEGzX757sBr1eIZAB8jy7VQEiXOergJU9X8aLiW9K9ZV 7mIOebd6FqWSn/JmfNsoFnw/2fpw2R3NaqSVwiRlOhwmdg6w0JzMuQUWG+XO/dB9p4zZCX b+vmfb6s6cpHEtCW9MZK+uCKOTcwbuc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749210702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YuDqZfBW806rEHMVFjcdFO+ADelk/lfDf5CqIzU3/HY=; b=MYgTOCPyC7hhQxaqIVpvD6H5YUkrsXqFW5RYa/h8wx6UxiNz7UbKkB+GKsunS87DcD6slS /YfYtaFlx5RQ4YbU2MaA0BZ1eFqy67jpISP5nICOSZYIQBF1EF+mOe01k4WxMsExbotIeV 7ZIMhW8CLycXVJ1xpaGQtAcYIdiPKZo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-bZh0fRNrO6OyF02DbcKrvA-1; Fri, 06 Jun 2025 07:51:41 -0400 X-MC-Unique: bZh0fRNrO6OyF02DbcKrvA-1 X-Mimecast-MFC-AGG-ID: bZh0fRNrO6OyF02DbcKrvA_1749210700 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-441c122fa56so10173615e9.2 for ; Fri, 06 Jun 2025 04:51:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749210698; x=1749815498; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YuDqZfBW806rEHMVFjcdFO+ADelk/lfDf5CqIzU3/HY=; b=OHBpK5rq/3PhLgYqFNiAYSsKz6KfSwBIU2mYyKcsDJJTG3BClXwpJcKKkCRJMbTufO 5/dpJTiwtb3HBh4f7nMJwW9040ZE7u/XItzFjGkRuzW+ubJWOPgwZTKiXagDwfyLnDjQ rUeUP+l8exdMqhpA8dUCUFe3ReykO/fyH48RA5NL3T/v4mlhof/tzwc3c66XZAJJV51w y6xLlY+Vmx1O6z9CN5Ew9dPcr6/g2Lqo1sxoQPf+++2NlmDPoEV+EL7GlaZgkRn9GahU qNAEiU/B8OLKdkPu2ZyIob/xBBhsKimCEyLZqBfS0boFAYLZ5b3nyg3IO13LNrL6syg8 wTPA== X-Forwarded-Encrypted: i=1; AJvYcCWNsA4NNWkqBzlajEv+PeDVAMQQPj3xvhfAktNih6yhmuIULBOqDQtk7lz616ESSz9F93gtr239EA==@kvack.org X-Gm-Message-State: AOJu0Ywg2wu75x2FTLfcagnB5qjKnXJ80Vq1zT5s8Js4oo7oYAGqaj9d hvcjNeAKhrc1+A8rpaifGgIb39neDV5xAVQcqDyMc8ln6PmUYhxX0HCzUrLQ9lzmB2bxCXz6VN5 03GOA5rOn2wfRogj4eaLS+vzXJrd3nl9IJ1icUNHfMdVpv2AP2RzO X-Gm-Gg: ASbGnct81tJM18hQp7q7t285o2L8v+29c2V4YpTCYF1kJzms+iFYgdaYqrB9EvMOQ+w QOx92VPq5+QUtX7bj+heFdX4rHzdHvJuCAozLnb+ojZfFyp81T5fxWP4lcSyW3n95eHKl/toap4 N/ghFcRh5L61EGvoMLhiN5QZ5wjMwH0arAL9SDN4ttmX5OD8pAtECUgRS5LLFWJUD/7wz4bxmmY ILKCxEP6ZBuXk9s9//SA8xol0r/XhquKd+rQ7l+kyxcDG9O64l9qS9I6iYIoj8co4YG1hMm/bc5 ZRm/eAEvSHdJ8v9atTTUZH6DhMKj6fXqU5ewP49n6ul62tWk6SdziPaBLmrD8Q75wxh9s2Xplb8 FKJ2Y39RN5cblq98SD5UaR0K33PPXLDE= X-Received: by 2002:a05:600c:1e09:b0:442:e9eb:cb9e with SMTP id 5b1f17b1804b1-452013d1ac1mr31336585e9.26.1749210697804; Fri, 06 Jun 2025 04:51:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTutIf5S/5ExePoSx/Td85W93qsFuXMvMZErKLOVTEWcRei1bg1QE+/+NPv+XEexChA/X33g== X-Received: by 2002:a05:600c:1e09:b0:442:e9eb:cb9e with SMTP id 5b1f17b1804b1-452013d1ac1mr31336315e9.26.1749210697345; Fri, 06 Jun 2025 04:51:37 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f8311ae6sm30797975e9.2.2025.06.06.04.51.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 04:51:36 -0700 (PDT) Message-ID: <3051c206-9a1c-47b9-a5c4-18010abf070a@redhat.com> Date: Fri, 6 Jun 2025 13:51:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/10] drivers,hmat: Use node-notifier instead of memory-notifier To: Oscar Salvador , Andrew Morton Cc: Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-8-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605142305.244465-8-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: r2lz6DwXJJtf9HuXJJFdFisl4nU8nKFCNV2eMyXNyZs_1749210700 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 189C7140004 X-Stat-Signature: w7s5yjkzeqgntswauegpkczrqfkr8yxw X-Rspam-User: X-HE-Tag: 1749210702-211539 X-HE-Meta: U2FsdGVkX1+mq1oWa8S9Dg21NAifvjD5QUeCjZ96BojRZp1jJBOAqiBl86pJhLdL791Tv4j7z5EHxafCLy/xWiyc/ZJ0xAhX8s8q0AWvUWoy++aB/4UGmWMDQJVx3MHp4Fzgu+63t7ABannJvAzqui8lKNvDoSF3EDMNeN+HgHnDpCuED0Tt/XbBzns1M6Zq8dhokWbhJ0BoygmulIiTDRqjtoBSjA4r8pfMzNUoDJtLMIqey8TngHWsO3sN5M/eVA4sT5i/M/F24Z+XNtlbYEU05qxyLQb8D5Uhw32Jw56CYzvmJ1v0Zs+b7QKyUCH6ZZFv8hpOFu0jJ1uew3wRjfXP82TmwGSfOCCRzEXg7L1yAH2LchnlOCr0NUX68CZcr0xr/lZQG4RJSl3o2ZkZkkRo2HehGXaugrvhbdnJSeri0BFeJIifn+vCyUiPXJ3vPg4ZsFAHXji3UwHg0sRjO4GDelBdA+Muy5jAGqjMxL/Cv+khr6yToHdx/3z0X7WQf+OrpYdgNrXAhHiFgDnTs08HVsB9cKc27kd5pl1dZaQoyQJY9VnTjylvz+o+CL2RoI22/DQro6DHHkyZKRURd2pfIhpP80jOh5jYq/4TF2nY2Q1BkRpi+TYoJ8HPP7DASuybQhxSPYFEBapUsSzgDzfwXzZuK6EAi6kJMIf14XHaGC+yK8CBY0ihvL4DrUM1OId2+I/js9FmPvjZ3QNs9WMUiYF3+LHurNdAQv4vurxxrmt8tcBV+QdfBPNzYA7iBEPyeS01TTaqTmo5CcRpj19s4IEHXTeSOxIDSVpsAZLhVN4cO21ZqAPOdZGyZzoFAh7ki8hsMxXA3B3ZT+MCE97XU8bssTqseJJpRrmTrOb4r5rCX17v36TAUqntCXNmnkWfk7eluV5ASmR6Y6mP5CNVok2Hqkl1XhPvuqqcq3XUbxGKNMLcpKdquWZA6JjPlEKFDa0r7js+ZmsWERa 5diNPj+n 3U+T4pGFcLv3Wi4Tb1ZhHrDvh5IhYUtTp8LYLo2AnvCx4CwVqbq/r4dNI734IPfaT8oHOFwxOsUEaixjp6jzBXpRxiqSW8F4xhkBmJdUhBZEzQ4qZV/6u+vQU8iJasLofksjfeOupDljpN7InCpOhWSz6OIy1i1F9EF30RC5WzFeTW4d11d2I72Bmw6qugrvHMV0nDChSOEf7aX0nRl/3f6VggnTRqLYdwgPtVUrB9JVBV/9d5hmBd/i7BFo3Ehd709DO1h2yxlzieRnkKjfXQUx7uoaDL63c4yNRItrvnFPWf5F2hM1t6K+42JuO1vjGutWTTrDeZLPyLMKgsaSDD+3BBJ9ndnh1AnaAnaFGfuitNPEgW8R+TjVHecrAIxeHSG20Cf212ZWR7l5RhCrXydxtm1b7YsfknDooyxxxz7fu9brH9BRpV3KvNcjgtvdmnHtiSzMFM19tjiyNzA+KL3bSpEx5OE7dCntx+5SoVgNE66ADktq5y5rxu9pBkuf2ZoKqzpd3SI5KjiE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 16:22, Oscar Salvador wrote: > hmat driver is only concerned when a numa node changes its memory state, > specifically when a numa node with memory comes into play for the first > time, because it will register the memory_targets belonging to that numa > node. > So stop using the memory notifier and use the new numa node notifer > instead. > > Signed-off-by: Oscar Salvador > Reviewed-by: Jonathan Cameron > Reviewed-by: Harry Yoo > Reviewed-by: Vlastimil Babka > --- > drivers/acpi/numa/hmat.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c > index 9d9052258e92..fe626e969fdc 100644 > --- a/drivers/acpi/numa/hmat.c > +++ b/drivers/acpi/numa/hmat.c > @@ -962,10 +962,10 @@ static int hmat_callback(struct notifier_block *self, > unsigned long action, void *arg) > { > struct memory_target *target; > - struct memory_notify *mnb = arg; > - int pxm, nid = mnb->status_change_nid; > + struct node_notify *nb = arg; > + int pxm, nid = nb->nid; > > - if (nid == NUMA_NO_NODE || action != MEM_ONLINE) > + if (nid == NUMA_NO_NODE || action != NODE_ADDED_FIRST_MEMORY) Same comment :) -- Cheers, David / dhildenb