From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F502C02183 for ; Fri, 17 Jan 2025 11:36:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE77D280003; Fri, 17 Jan 2025 06:36:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C96FE280001; Fri, 17 Jan 2025 06:36:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5EED280003; Fri, 17 Jan 2025 06:36:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 98DD4280001 for ; Fri, 17 Jan 2025 06:36:32 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6D836B1A62 for ; Fri, 17 Jan 2025 11:35:41 +0000 (UTC) X-FDA: 83016738924.14.35968E9 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf08.hostedemail.com (Postfix) with ESMTP id 1853D16000F for ; Fri, 17 Jan 2025 11:35:37 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737113739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nw3/DrLiwmOZMrf3Bo9q5a7A+MBqjyNFVfEpa7H6w6U=; b=Ow+EvNG4UBMM2X1wVsVRQjzFJ8ywhk6QQ8aXSk4yElg9/uIzSrETkmzCtOJZkXvBJo9efB 6OkL8OdkUTSW8QiOuPgKiyMIseMHRpcWTJ1QGhI3x8ZU2B0rhE0b/M9qze73PtgryG6nHB faJpsPgyDP9kVYc28+m0jyifKClT+iU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737113739; a=rsa-sha256; cv=none; b=4cpygh63hj5+MQHucvNXMQ+Qo88MfILwcOBThZbaV2vX/Uv0K0X29sifwYbKfW1qFA/bmV 8d1hqI0y2WwuUo6iC4bzIvG/a9S4joAxKmaoc5EL5JfQhtv2G5usN/nBDsYdelUExB9DtG 2R6s3Wg8LJ9ZKJx+WFZKptaAd4TTSv0= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4YZHcq34sJzjYBg; Fri, 17 Jan 2025 19:31:39 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 2DBB1180101; Fri, 17 Jan 2025 19:35:33 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 17 Jan 2025 19:35:32 +0800 Message-ID: <304b542d-514d-4269-ae11-b2e214659483@huawei.com> Date: Fri, 17 Jan 2025 19:35:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 0/8] fix two bugs related to page_pool To: Jesper Dangaard Brouer , , , CC: , , , Alexander Lobakin , Robin Murphy , Alexander Duyck , Andrew Morton , IOMMU , MM , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , References: <20250110130703.3814407-1-linyunsheng@huawei.com> <3c8e4f86-87e2-470d-84d8-86c70b3e2fcc@kernel.org> <3a853e1b-b5bf-4709-b8f6-e466e3e7375e@kernel.org> <1bef4a35-efaa-4083-8ed5-8818fe285db5@huawei.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1853D16000F X-Stat-Signature: jfxfafmrhryio3bx8b5tk6qs7werfmyd X-Rspam-User: X-HE-Tag: 1737113737-432188 X-HE-Meta: U2FsdGVkX1+PdNWjAJk7lvjIqZfU1Lwg3heAlp9jMp6qSAuu7RF0BIMvYbeTmEo4a09s87dHUF14Nnanq0/5mI2176Vx6H4gjVNeDRUPEFvK0uoLYIOgps+VdDjgv7/fGWq63FdVjtLp31jNtddsw+RaAkTakjGIAJbXJhaC2DpadLctql3+nV1YREXVbaoO1V0AHUmxLblZ6O4yG60PeLbtBC0QM9mkkJL0DFu2EOnG9+mfZLwAVGnY1NKyGotlzdXbqZevqeFL1WYRSnJt6sS2wnol3wpsLuLq/cyp2iED5ihBn0Z7elEDCe4SzOeoi7XqTUzepDbHWaFrj8Lcz1vIpW6J80KqfV3hc+tez8LfYCOScrfTikgUajwOYeT2uVRA3yWXDKXAIPoluFpY8b9jGgFTFJWIDGmXu2L/NOWyFRMuc+OF0ZjLt+Oe0ne60CldppMXuzWB2pCmZPA4vM7Zv1JjR0apNvSFbNPL+uauv7TljB682JyhpiyrUT74BRpgvAsDhbxMtzRn+dzUJx6yUfLvVpEBRXpmW1FOEBJe+wrWPukpcvb613fF2Q8NxJjKnlbqBo5xITq0Q28a5mWfqndhAaz+23zdqvWfbCB8Kuvlc9gHwOeahb61YmlTVgYCJq966L+bf3kn3iSvdjLToP1XyIRNWtVTHO3Xg5+ierYNigFZvYMJZzwFM6U9pPgwy7oVk+Ep68hIz/ZzLamTAGKIUThVpgnmvjPq3qOyo2znGyk9oXmfnVtgtkvWRlZAqd35i69RZtud8t11LIiy9w0D1deuz1kW7lis3KM16XSAN4/jrNTVWP609v1886MpOPDULvFzJ1IwqR/pxK1j8dsiM0gJezURrFOR1/F/qcsFUsKJVOwWG7BlrCZb+UXvMH3jZJpArggbuDWxlNqD0Y1bAe0FkbwrP/BGD1aYoqZaSZQDbWqDLxO4EEFCCBSAdyu9rJN5zXNpTaT nYzsspxE 6As8mI8hQvVglomeN75uJvTbRFzQTp1TD064zHDFgsdvBvaPu5YrWapIS33i4X/QvzEYpk77k7ml1NLDu6OAaTnpXnVB7LfoJER3+hzo0eaoNWoqfp+4w4PX0mWnnWf8vx0zCbGtKoa2C/+YlR/OqDKbUUlcr5bvi96q3DnfSs/6DOcNzmeQo5H5/z0GW01PqHnITWjbwyjV3M3lwWrnXykifRXMiYgZMi4g+la5zBMRO3SSYqPLW5iNxW1AjaqnFNlU/bmltvKMMveuCgvzOKudl57Rp0gsjvWWdtVFqmR17XR+qWAszNimfvr0ilnf/h+4FGumMoP77ieezO1AJlQa2Xea1SxuwNnn3YhyZO/RydN7+MAhTpPZ+doi9VhbgG6d/d7w1flGq9Uk9y70ZK8lq/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/17 2:02, Jesper Dangaard Brouer wrote: > > Benchmark (bench_page_pool_simple) results from before and after > patchset with patches 1-5m and rcu lock removal as requested. > > | Test name  |Cycles |   1-5 |    | Nanosec |    1-5 |        |      % | > | (tasklet_*)|Before | After |diff|  Before |  After |   diff | change | > |------------+-------+-------+----+---------+--------+--------+--------| > | fast_path  |    19 |    19 |   0|   5.399 |  5.492 |  0.093 |    1.7 | > | ptr_ring   |    54 |    57 |   3|  15.090 | 15.849 |  0.759 |    5.0 | > | slow       |   238 |   284 |  46|  66.134 | 78.909 | 12.775 |   19.3 | > #+TBLFM: $4=$3-$2::$7=$6-$5::$8=(($7/$5)*100);%.1f > > This test with patches 1-5 looks much better regarding performance. Thanks for the testing. Is there any notiable performance variation during different test running for the same built kernel in your machine? > > --Jesper > > https://github.com/xdp-project/xdp-project/blob/main/areas/mem/page_pool07_bench_DMA_fix.org#e5-1650-pp01-dma-fix-v7-p1-5 > > Kernel: >  - 6.13.0-rc6-pp01-DMA-fix-v7-p1-5+ #5 SMP PREEMPT_DYNAMIC Thu Jan 16 18:06:53 CET 2025 x86_64 GNU/Linux > > Machine: Intel(R) Xeon(R) CPU E5-1650 v4 @ 3.60GHz > > modprobe bench_page_pool_simple loops=100000000 > > Raw data: > [  187.309423] bench_page_pool_simple: time_bench_page_pool01_fast_path(): Cannot use page_pool fast-path > [  187.872849] time_bench: Type:no-softirq-page_pool01 Per elem: 19 cycles(tsc) 5.539 ns (step:0) - (measurement period time:0.553906443 sec time_interval:553906443) - (invoke count:100000000 tsc_interval:1994123064) > [  187.892023] bench_page_pool_simple: time_bench_page_pool02_ptr_ring(): Cannot use page_pool fast-path > [  189.611070] time_bench: Type:no-softirq-page_pool02 Per elem: 61 cycles(tsc) 17.095 ns (step:0) - (measurement period time:1.709580367 sec time_interval:1709580367) - (invoke count:100000000 tsc_interval:6154679394) > [  189.630414] bench_page_pool_simple: time_bench_page_pool03_slow(): Cannot use page_pool fast-path > [  197.222387] time_bench: Type:no-softirq-page_pool03 Per elem: 272 cycles(tsc) 75.826 ns (step:0) - (measurement period time:7.582681388 sec time_interval:7582681388) - (invoke count:100000000 tsc_interval:27298499214) > [  197.241926] bench_page_pool_simple: pp_tasklet_handler(): in_serving_softirq fast-path > [  197.249968] bench_page_pool_simple: time_bench_page_pool01_fast_path(): in_serving_softirq fast-path > [  197.808470] time_bench: Type:tasklet_page_pool01_fast_path Per elem: 19 cycles(tsc) 5.492 ns (step:0) - (measurement period time:0.549225541 sec time_interval:549225541) - (invoke count:100000000 tsc_interval:1977272238) > [  197.828174] bench_page_pool_simple: time_bench_page_pool02_ptr_ring(): in_serving_softirq fast-path > [  199.422305] time_bench: Type:tasklet_page_pool02_ptr_ring Per elem: 57 cycles(tsc) 15.849 ns (step:0) - (measurement period time:1.584920736 sec time_interval:1584920736) - (invoke count:100000000 tsc_interval:5705890830) > [  199.442087] bench_page_pool_simple: time_bench_page_pool03_slow(): in_serving_softirq fast-path > [  207.342120] time_bench: Type:tasklet_page_pool03_slow Per elem: 284 cycles(tsc) 78.909 ns (step:0) - (measurement period time:7.890955151 sec time_interval:7890955151) - (invoke count:100000000 tsc_interval:28408319289) >