From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24AEACD1284 for ; Tue, 2 Apr 2024 08:46:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4077E6B0085; Tue, 2 Apr 2024 04:46:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B53A6B0088; Tue, 2 Apr 2024 04:46:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27CAF6B008A; Tue, 2 Apr 2024 04:46:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0F8606B0085 for ; Tue, 2 Apr 2024 04:46:33 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 79BC6160931 for ; Tue, 2 Apr 2024 08:46:32 +0000 (UTC) X-FDA: 81963960624.26.3C88971 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id A9F22C001E for ; Tue, 2 Apr 2024 08:46:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DN08QKvF; spf=pass (imf22.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712047590; a=rsa-sha256; cv=none; b=7KjP/rSLithBp5N3Lib8IiQBuXihZF3H4Qt/0JBm+ujeEB+UHCal4czyB4wUrQXo7OReUX OO5du17j9J5a3+exZf2N6CxLq+6YCGsybuK2VeNV8VIkk6HYzdUkSgoPNaa3ZA2YBWt55e 4SAv2JkOCmslzuAilV5UuLQ3c4EKfRw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DN08QKvF; spf=pass (imf22.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712047590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/8zVm5/YGf5Pgwy9JsdjJMXQWirBEfx89VnmYMfPJM4=; b=cy5JhqebUSdLOLHd/r0XXeo9qGO+4/qJcIj8JP2TDZWi8jrTcEqy/8+3wHinJxvPJwZXDd rPjqQC02mlOyjg4Vyhpwmve92JQBft0eO/i+Oblv/AxGuGzvMz7EAQ6DwgYFzrIf9rUe8y TCNEdkPgQOBm/1GQ+6kHMOVWixsis08= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712047589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/8zVm5/YGf5Pgwy9JsdjJMXQWirBEfx89VnmYMfPJM4=; b=DN08QKvF+kdmbtqDx/3JmWDSsAsYudSAMpcUYfiGezzNOytq9cu9BVq19Nyn4ivmzNsBpw Yvm29ESJ3sjMXR2Gf6RbL8TDRsdZ+PcGVpY4F3Dtn4nFwXfzJl/jks6wYdf3/OMzMfYxga wMyXxuI4v8HpjL3x92qIpiQcj9tWKmY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-jPb3_1pmPI27HEkPRk0xlA-1; Tue, 02 Apr 2024 04:46:21 -0400 X-MC-Unique: jPb3_1pmPI27HEkPRk0xlA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7A144185A784; Tue, 2 Apr 2024 08:46:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D5BC1C060A4; Tue, 2 Apr 2024 08:46:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240328163424.2781320-20-dhowells@redhat.com> References: <20240328163424.2781320-20-dhowells@redhat.com> <20240328163424.2781320-1-dhowells@redhat.com> To: Dan Carpenter , Naveen Mamindlapalli , Vadim Fedorenko Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH 19/26] netfs: New writeback implementation MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3047563.1712047571.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 02 Apr 2024 09:46:11 +0100 Message-ID: <3047564.1712047571@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A9F22C001E X-Stat-Signature: 61f6h9igrjztwyrj7gn4ixng9h1a7fyi X-Rspam-User: X-HE-Tag: 1712047590-135158 X-HE-Meta: U2FsdGVkX18t81lHugA77PyhOe9TD7GquVlLo5QJWZznfXPjkU3uuam6AeNCeWAQUUdBso1S5RwDH6G3NLl390twL+Bbw1/dz5ODzyObV8+9VmXzY1rhx9OAaWx5gxlgjh1hkeu4y9qAXUv3uTI1ojZcMrxBYu7EQUwm/ZFhTqbrdlflMMoGTvYRDnJ8e8z0QjVpwKau5UVQg8f/Mit89Cajp0dDuKqNhfdK4N8hbky6SAXUTEa5XVAf8UQgSxRwzCEhu5ZODQ0zcqd5UKp520F1k7PK/uSuIcIjNEowUTP51vGfK7bTMjsyciBOXzlPIwBHXTnIuewCqDKOjXbiEP4i7yi/mU0jxWOtgKiRTPHbP86i4ce/mQjAOrIDNr5EeYqVExrSwolfEePkynn9Ue02GTqQkWVyumY04XQGxC2W/EJz4ZXYs6Me3oHGgDL1Fepe8a2XanbWHJnDNfCnlpBdbboKYV/dV/pFr16qk2/ANmZK9iOwdaR48oyyp6Xb5R8RQ59n+iT1ldwJZ6a+hKrwnuju5rYZwLmOn8w4fo+ivGGkm0VXJLfOI0Sg61afQrERBgmPggkr3OANq3MYBjq/nYH2CzJ4iWfAOKFji1hRs1pqRFrnh0YKJUjY1WudU06/r0bFLReiEPK9sqQWONre3oF1IznIrtmTeZ7adeseGbocV9zVlCwTR/8ZhmeGWTGrbd3Wf9MWH1xhW3DhOKkbgGiWLQPeLnsdj8Ngv6yagAvVWxydQg+OYTFIpJO12VjnfhqLUh2IPtYLLxJfcYN5qyy99SE/Kz/3QFO+Om2Z++V2O9fN81MCIVxeV5TMCrC3sAjq/25q4XnYpsSiPtLWebTaHz2ypNSG9dK8grsaNRV+bQP6DKeuc0F/Bt/iG6LnonGYbkcnjkghA9ckZzt3HDKEsKtRcZrTL83J1bwYHoxzUxfZwjVnTbTi2dRzI21Mu2R645FI8DBH4ln IU98f5Am KMwivUeCV3OEtyu70OxhhoMI40ZB1vBOe+nRdxTvu/Blly53qAR95TfRdjCF57biXcbLY2hEdiUXJ3WsVnctncoptt7UKMzmhjDNpgv2DuroDlkMPusLGrKaJAYGJ6f/xUfmygwETocu974TQt3IOraKL9mq4lwcs6B+VUi7wDJfhRfC7CLAKARKxRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells wrote: > +struct netfs_io_request *new_netfs_begin_writethrough(struct kiocb *ioc= b, size_t len) > +{ > + struct netfs_io_request *wreq =3D NULL; > + struct netfs_inode *ictx =3D netfs_inode(file_inode(iocb->ki_filp)); > + > + mutex_lock(&ictx->wb_lock); > + > + wreq =3D netfs_create_write_req(iocb->ki_filp->f_mapping, iocb->ki_fil= p, > + iocb->ki_pos, NETFS_WRITETHROUGH); > + if (IS_ERR(wreq)) > + mutex_unlock(&ictx->wb_lock); This needs a "return wreq;" adding and appropriate braces. Thanks to thos= e who pointed it out. David