Re: [PATCH] mm, soft_offline: improve hugepage soft offlining error log

[Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>]

On 10/17/2017 02:17 AM, Laszlo Toth wrote:
> On a failed attempt, we get the following entry:
> soft offline: 0x3c0000: migration failed 1, type 17ffffc0008008
> (uptodate|head)
> 
> Make this more specific to be straightforward and to follow
> other error log formats in soft_offline_huge_page().
> 
> Signed-off-by: Laszlo Toth <laszlth@gmail.com>

Looks good to me.

Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  mm/memory-failure.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 8836662..4acdf39 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1587,7 +1587,7 @@ static int soft_offline_huge_page(struct page *page, int flags)
>  	ret = migrate_pages(&pagelist, new_page, NULL, MPOL_MF_MOVE_ALL,
>  				MIGRATE_SYNC, MR_MEMORY_FAILURE);
>  	if (ret) {
> -		pr_info("soft offline: %#lx: migration failed %d, type %lx (%pGp)\n",
> +		pr_info("soft offline: %#lx: hugepage migration failed %d, type %lx (%pGp)\n",
>  			pfn, ret, page->flags, &page->flags);
>  		if (!list_empty(&pagelist))
>  			putback_movable_pages(&pagelist);
> 
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>