From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA838D2FFF2 for ; Fri, 18 Oct 2024 11:07:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 865446B0095; Fri, 18 Oct 2024 07:07:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8164E6B0096; Fri, 18 Oct 2024 07:07:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68F566B0099; Fri, 18 Oct 2024 07:07:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 46C8C6B0095 for ; Fri, 18 Oct 2024 07:07:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 96E31140686 for ; Fri, 18 Oct 2024 11:07:38 +0000 (UTC) X-FDA: 82686447438.01.3ABA058 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id D6BD3C0010 for ; Fri, 18 Oct 2024 11:07:37 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="R/3COgJR"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729249521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zPH7YHwbwvmT7u+3IgUOf1s+0iAzvWnBLzEmupUAegE=; b=M3Pj32Hojo3irhitULVdntn/NozTl+RoAwjb8CV+vqkMgYABtNnhGSnlB1I93kNN3tt26J DGodCTojaKPpncPEKFL/TxToZwIVcUiarXj5NSVGEotksPhfyDSrCQoh+CniFynIChHxIw 5g46A6USOY+km7JYGj76eHhmadWjSSk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729249521; a=rsa-sha256; cv=none; b=bmZaFZrWHbZM+9GBu3rEwPdQ9oN87O4UQPgVF4W0e9klzY6k+hfghwGoBJRTKm95fTXMkD DRE1X3ieAhLlwC9OuTzFW70WrLCy1SZ9tGUN3fx2O3DuXqcDSO13xAaHYqs3t+SmdTvgiz awzrWDZ2IXLBbZktCC2/9QTQYtMpzJk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="R/3COgJR"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729249668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zPH7YHwbwvmT7u+3IgUOf1s+0iAzvWnBLzEmupUAegE=; b=R/3COgJR9ZTu1wWAHn13J4cul/cctxwpkmZ2IcAOCrrt/wY8iywM0uiMI5m00shVQHnQJ8 0xnp55a5Yn5mydlPLja7MqSfRHwjGCqA+E8SQoVCnS2VxZxGeuE6zeaoUpzdvKzr/tJ8Ol KPzxBI848rT4ZIoG6SUaowzDSyJltOQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-539-L7WW28UpMMOoAcATYcG_6g-1; Fri, 18 Oct 2024 07:07:46 -0400 X-MC-Unique: L7WW28UpMMOoAcATYcG_6g-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4315544642eso14541935e9.3 for ; Fri, 18 Oct 2024 04:07:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729249665; x=1729854465; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zPH7YHwbwvmT7u+3IgUOf1s+0iAzvWnBLzEmupUAegE=; b=F28vEOOaQFKlTda8BvxUFm2e5yqU0TcJ2E0K6/ATGxkES/Bi1kEPC3NVJfRV/YW6io R7F4N7u+/nKYgA2dwS86q8OmEu4UdDXooN0SGkpBm5duzs7WbUslLC8WjKV8itdLqVq9 RvK65wjCaFV6LT97mYJjkoHorFeFfSkD7Mf2qRPvv1fi+6uOGW7i3IIDpvHyIw53PDnU PU6nLWmwMQ2th6xmi2G+9iJDjLZ6swf94VWScYiGW85KVneRtc9qv7lXSwQ633cagosu msyU2/C/op14cHlNegBB2Ei4j6BUGym2rnMg5Vz7T8xHjb4MtF8UspBkAcE4Hvv2w4uP cYvw== X-Gm-Message-State: AOJu0YyIveKENW6otu3v1nja4SXwJveRRBFXSCImTAgBViyH+Iz5lf7w FIw/k/FjP2119KaP58QuJztRR4tUKjt+JXXgaPpFbPVcDM4tNb/MrRstri4dMo4NuI/+mqA+iFJ u6V8HhyWB8vpZMZy8iop4e+wNBTUjkdv6/mqXZ3QpScln0iyG X-Received: by 2002:a05:600c:1c0a:b0:431:51e5:2316 with SMTP id 5b1f17b1804b1-431616911d5mr16535045e9.34.1729249665558; Fri, 18 Oct 2024 04:07:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrJq0EXn/DonSrv0F32XX378BDnZolbtlCFU87NepxkBh91yZXKigwytVuTmpmZnAlfoE7CA== X-Received: by 2002:a05:600c:1c0a:b0:431:51e5:2316 with SMTP id 5b1f17b1804b1-431616911d5mr16534775e9.34.1729249665044; Fri, 18 Oct 2024 04:07:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:2400:68a3:92e0:906f:b69d? (p200300cbc707240068a392e0906fb69d.dip0.t-ipconnect.de. [2003:cb:c707:2400:68a3:92e0:906f:b69d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ecf06d24dsm1642534f8f.44.2024.10.18.04.07.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2024 04:07:44 -0700 (PDT) Message-ID: <30452c92-2fcd-4931-b58f-4d37713c84bc@redhat.com> Date: Fri, 18 Oct 2024 13:07:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Next steps towards shrinking stuct page To: Matthew Wilcox Cc: linux-mm@kvack.org, Yu Zhao References: <399f12d4-b01d-40bd-aba7-e3c565fbd8cb@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 1dk9io4donya4a8ijxbjo4cx3f4roimn X-Rspamd-Queue-Id: D6BD3C0010 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729249657-967797 X-HE-Meta: U2FsdGVkX1/a3TQvSpUxLZxAd8A9pUycDSXqE0bmX7P1eGvvnJZVPSWIK6o7EJmBmvrFXIM720FhYqL2aVyiqKuJGZSn5HISDgbYYY1I10jazK1kuIj1RpJeuY0x3sw4OxrjottreW+8JJYDIVJnJrbDk5jQPSRlw40wHPa2jK+BIcI5ODFnUshtR6TdxQ7ex7JMqAlgNWoyTE5WHSlxCkBHHFnlfI4t7J0dFkEnmyBpCc4uULXJ/NhJqid+d4kJyKhXUj2Tj8oGp3+fjKN/hbNhLP1rHbvz3fM/AiX31xXH6+w4pQDr6zWkSCdhoLB06I33OVB/EV9AwMv36CT0GjcSiPSnynNhFUZBGmgtJEBs0XxOyjkpu9+42CDYmiGDm7xo2A3rSLz7XZZUFAoN+PxqjpN9e4LgpLyQqLxOIVDDlOXXHuGkBKv9+ubGpwX6aTCO+Wn+XrPP+pgsT1XakGqSDdMZTZiDwUF+WuA33XW1R0gCOlCYVbYppq5W0TXTQgRIddPWDzAeCFYfTMJp6ne74Q+T20SSgwKK0nl2kPS+ACNWB7cwDxemcN0uG6TLhQxaJX6wZr+5nIbRsZTdCyKtD/7EMHrYJdYxvLP704Gdrg5WzdaItJig0OKPJy3DqYtrxw/N3uhgqjgZpNHeOD4+9pft/NmeWHQpvWo2TseGGyRehSb6MuANzQUnQL895HgCg+KaiofLy3OJHXn0ATtxYeku5zd7ALRBO5XNdhzMsp1noqrEsUVcpJiC+QoyjBowP5PHPzC4Ipr9z2nyH5Q9PqcTQLqSjAWW46vYa/AMWFHsayE3DiwgZAqy2eqDnq9vA56l6JWlSxG49ISM/P52sqpx/Khj/v/yM+JjMd3N4qiWfENWoXW34UWzatdsFM+NPYsi1s0mXkjSqEu0CNlQpja1VHDzOEhu8nsjk5qfxRQfa5qco0YCJtZYPorxbh4TjC6/yxaqACor2tm VGGQX5YY 9amL8lhFVGV4jEFy1C3fyQIJc8DFGo+h+FXFotUAw37GIKbf5z9Ws5MEoRexXfuC1gjMCBJBm0ZR+ESuTycCK0fAijFf1ObrlzhhTj0MQ1TGLzkKEPOBbqPNXPOr7i34wX8TXk8yLMJPtSSQgpbP66jXAmHIeUVthmMOkL0eWYt4rz+Dn5xhaK3IzdoFqTt4ZPqrn5Hc9D2pElHP1nYzYzN0ljcAzfEEhsE3rwZS9F1tWhKY1nSkYXbFThWHdFe6QPkCcm6VrhWJFi1ZTvFV2VuPoPJQVi3Pp67zL0+dfXfSG829xWd8TT/Zw156w5Rg+IUDZC6oCgwhfvzVQA/Fu/u1rupJ2ZzcbxcOnviUiEE9/SzqHcI3nfheB8j7xW7fPho2MloGl18SPxmA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.10.24 12:46, Matthew Wilcox wrote: > On Tue, Oct 08, 2024 at 04:16:39PM +0200, David Hildenbrand wrote: >>> >>> 4. Make sure that we're good with memcg_data. I think we are (it's only >>> used in folios and slabs today, I _think_), but it'll be good to be >>> sure. Someone who understands memcg better than I do can probably find >>> some stuff to clean up. >> >> Last time I looked at this (1month ago), I had the same impression. > > I took a shot at this. The problem is mm/page_alloc.c: > > __alloc_pages_noprof: > if (memcg_kmem_online() && (gfp & __GFP_ACCOUNT) && page && > unlikely(__memcg_kmem_charge_page(page, gfp, order) != 0)) { > __free_pages(page, order); > page = NULL; > } > Right, I recall that we are only touching the first page. IIRC, it's not necessarily a compound page. > I think someone (maybe Yosry?) tried to explain this problem to me at > LSFMM, but I didn't understand. > > Most of the places that use GFP_KERNEL_ACCOUNT are either page tables > or kmalloc/kvmalloc. But I think we're going to need a new memdesc > type for accounted memory. > > struct accounted_mem { > unsigned long flags; > struct obj_cgroup *objcg; > }; > > (we'll be able to drop MEMCG_DATA_* once we have the memdesc type, but > we need to keep it until we're there). > > So I guess that's my next step -- adding: > > struct accounted_mem { > unsigned long flags; > unsigned long padding[5]; > unsigned int padding2[2]; > unsigned long objcg; > }; > > and the various assertions that objcg & flags occupy the same bytes in > accounted_mem as they do in page, until we separate them entirely. But how to do that without a compound page? -- Cheers, David / dhildenb